From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties Date: Fri, 30 Nov 2018 22:08:14 +0100 Message-ID: <20181130210814.GA5756@amd> References: <1541542052-10081-1-git-send-email-jacek.anaszewski@gmail.com> <1541542052-10081-5-git-send-email-jacek.anaszewski@gmail.com> <5bea0eb8.1c69fb81.6b921.80e6@mx.google.com> <0a0b176c-4eb4-4b0e-6c3c-b3c6c8f5fff5@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Jacek Anaszewski , Linux LED Subsystem , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Baolin Wang , Daniel Mack , Dan Murphy , Linus Walleij , Oleh Kravchenko , Sakari Ailus , Simon Shields List-Id: linux-leds@vger.kernel.org --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > Pavel gave following examples: > > > > eth0:green:link > > adsl0:green:link > > adsl0:red:error > > > > So we would have e.g.: > > > > associated-vl42-device =3D <&camera1>; > > associated-network-device =3D <&phy1>; > > associated-block-device =3D <&phy1>; >=20 > Variable property names are kind of a pain to parse. Ok, would it be enough to have associated-device =3D <&whatever>? > Perhaps when LEDs are associated with a device, we shouldn't care > within the context of the LED subsystem what the name is. The > association is more important and if you have that exposed, then you > don't really need to care what the name is. You still have to deal > with a device with more than 1 LED, but that becomes a problem local > to that device. >=20 > What I'm getting at is following a more standard binding pattern of > providers and consumers like we have for gpios, clocks, etc. So we'd > have something like this: >=20 > ethernet { > ... > leds =3D <&green_led>, <&red_led>; > led-names =3D "link", "err"; > }; Basically every single device could have a LED associated with it ("activity"). Would doing it like this mean we'd have to modify every single driver to parse leds / led-names properties? Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlwBpr4ACgkQMOfwapXb+vL96QCfdY7k6J8earpw9VTU/PFyLHAg 0TcAn35xQjH4+gVL97ylZhidUy84B5+h =5ag6 -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv--