From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 083D3C04EB8 for ; Sun, 2 Dec 2018 19:35:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC6AD20851 for ; Sun, 2 Dec 2018 19:35:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC6AD20851 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725780AbeLBTfQ convert rfc822-to-8bit (ORCPT ); Sun, 2 Dec 2018 14:35:16 -0500 Received: from mail.bootlin.com ([62.4.15.54]:38209 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725616AbeLBTfQ (ORCPT ); Sun, 2 Dec 2018 14:35:16 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 9B05820787; Sun, 2 Dec 2018 20:35:11 +0100 (CET) Received: from xps13 (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id A1C902071D; Sun, 2 Dec 2018 20:35:10 +0100 (CET) Date: Sun, 2 Dec 2018 20:35:09 +0100 From: Miquel Raynal To: Russell King - ARM Linux Cc: Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Kishon Vijay Abraham I , Mark Rutland , devicetree@vger.kernel.org, Antoine Tenart , Grzegorz Jaszczyk , linux-kernel@vger.kernel.org, Maxime Chevallier , Nadav Haklai , Rob Herring , Thomas Petazzoni , Marcin Wojtas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate() Message-ID: <20181202203509.21b067c4@xps13> In-Reply-To: <20181130190031.GH30658@n2100.armlinux.org.uk> References: <20181130144743.675-1-miquel.raynal@bootlin.com> <20181130144743.675-3-miquel.raynal@bootlin.com> <20181130190031.GH30658@n2100.armlinux.org.uk> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Russell, Russell King - ARM Linux wrote on Fri, 30 Nov 2018 19:00:31 +0000: > On Fri, Nov 30, 2018 at 03:47:37PM +0100, Miquel Raynal wrote: > > So far the PHY ->xlate() callback was checking if the port was > > "invalid" before continuing, meaning that the port has not been used > > yet. This check is not correct as there is no opposite call to > > ->xlate() once the PHY is released by the user and the port will > > remain "valid" after the first phy_get()/phy_put() calls. Hence, if > > this driver is built as a module, inserted, removed and inserted > > again, the PHY will appear busy and the second probe will fail. > > > > To fix this, just drop the faulty check and instead verify that the > > port number is valid (ie. in the possible range). > > > > Signed-off-by: Miquel Raynal > > --- > > drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c > > index 31b9a1c18345..a40b876ff214 100644 > > --- a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c > > +++ b/drivers/phy/marvell/phy-mvebu-cp110-comphy.c > > @@ -567,9 +567,9 @@ static struct phy *mvebu_comphy_xlate(struct device *dev, > > return phy; > > > > lane = phy_get_drvdata(phy); > > - if (lane->port >= 0) > > - return ERR_PTR(-EBUSY); > > lane->port = args->args[0]; > > + if (lane->port >= MVEBU_COMPHY_PORTS) > > + return ERR_PTR(-EINVAL); > > Shouldn't we validate args->args[0] before doing anything? > I don't understand your point, there is a check on args->args[0] as we check its value (through lane->port) right after. What do you have in mind? Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F93C04EB8 for ; Sun, 2 Dec 2018 19:35:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A828C20851 for ; Sun, 2 Dec 2018 19:35:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="canWdyzf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A828C20851 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0/AQzN29FL2VNiu1x2xfW7mqvJgw084YsUv33cK6mx0=; b=canWdyzftd0bq0 tY2KkrCdppTpxFrHI0yqFY5CeaAGxy/NSYB4SJxVEOajGZUtOoRYdYVtRTL5ydGFZpaNViZyt4jAb dFf78TOddbCAo7L/MJZP+s9KisaKFRigC8AlfxmdJvVsJI/6W2hIEOpb8IH9oxdumMZSC/13t2rNA nzEu06YMsvI9/KXj/pGV0x9e4iuqExM66YhjgLD0QYDJr0Z1xNeAs508PBRTsIcQunQPKanR15GH+ zLkWmIc/e50lfkjrHMkfD81+AkatWE48nOq++7XhSo5wMK0XYb+Npuhya1cXUbypr8gbsgnoh7CVR mLbXc7urBlVovE+9esgQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gTXWb-0000CT-HX; Sun, 02 Dec 2018 19:35:29 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gTXWX-0000At-0d for linux-arm-kernel@lists.infradead.org; Sun, 02 Dec 2018 19:35:27 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 9B05820787; Sun, 2 Dec 2018 20:35:11 +0100 (CET) Received: from xps13 (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id A1C902071D; Sun, 2 Dec 2018 20:35:10 +0100 (CET) Date: Sun, 2 Dec 2018 20:35:09 +0100 From: Miquel Raynal To: Russell King - ARM Linux Subject: Re: [PATCH v2 2/8] phy: mvebu-cp110-comphy: fix port check in ->xlate() Message-ID: <20181202203509.21b067c4@xps13> In-Reply-To: <20181130190031.GH30658@n2100.armlinux.org.uk> References: <20181130144743.675-1-miquel.raynal@bootlin.com> <20181130144743.675-3-miquel.raynal@bootlin.com> <20181130190031.GH30658@n2100.armlinux.org.uk> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181202_113526_042271_BA144483 X-CRM114-Status: GOOD ( 21.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Lunn , Marcin Wojtas , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , Grzegorz Jaszczyk , Gregory Clement , linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Nadav Haklai , Rob Herring , Thomas Petazzoni , Maxime Chevallier , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUnVzc2VsbCwKClJ1c3NlbGwgS2luZyAtIEFSTSBMaW51eCA8bGludXhAYXJtbGludXgub3Jn LnVrPiB3cm90ZSBvbiBGcmksIDMwIE5vdgoyMDE4IDE5OjAwOjMxICswMDAwOgoKPiBPbiBGcmks IE5vdiAzMCwgMjAxOCBhdCAwMzo0NzozN1BNICswMTAwLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ ID4gU28gZmFyIHRoZSBQSFkgLT54bGF0ZSgpIGNhbGxiYWNrIHdhcyBjaGVja2luZyBpZiB0aGUg cG9ydCB3YXMKPiA+ICJpbnZhbGlkIiBiZWZvcmUgY29udGludWluZywgbWVhbmluZyB0aGF0IHRo ZSBwb3J0IGhhcyBub3QgYmVlbiB1c2VkCj4gPiB5ZXQuIFRoaXMgY2hlY2sgaXMgbm90IGNvcnJl Y3QgYXMgdGhlcmUgaXMgbm8gb3Bwb3NpdGUgY2FsbCB0byAgCj4gPiAtPnhsYXRlKCkgb25jZSB0 aGUgUEhZIGlzIHJlbGVhc2VkIGJ5IHRoZSB1c2VyIGFuZCB0aGUgcG9ydCB3aWxsICAKPiA+IHJl bWFpbiAidmFsaWQiIGFmdGVyIHRoZSBmaXJzdCBwaHlfZ2V0KCkvcGh5X3B1dCgpIGNhbGxzLiBI ZW5jZSwgaWYKPiA+IHRoaXMgZHJpdmVyIGlzIGJ1aWx0IGFzIGEgbW9kdWxlLCBpbnNlcnRlZCwg cmVtb3ZlZCBhbmQgaW5zZXJ0ZWQKPiA+IGFnYWluLCB0aGUgUEhZIHdpbGwgYXBwZWFyIGJ1c3kg YW5kIHRoZSBzZWNvbmQgcHJvYmUgd2lsbCBmYWlsLgo+ID4gCj4gPiBUbyBmaXggdGhpcywganVz dCBkcm9wIHRoZSBmYXVsdHkgY2hlY2sgYW5kIGluc3RlYWQgdmVyaWZ5IHRoYXQgdGhlCj4gPiBw b3J0IG51bWJlciBpcyB2YWxpZCAoaWUuIGluIHRoZSBwb3NzaWJsZSByYW5nZSkuCj4gPiAKPiA+ IFNpZ25lZC1vZmYtYnk6IE1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+ Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL3BoeS9tYXJ2ZWxsL3BoeS1tdmVidS1jcDExMC1jb21waHku YyB8IDQgKystLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9tYXJ2ZWxsL3BoeS1tdmVi dS1jcDExMC1jb21waHkuYyBiL2RyaXZlcnMvcGh5L21hcnZlbGwvcGh5LW12ZWJ1LWNwMTEwLWNv bXBoeS5jCj4gPiBpbmRleCAzMWI5YTFjMTgzNDUuLmE0MGI4NzZmZjIxNCAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvcGh5L21hcnZlbGwvcGh5LW12ZWJ1LWNwMTEwLWNvbXBoeS5jCj4gPiArKysg Yi9kcml2ZXJzL3BoeS9tYXJ2ZWxsL3BoeS1tdmVidS1jcDExMC1jb21waHkuYwo+ID4gQEAgLTU2 Nyw5ICs1NjcsOSBAQCBzdGF0aWMgc3RydWN0IHBoeSAqbXZlYnVfY29tcGh5X3hsYXRlKHN0cnVj dCBkZXZpY2UgKmRldiwKPiA+ICAJCXJldHVybiBwaHk7Cj4gPiAgCj4gPiAgCWxhbmUgPSBwaHlf Z2V0X2RydmRhdGEocGh5KTsKPiA+IC0JaWYgKGxhbmUtPnBvcnQgPj0gMCkKPiA+IC0JCXJldHVy biBFUlJfUFRSKC1FQlVTWSk7Cj4gPiAgCWxhbmUtPnBvcnQgPSBhcmdzLT5hcmdzWzBdOwo+ID4g KwlpZiAobGFuZS0+cG9ydCA+PSBNVkVCVV9DT01QSFlfUE9SVFMpCj4gPiArCQlyZXR1cm4gRVJS X1BUUigtRUlOVkFMKTsgIAo+IAo+IFNob3VsZG4ndCB3ZSB2YWxpZGF0ZSBhcmdzLT5hcmdzWzBd IGJlZm9yZSBkb2luZyBhbnl0aGluZz8KPiAKCkkgZG9uJ3QgdW5kZXJzdGFuZCB5b3VyIHBvaW50 LCB0aGVyZSBpcyBhIGNoZWNrIG9uIGFyZ3MtPmFyZ3NbMF0gYXMKd2UgY2hlY2sgaXRzIHZhbHVl ICh0aHJvdWdoIGxhbmUtPnBvcnQpIHJpZ2h0IGFmdGVyLiBXaGF0IGRvIHlvdQpoYXZlIGluIG1p bmQ/CgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==