From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Date: Mon, 03 Dec 2018 16:28:16 +0000 Subject: Re: [PATCH v2 3/6] sh: prefer memblock APIs returning virtual address Message-Id: <20181203162816.GA26700@rapoport-lnx> List-Id: References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-4-git-send-email-rppt@linux.ibm.com> <20181203161052.GA4244@ravnborg.org> In-Reply-To: <20181203161052.GA4244@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sam Ravnborg Cc: Michal Hocko , linux-sh@vger.kernel.org, Benjamin Herrenschmidt , linux-mm@kvack.org, Rich Felker , Paul Mackerras , sparclinux@vger.kernel.org, Vincent Chen , Jonas Bonn , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Michael Ellerman , Russell King , Mark Salter , Arnd Bergmann , Stefan Kristiansson , openrisc@lists.librecores.org, Greentime Hu , Stafford Horne , Guan Xuetao , linux-arm-kernel@lists.infradead.org, Michal Simek , linux-kernel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Mon, Dec 03, 2018 at 05:10:52PM +0100, Sam Ravnborg wrote: > Hi Mike. > > On Mon, Dec 03, 2018 at 05:47:12PM +0200, Mike Rapoport wrote: > > Rather than use the memblock_alloc_base that returns a physical address and > > then convert this address to the virtual one, use appropriate memblock > > function that returns a virtual address. > > > > There is a small functional change in the allocation of then NODE_DATA(). > > Instead of panicing if the local allocation failed, the non-local > > allocation attempt will be made. > > > > Signed-off-by: Mike Rapoport > > --- > > arch/sh/mm/init.c | 18 +++++------------- > > arch/sh/mm/numa.c | 5 ++--- > > 2 files changed, 7 insertions(+), 16 deletions(-) > > > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > > index c8c13c77..3576b5f 100644 > > --- a/arch/sh/mm/init.c > > +++ b/arch/sh/mm/init.c > > @@ -192,24 +192,16 @@ void __init page_table_range_init(unsigned long start, unsigned long end, > > void __init allocate_pgdat(unsigned int nid) > > { > > unsigned long start_pfn, end_pfn; > > -#ifdef CONFIG_NEED_MULTIPLE_NODES > > - unsigned long phys; > > -#endif > > > > get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); > > > > #ifdef CONFIG_NEED_MULTIPLE_NODES > > - phys = __memblock_alloc_base(sizeof(struct pglist_data), > > - SMP_CACHE_BYTES, end_pfn << PAGE_SHIFT); > > - /* Retry with all of system memory */ > > - if (!phys) > > - phys = __memblock_alloc_base(sizeof(struct pglist_data), > > - SMP_CACHE_BYTES, memblock_end_of_DRAM()); > > - if (!phys) > > + NODE_DATA(nid) = memblock_alloc_try_nid_nopanic( > > + sizeof(struct pglist_data), > > + SMP_CACHE_BYTES, MEMBLOCK_LOW_LIMIT, > > + MEMBLOCK_ALLOC_ACCESSIBLE, nid); > > + if (!NODE_DATA(nid)) > > panic("Can't allocate pgdat for node %d\n", nid); > > - > > - NODE_DATA(nid) = __va(phys); > > - memset(NODE_DATA(nid), 0, sizeof(struct pglist_data)); > The new code will always assign NODE_DATA(nid), where the old > code only assigned NODE_DATA(nid) in the good case. > I dunno if this is an issue, just noticed the difference and > wanted to point it out. If the allocation fails the NODE_DATA(nid) remains zero anyway and there is a panic() call. So I think there is no actual functional change here. > Sam > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9385C04EB9 for ; Mon, 3 Dec 2018 16:28:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CEEF20661 for ; Mon, 3 Dec 2018 16:28:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CEEF20661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbeLCQ2g (ORCPT ); Mon, 3 Dec 2018 11:28:36 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48912 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726829AbeLCQ2g (ORCPT ); Mon, 3 Dec 2018 11:28:36 -0500 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wB3GQTg3125980 for ; Mon, 3 Dec 2018 11:28:32 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2p5685e5my-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 03 Dec 2018 11:28:31 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Dec 2018 16:28:28 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 3 Dec 2018 16:28:21 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wB3GSKaf25690160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 3 Dec 2018 16:28:20 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 99EB6A4054; Mon, 3 Dec 2018 16:28:20 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 55F64A4060; Mon, 3 Dec 2018 16:28:18 +0000 (GMT) Received: from rapoport-lnx (unknown [9.148.206.196]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 3 Dec 2018 16:28:18 +0000 (GMT) Date: Mon, 3 Dec 2018 18:28:16 +0200 From: Mike Rapoport To: Sam Ravnborg Cc: Andrew Morton , Arnd Bergmann , Benjamin Herrenschmidt , "David S. Miller" , Guan Xuetao , Greentime Hu , Jonas Bonn , Michael Ellerman , Michal Hocko , Michal Simek , Mark Salter , Paul Mackerras , Rich Felker , Russell King , Stefan Kristiansson , Stafford Horne , Vincent Chen , Yoshinori Sato , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v2 3/6] sh: prefer memblock APIs returning virtual address References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-4-git-send-email-rppt@linux.ibm.com> <20181203161052.GA4244@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181203161052.GA4244@ravnborg.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18120316-4275-0000-0000-000002EB6519 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18120316-4276-0000-0000-000037F86955 Message-Id: <20181203162816.GA26700@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-12-03_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812030154 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 03, 2018 at 05:10:52PM +0100, Sam Ravnborg wrote: > Hi Mike. > > On Mon, Dec 03, 2018 at 05:47:12PM +0200, Mike Rapoport wrote: > > Rather than use the memblock_alloc_base that returns a physical address and > > then convert this address to the virtual one, use appropriate memblock > > function that returns a virtual address. > > > > There is a small functional change in the allocation of then NODE_DATA(). > > Instead of panicing if the local allocation failed, the non-local > > allocation attempt will be made. > > > > Signed-off-by: Mike Rapoport > > --- > > arch/sh/mm/init.c | 18 +++++------------- > > arch/sh/mm/numa.c | 5 ++--- > > 2 files changed, 7 insertions(+), 16 deletions(-) > > > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > > index c8c13c77..3576b5f 100644 > > --- a/arch/sh/mm/init.c > > +++ b/arch/sh/mm/init.c > > @@ -192,24 +192,16 @@ void __init page_table_range_init(unsigned long start, unsigned long end, > > void __init allocate_pgdat(unsigned int nid) > > { > > unsigned long start_pfn, end_pfn; > > -#ifdef CONFIG_NEED_MULTIPLE_NODES > > - unsigned long phys; > > -#endif > > > > get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); > > > > #ifdef CONFIG_NEED_MULTIPLE_NODES > > - phys = __memblock_alloc_base(sizeof(struct pglist_data), > > - SMP_CACHE_BYTES, end_pfn << PAGE_SHIFT); > > - /* Retry with all of system memory */ > > - if (!phys) > > - phys = __memblock_alloc_base(sizeof(struct pglist_data), > > - SMP_CACHE_BYTES, memblock_end_of_DRAM()); > > - if (!phys) > > + NODE_DATA(nid) = memblock_alloc_try_nid_nopanic( > > + sizeof(struct pglist_data), > > + SMP_CACHE_BYTES, MEMBLOCK_LOW_LIMIT, > > + MEMBLOCK_ALLOC_ACCESSIBLE, nid); > > + if (!NODE_DATA(nid)) > > panic("Can't allocate pgdat for node %d\n", nid); > > - > > - NODE_DATA(nid) = __va(phys); > > - memset(NODE_DATA(nid), 0, sizeof(struct pglist_data)); > The new code will always assign NODE_DATA(nid), where the old > code only assigned NODE_DATA(nid) in the good case. > I dunno if this is an issue, just noticed the difference and > wanted to point it out. If the allocation fails the NODE_DATA(nid) remains zero anyway and there is a panic() call. So I think there is no actual functional change here. > Sam > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4560C04EB9 for ; Mon, 3 Dec 2018 16:31:54 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 546A220661 for ; Mon, 3 Dec 2018 16:31:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 546A220661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 437r9h5P87zDqSg for ; Tue, 4 Dec 2018 03:31:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=rppt@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 437r5w6K0kzDqNR for ; Tue, 4 Dec 2018 03:28:36 +1100 (AEDT) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wB3GPpp3081312 for ; Mon, 3 Dec 2018 11:28:34 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2p57n41gg7-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 03 Dec 2018 11:28:34 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Dec 2018 16:28:28 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 3 Dec 2018 16:28:21 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wB3GSKaf25690160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 3 Dec 2018 16:28:20 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 99EB6A4054; Mon, 3 Dec 2018 16:28:20 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 55F64A4060; Mon, 3 Dec 2018 16:28:18 +0000 (GMT) Received: from rapoport-lnx (unknown [9.148.206.196]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 3 Dec 2018 16:28:18 +0000 (GMT) Date: Mon, 3 Dec 2018 18:28:16 +0200 From: Mike Rapoport To: Sam Ravnborg Subject: Re: [PATCH v2 3/6] sh: prefer memblock APIs returning virtual address References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-4-git-send-email-rppt@linux.ibm.com> <20181203161052.GA4244@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181203161052.GA4244@ravnborg.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18120316-4275-0000-0000-000002EB6519 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18120316-4276-0000-0000-000037F86955 Message-Id: <20181203162816.GA26700@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-12-03_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812030154 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , linux-sh@vger.kernel.org, linux-mm@kvack.org, Rich Felker , Paul Mackerras , sparclinux@vger.kernel.org, Vincent Chen , Jonas Bonn , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Russell King , Mark Salter , Arnd Bergmann , Stefan Kristiansson , openrisc@lists.librecores.org, Greentime Hu , Stafford Horne , Guan Xuetao , linux-arm-kernel@lists.infradead.org, Michal Simek , linux-kernel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Dec 03, 2018 at 05:10:52PM +0100, Sam Ravnborg wrote: > Hi Mike. > > On Mon, Dec 03, 2018 at 05:47:12PM +0200, Mike Rapoport wrote: > > Rather than use the memblock_alloc_base that returns a physical address and > > then convert this address to the virtual one, use appropriate memblock > > function that returns a virtual address. > > > > There is a small functional change in the allocation of then NODE_DATA(). > > Instead of panicing if the local allocation failed, the non-local > > allocation attempt will be made. > > > > Signed-off-by: Mike Rapoport > > --- > > arch/sh/mm/init.c | 18 +++++------------- > > arch/sh/mm/numa.c | 5 ++--- > > 2 files changed, 7 insertions(+), 16 deletions(-) > > > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > > index c8c13c77..3576b5f 100644 > > --- a/arch/sh/mm/init.c > > +++ b/arch/sh/mm/init.c > > @@ -192,24 +192,16 @@ void __init page_table_range_init(unsigned long start, unsigned long end, > > void __init allocate_pgdat(unsigned int nid) > > { > > unsigned long start_pfn, end_pfn; > > -#ifdef CONFIG_NEED_MULTIPLE_NODES > > - unsigned long phys; > > -#endif > > > > get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); > > > > #ifdef CONFIG_NEED_MULTIPLE_NODES > > - phys = __memblock_alloc_base(sizeof(struct pglist_data), > > - SMP_CACHE_BYTES, end_pfn << PAGE_SHIFT); > > - /* Retry with all of system memory */ > > - if (!phys) > > - phys = __memblock_alloc_base(sizeof(struct pglist_data), > > - SMP_CACHE_BYTES, memblock_end_of_DRAM()); > > - if (!phys) > > + NODE_DATA(nid) = memblock_alloc_try_nid_nopanic( > > + sizeof(struct pglist_data), > > + SMP_CACHE_BYTES, MEMBLOCK_LOW_LIMIT, > > + MEMBLOCK_ALLOC_ACCESSIBLE, nid); > > + if (!NODE_DATA(nid)) > > panic("Can't allocate pgdat for node %d\n", nid); > > - > > - NODE_DATA(nid) = __va(phys); > > - memset(NODE_DATA(nid), 0, sizeof(struct pglist_data)); > The new code will always assign NODE_DATA(nid), where the old > code only assigned NODE_DATA(nid) in the good case. > I dunno if this is an issue, just noticed the difference and > wanted to point it out. If the allocation fails the NODE_DATA(nid) remains zero anyway and there is a panic() call. So I think there is no actual functional change here. > Sam > -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 140FEC04EB9 for ; Mon, 3 Dec 2018 16:28:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB5EF20661 for ; Mon, 3 Dec 2018 16:28:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kdfQN8Xc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB5EF20661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:In-Reply-To:MIME-Version: References:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L+jr5TLXRY70d9Gvh87deGlJkcr/x+YjZ3Ke8DZz4Zk=; b=kdfQN8Xc/zZ1Wh 9dBRLLDJpJV9ME5nOa7hRNhihLlPnEkS3iceY8wAa7//SoTnwYAdf45gtWzonddLRWe1nPOjo/oUu zoenx0g1wRJwxfCcqOdg112xwTGvesnI8SN45mXSKNw7CycSLGW013+kvu1MrMANi0Fh9jmfsHOKi l/c2C1hxPosnV2D8Std2NmVAZkgn4t/e5+S08xSXPlLl78YAMr27hzZQU0Atctgim2Dqe4sb2pjn9 HnPMFb8DK5epNv9PA9kknhOBwqAbJycAHgYYDyElaWwrGNOF/sFSQtBDOxKgRQZk9bPxxqbSIhJbp Y79bdb9iCpS/98+F14OQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gTr5S-0004XB-Vn; Mon, 03 Dec 2018 16:28:46 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gTr5P-0004RM-KN for linux-arm-kernel@lists.infradead.org; Mon, 03 Dec 2018 16:28:45 +0000 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wB3GPuJq081682 for ; Mon, 3 Dec 2018 11:28:32 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2p57n41gfq-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 03 Dec 2018 11:28:32 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Dec 2018 16:28:28 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 3 Dec 2018 16:28:21 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wB3GSKaf25690160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 3 Dec 2018 16:28:20 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 99EB6A4054; Mon, 3 Dec 2018 16:28:20 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 55F64A4060; Mon, 3 Dec 2018 16:28:18 +0000 (GMT) Received: from rapoport-lnx (unknown [9.148.206.196]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 3 Dec 2018 16:28:18 +0000 (GMT) Date: Mon, 3 Dec 2018 18:28:16 +0200 From: Mike Rapoport To: Sam Ravnborg Subject: Re: [PATCH v2 3/6] sh: prefer memblock APIs returning virtual address References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-4-git-send-email-rppt@linux.ibm.com> <20181203161052.GA4244@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181203161052.GA4244@ravnborg.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 18120316-4275-0000-0000-000002EB6519 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18120316-4276-0000-0000-000037F86955 Message-Id: <20181203162816.GA26700@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-12-03_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812030154 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181203_082843_772107_31E3AA35 X-CRM114-Status: GOOD ( 29.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , linux-sh@vger.kernel.org, Benjamin Herrenschmidt , linux-mm@kvack.org, Rich Felker , Paul Mackerras , sparclinux@vger.kernel.org, Vincent Chen , Jonas Bonn , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Michael Ellerman , Russell King , Mark Salter , Arnd Bergmann , Stefan Kristiansson , openrisc@lists.librecores.org, Greentime Hu , Stafford Horne , Guan Xuetao , linux-arm-kernel@lists.infradead.org, Michal Simek , linux-kernel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 03, 2018 at 05:10:52PM +0100, Sam Ravnborg wrote: > Hi Mike. > > On Mon, Dec 03, 2018 at 05:47:12PM +0200, Mike Rapoport wrote: > > Rather than use the memblock_alloc_base that returns a physical address and > > then convert this address to the virtual one, use appropriate memblock > > function that returns a virtual address. > > > > There is a small functional change in the allocation of then NODE_DATA(). > > Instead of panicing if the local allocation failed, the non-local > > allocation attempt will be made. > > > > Signed-off-by: Mike Rapoport > > --- > > arch/sh/mm/init.c | 18 +++++------------- > > arch/sh/mm/numa.c | 5 ++--- > > 2 files changed, 7 insertions(+), 16 deletions(-) > > > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > > index c8c13c77..3576b5f 100644 > > --- a/arch/sh/mm/init.c > > +++ b/arch/sh/mm/init.c > > @@ -192,24 +192,16 @@ void __init page_table_range_init(unsigned long start, unsigned long end, > > void __init allocate_pgdat(unsigned int nid) > > { > > unsigned long start_pfn, end_pfn; > > -#ifdef CONFIG_NEED_MULTIPLE_NODES > > - unsigned long phys; > > -#endif > > > > get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); > > > > #ifdef CONFIG_NEED_MULTIPLE_NODES > > - phys = __memblock_alloc_base(sizeof(struct pglist_data), > > - SMP_CACHE_BYTES, end_pfn << PAGE_SHIFT); > > - /* Retry with all of system memory */ > > - if (!phys) > > - phys = __memblock_alloc_base(sizeof(struct pglist_data), > > - SMP_CACHE_BYTES, memblock_end_of_DRAM()); > > - if (!phys) > > + NODE_DATA(nid) = memblock_alloc_try_nid_nopanic( > > + sizeof(struct pglist_data), > > + SMP_CACHE_BYTES, MEMBLOCK_LOW_LIMIT, > > + MEMBLOCK_ALLOC_ACCESSIBLE, nid); > > + if (!NODE_DATA(nid)) > > panic("Can't allocate pgdat for node %d\n", nid); > > - > > - NODE_DATA(nid) = __va(phys); > > - memset(NODE_DATA(nid), 0, sizeof(struct pglist_data)); > The new code will always assign NODE_DATA(nid), where the old > code only assigned NODE_DATA(nid) in the good case. > I dunno if this is an issue, just noticed the difference and > wanted to point it out. If the allocation fails the NODE_DATA(nid) remains zero anyway and there is a panic() call. So I think there is no actual functional change here. > Sam > -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Date: Mon, 3 Dec 2018 18:28:16 +0200 Subject: [OpenRISC] [PATCH v2 3/6] sh: prefer memblock APIs returning virtual address In-Reply-To: <20181203161052.GA4244@ravnborg.org> References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-4-git-send-email-rppt@linux.ibm.com> <20181203161052.GA4244@ravnborg.org> Message-ID: <20181203162816.GA26700@rapoport-lnx> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Mon, Dec 03, 2018 at 05:10:52PM +0100, Sam Ravnborg wrote: > Hi Mike. > > On Mon, Dec 03, 2018 at 05:47:12PM +0200, Mike Rapoport wrote: > > Rather than use the memblock_alloc_base that returns a physical address and > > then convert this address to the virtual one, use appropriate memblock > > function that returns a virtual address. > > > > There is a small functional change in the allocation of then NODE_DATA(). > > Instead of panicing if the local allocation failed, the non-local > > allocation attempt will be made. > > > > Signed-off-by: Mike Rapoport > > --- > > arch/sh/mm/init.c | 18 +++++------------- > > arch/sh/mm/numa.c | 5 ++--- > > 2 files changed, 7 insertions(+), 16 deletions(-) > > > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > > index c8c13c77..3576b5f 100644 > > --- a/arch/sh/mm/init.c > > +++ b/arch/sh/mm/init.c > > @@ -192,24 +192,16 @@ void __init page_table_range_init(unsigned long start, unsigned long end, > > void __init allocate_pgdat(unsigned int nid) > > { > > unsigned long start_pfn, end_pfn; > > -#ifdef CONFIG_NEED_MULTIPLE_NODES > > - unsigned long phys; > > -#endif > > > > get_pfn_range_for_nid(nid, &start_pfn, &end_pfn); > > > > #ifdef CONFIG_NEED_MULTIPLE_NODES > > - phys = __memblock_alloc_base(sizeof(struct pglist_data), > > - SMP_CACHE_BYTES, end_pfn << PAGE_SHIFT); > > - /* Retry with all of system memory */ > > - if (!phys) > > - phys = __memblock_alloc_base(sizeof(struct pglist_data), > > - SMP_CACHE_BYTES, memblock_end_of_DRAM()); > > - if (!phys) > > + NODE_DATA(nid) = memblock_alloc_try_nid_nopanic( > > + sizeof(struct pglist_data), > > + SMP_CACHE_BYTES, MEMBLOCK_LOW_LIMIT, > > + MEMBLOCK_ALLOC_ACCESSIBLE, nid); > > + if (!NODE_DATA(nid)) > > panic("Can't allocate pgdat for node %d\n", nid); > > - > > - NODE_DATA(nid) = __va(phys); > > - memset(NODE_DATA(nid), 0, sizeof(struct pglist_data)); > The new code will always assign NODE_DATA(nid), where the old > code only assigned NODE_DATA(nid) in the good case. > I dunno if this is an issue, just noticed the difference and > wanted to point it out. If the allocation fails the NODE_DATA(nid) remains zero anyway and there is a panic() call. So I think there is no actual functional change here. > Sam > -- Sincerely yours, Mike.