All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gaël PORTAY" <gael.portay@collabora.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libglib2: fix configure issue without libmount
Date: Mon,  3 Dec 2018 18:51:18 -0500	[thread overview]
Message-ID: <20181203235118.7846-1-gael.portay@collabora.com> (raw)

The following configure error happens when the util-linux dependency
does not install libmount:

	(...)
	checking for LIBMOUNT... no
	configure: error: *** Could not find libmount
	make[1]: *** [package/pkg-generic.mk:222: /home/gportay/src/buildroot/output-rpi3-64-drm-kms/build/libglib2-2.56.1/.stamp_configured] Error 1
	make: *** [Makefile:84: _all] Error 2

If no enable/disable option is given through to configure, glib2 checks
for the libmount package (linux only) and fails if is not present[1].

To fix this configure issue, this path explicits the option at configure
to make sure to disable libmount if is is not installed.

[1]: https://github.com/GNOME/glib/blob/glib-2-56/configure.ac#L1856

Signed-off-by: Ga?l PORTAY <gael.portay@collabora.com>
---
 package/libglib2/libglib2.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libglib2/libglib2.mk b/package/libglib2/libglib2.mk
index 67db5ac359..16252c0ecb 100644
--- a/package/libglib2/libglib2.mk
+++ b/package/libglib2/libglib2.mk
@@ -114,6 +114,7 @@ HOST_LIBGLIB2_DEPENDENCIES = \
 
 LIBGLIB2_CONF_OPTS = \
 	--with-pcre=system \
+	$(if $(BR2_PACKAGE_UTIL_LINUX_LIBMOUNT),--enable-libmount,--disable-libmount) \
 	--disable-compile-warnings
 
 ifneq ($(BR2_ENABLE_LOCALE),y)
-- 
2.19.2

             reply	other threads:[~2018-12-03 23:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03 23:51 Gaël PORTAY [this message]
2018-12-06 20:56 ` [Buildroot] [PATCH] libglib2: fix configure issue without libmount Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181203235118.7846-1-gael.portay@collabora.com \
    --to=gael.portay@collabora.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.