From: Viresh Kumar <viresh.kumar@linaro.org>
To: Taniya Das <tdas@codeaurora.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
devicetree@vger.kernel.org, robh@kernel.org,
skannan@codeaurora.org, linux-arm-msm@vger.kernel.org,
evgreen@google.com, Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH v11 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver
Date: Tue, 4 Dec 2018 10:42:31 +0530 [thread overview]
Message-ID: <20181204051231.mm5ixli7ckpfzvd4@vireshk-i7> (raw)
In-Reply-To: <1543722903-10989-3-git-send-email-tdas@codeaurora.org>
Hi Taniya,
Sorry that I haven't been reviewing it much from last few iterations as I was
letting others get this into a better shape. Thanks for your efforts..
On 02-12-18, 09:25, Taniya Das wrote:
> +++ b/drivers/cpufreq/qcom-cpufreq-hw.c
> +struct cpufreq_qcom {
> + struct cpufreq_frequency_table *table;
> + void __iomem *perf_state_reg;
> + cpumask_t related_cpus;
> +};
> +
> +static struct cpufreq_qcom *qcom_freq_domain_map[NR_CPUS];
Now that the code is much more simplified, I am not sure if you need this
per-cpu structure at all. The only place where you are using it is in
qcom_cpufreq_hw_cpu_init() and probe(). Why not merge qcom_cpu_resources_init()
completely into qcom_cpufreq_hw_cpu_init() and get rid of this structure
entirely ?
--
viresh
next prev parent reply other threads:[~2018-12-04 5:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 3:55 [PATCH v11 0/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW Taniya Das
2018-12-02 3:55 ` [PATCH v11 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ Firmware bindings Taniya Das
2018-12-03 16:55 ` Stephen Boyd
2018-12-03 16:55 ` Stephen Boyd
2018-12-03 23:09 ` Rob Herring
2018-12-03 23:57 ` Stephen Boyd
2018-12-02 3:55 ` [PATCH v11 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver Taniya Das
2018-12-03 16:57 ` Stephen Boyd
2018-12-03 16:57 ` Stephen Boyd
2018-12-03 17:46 ` Matthias Kaehlcke
2018-12-04 5:12 ` Viresh Kumar [this message]
2018-12-04 9:27 ` Taniya Das
2018-12-04 9:29 ` Viresh Kumar
2018-12-04 22:28 ` Stephen Boyd
2018-12-04 23:05 ` Stephen Boyd
2018-12-05 3:37 ` Taniya Das
2018-12-05 6:16 ` Viresh Kumar
2018-12-05 17:00 ` Stephen Boyd
2018-12-06 4:22 ` Viresh Kumar
2018-12-11 13:35 ` Taniya Das
2018-12-12 4:47 ` Viresh Kumar
2018-12-13 7:48 ` Taniya Das
2018-12-05 8:07 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204051231.mm5ixli7ckpfzvd4@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@google.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=skannan@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.