From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v4 9/9] dmapool: debug: prevent endless loop in case of corruption Date: Tue, 4 Dec 2018 12:14:43 -0800 Message-ID: <20181204121443.1430883634a6ecf5f4a6a4a2@linux-foundation.org> References: <9e65ec2e-5e22-4f65-7b92-ca2af0c555f3@cybernetics.com> <20181113063601.GT21824@bombadil.infradead.org> <4dcb22b0-a348-841d-8175-e368f67f33c3@cybernetics.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4dcb22b0-a348-841d-8175-e368f67f33c3-vFAe+i1/wJI5UWNf+nJyDw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tony Battersby Cc: "linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Andy Shevchenko , Matthew Wilcox , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Christoph Hellwig List-Id: linux-scsi@vger.kernel.org On Tue, 4 Dec 2018 11:22:34 -0500 Tony Battersby wr= ote: > On 11/13/18 1:36 AM, Matthew Wilcox wrote: > > On Mon, Nov 12, 2018 at 10:46:35AM -0500, Tony Battersby wrote: > >> Prevent a possible endless loop with DMAPOOL_DEBUG enabled if a buggy > >> driver corrupts DMA pool memory. > >> > >> Signed-off-by: Tony Battersby > > I like it! Also, here you're using blks_per_alloc in a way which isn't > > normally in the performance path, but might be with the right config > > options. With that, I withdraw my objection to the previous patch and > > > > Acked-by: Matthew Wilcox > > > > Andrew, can you funnel these in through your tree? If you'd rather not, > > I don't mind stuffing them into a git tree and asking Linus to pull > > for 4.21. > > > No reply for 3 weeks, so adding Andrew Morton to recipient list. > = > Andrew, I have 9 dmapool patches ready for merging in 4.21.=A0 See Matthew > Wilcox's request above. > = I'll take a look, but I see that this v4 series has several review comments from Matthew which remain unresponded to. Please attend to that. Also, Andy had issues with the v2 series so it would be good to hear an update from him? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by kanga.kvack.org (Postfix) with ESMTP id 3B2A06B7080 for ; Tue, 4 Dec 2018 15:14:48 -0500 (EST) Received: by mail-pg1-f198.google.com with SMTP id k125so9684645pga.5 for ; Tue, 04 Dec 2018 12:14:48 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id z4si15488863pgl.16.2018.12.04.12.14.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Dec 2018 12:14:47 -0800 (PST) Date: Tue, 4 Dec 2018 12:14:43 -0800 From: Andrew Morton Subject: Re: [PATCH v4 9/9] dmapool: debug: prevent endless loop in case of corruption Message-Id: <20181204121443.1430883634a6ecf5f4a6a4a2@linux-foundation.org> In-Reply-To: <4dcb22b0-a348-841d-8175-e368f67f33c3@cybernetics.com> References: <9e65ec2e-5e22-4f65-7b92-ca2af0c555f3@cybernetics.com> <20181113063601.GT21824@bombadil.infradead.org> <4dcb22b0-a348-841d-8175-e368f67f33c3@cybernetics.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Tony Battersby Cc: Matthew Wilcox , Christoph Hellwig , Marek Szyprowski , iommu@lists.linux-foundation.org, linux-mm@kvack.org, "linux-scsi@vger.kernel.org" , Andy Shevchenko On Tue, 4 Dec 2018 11:22:34 -0500 Tony Battersby wr= ote: > On 11/13/18 1:36 AM, Matthew Wilcox wrote: > > On Mon, Nov 12, 2018 at 10:46:35AM -0500, Tony Battersby wrote: > >> Prevent a possible endless loop with DMAPOOL_DEBUG enabled if a buggy > >> driver corrupts DMA pool memory. > >> > >> Signed-off-by: Tony Battersby > > I like it! Also, here you're using blks_per_alloc in a way which isn't > > normally in the performance path, but might be with the right config > > options. With that, I withdraw my objection to the previous patch and > > > > Acked-by: Matthew Wilcox > > > > Andrew, can you funnel these in through your tree? If you'd rather not, > > I don't mind stuffing them into a git tree and asking Linus to pull > > for 4.21. > > > No reply for 3 weeks, so adding Andrew Morton to recipient list. >=20 > Andrew, I have 9 dmapool patches ready for merging in 4.21.=A0 See Matthew > Wilcox's request above. >=20 I'll take a look, but I see that this v4 series has several review comments from Matthew which remain unresponded to. Please attend to that. Also, Andy had issues with the v2 series so it would be good to hear an update from him?