From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A01EDC65BB0 for ; Tue, 4 Dec 2018 23:26:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65EFC2081B for ; Tue, 4 Dec 2018 23:26:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65EFC2081B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726542AbeLDX0S (ORCPT ); Tue, 4 Dec 2018 18:26:18 -0500 Received: from mga14.intel.com ([192.55.52.115]:39231 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbeLDX0R (ORCPT ); Tue, 4 Dec 2018 18:26:17 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2018 15:26:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,316,1539673200"; d="scan'208";a="107020318" Received: from jsakkine-mobl1.jf.intel.com (HELO localhost) ([10.24.8.183]) by fmsmga008.fm.intel.com with ESMTP; 04 Dec 2018 15:26:17 -0800 Date: Tue, 4 Dec 2018 15:26:16 -0800 From: Jarkko Sakkinen To: Roberto Sassu Cc: zohar@linux.ibm.com, david.safford@ge.com, monty.wiseman@ge.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com Subject: Re: [PATCH v6 2/7] tpm: add _head suffix to tcg_efi_specid_event and tcg_pcr_event2 Message-ID: <20181204232616.GB1233@linux.intel.com> References: <20181204082138.24600-1-roberto.sassu@huawei.com> <20181204082138.24600-3-roberto.sassu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181204082138.24600-3-roberto.sassu@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 04, 2018 at 09:21:33AM +0100, Roberto Sassu wrote: > TCG defines two structures, TCG_EfiSpecIDEventStruct and TCG_PCR_EVENT2, > which contain variable-sized arrays in the middle of the definition. > > Since these structures are not suitable for type casting, this patch > removes structure members after the variable-sized arrays and adds the > _head suffix to the structure name, to indicate that the renamed structures > do not contain all fields defined by TCG. > > Lastly, given that variable-sized arrays are now in the last position, and > given that the size of the arrays cannot be determined in advance, this > patch also sets the size of those arrays to zero and removes the definition > of TPM2_ACTIVE_PCR_BANKS. > > Signed-off-by: Roberto Sassu Thank you, brings up a lot of clarity. Reviewed-by: Jarkko Sakkinen /Jarkko