From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVC1a-0008AL-GI for qemu-devel@nongnu.org; Fri, 07 Dec 2018 04:02:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVC1Z-0005g7-If for qemu-devel@nongnu.org; Fri, 07 Dec 2018 04:02:18 -0500 From: Luc Michel Date: Fri, 7 Dec 2018 10:01:31 +0100 Message-Id: <20181207090135.7651-14-luc.michel@greensocs.com> In-Reply-To: <20181207090135.7651-1-luc.michel@greensocs.com> References: <20181207090135.7651-1-luc.michel@greensocs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v8 13/16] gdbstub: processes initialization on new peer connection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Luc Michel , qemu-arm@nongnu.org, Peter Maydell , saipava@xilinx.com, edgari@xilinx.com, alistair@alistair23.me, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , mark.burton@greensocs.com, Eduardo Habkost When a new connection is established, we set the first process to be attached, and the others detached. The first CPU of the first process is selected as the current CPU. Signed-off-by: Luc Michel Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- gdbstub.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8601be533b..81e7742847 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2265,13 +2265,14 @@ static bool gdb_accept(void) close(fd); return false; } =20 s =3D g_malloc0(sizeof(GDBState)); - s->c_cpu =3D first_cpu; - s->g_cpu =3D first_cpu; create_default_process(s); + s->processes[0].attached =3D true; + s->c_cpu =3D gdb_first_attached_cpu(s); + s->g_cpu =3D s->c_cpu; s->fd =3D fd; gdb_has_xml =3D false; =20 gdbserver_state =3D s; return true; @@ -2353,12 +2354,23 @@ static void gdb_chr_receive(void *opaque, const u= int8_t *buf, int size) } } =20 static void gdb_chr_event(void *opaque, int event) { + int i; + GDBState *s =3D (GDBState *) opaque; + switch (event) { case CHR_EVENT_OPENED: + /* Start with first process attached, others detached */ + for (i =3D 0; i < s->process_num; i++) { + s->processes[i].attached =3D !i; + } + + s->c_cpu =3D gdb_first_attached_cpu(s); + s->g_cpu =3D s->c_cpu; + vm_stop(RUN_STATE_PAUSED); gdb_has_xml =3D false; break; default: break; @@ -2543,19 +2555,17 @@ int gdbserver_start(const char *device) mon_chr =3D s->mon_chr; cleanup_processes(s); memset(s, 0, sizeof(GDBState)); s->mon_chr =3D mon_chr; } - s->c_cpu =3D first_cpu; - s->g_cpu =3D first_cpu; =20 create_processes(s); =20 if (chr) { qemu_chr_fe_init(&s->chr, chr, &error_abort); qemu_chr_fe_set_handlers(&s->chr, gdb_chr_can_receive, gdb_chr_r= eceive, - gdb_chr_event, NULL, NULL, NULL, true); + gdb_chr_event, NULL, s, NULL, true); } s->state =3D chr ? RS_IDLE : RS_INACTIVE; s->mon_chr =3D mon_chr; s->current_syscall_cb =3D NULL; =20 --=20 2.19.2