From: Florian Westphal <fw@strlen.de>
To: Martin Zaharinov <micron10@gmail.com>
Cc: nuclearcat@nuclearcat.com, netdev@vger.kernel.org
Subject: Re: 4.15.13 kernel panic, ip_rcv_finish, nf_xfrm_me_harder warnings continue to fill dmesg
Date: Sun, 9 Dec 2018 19:32:57 +0100 [thread overview]
Message-ID: <20181209183257.z2yn5zggcgumbvgd@breakpoint.cc> (raw)
In-Reply-To: <1C9877CE-F8CF-44EE-AD2F-70C3D9A5A899@gmail.com>
Martin Zaharinov <micron10@gmail.com> wrote:
> I use latest kernel 4.19.8 and have same problem see down
> i use pppoe with 1k+ users if i activate shaper with hfsc and imq machine crash and reboot
> after stop shaper for test mashine only send in dmesg bug error mesg.
dst_hold use there sure looks fishy. Can you try this patch?
diff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c
index e2b196054dfc..22f18444c95e 100644
--- a/net/netfilter/nf_nat_core.c
+++ b/net/netfilter/nf_nat_core.c
@@ -117,8 +117,10 @@ int nf_xfrm_me_harder(struct net *net, struct sk_buff *skb, unsigned int family)
dst = skb_dst(skb);
if (dst->xfrm)
dst = ((struct xfrm_dst *)dst)->route;
- dst_hold(dst);
-
+ if (!dst_hold_safe(dst)) {
+ pr_warn_ratelimited("dst_hold_safe failure\n");
+ return -EHOSTUNREACH;
+ }
if (sk && !net_eq(net, sock_net(sk)))
sk = NULL;
next prev parent reply other threads:[~2018-12-09 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 8:44 4.15.13 kernel panic, ip_rcv_finish, nf_xfrm_me_harder warnings continue to fill dmesg Martin Zaharinov
2018-12-09 18:32 ` Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-11 15:51 Denys Fedoryshchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181209183257.z2yn5zggcgumbvgd@breakpoint.cc \
--to=fw@strlen.de \
--cc=micron10@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nuclearcat@nuclearcat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.