From: Bjorn Helgaas <helgaas@kernel.org> To: Thinh Nguyen <thinh.nguyen@synopsys.com> Cc: Felipe Balbi <balbi@kernel.org>, linux-usb@vger.kernel.org, linux-pci@vger.kernel.org, John Youn <john.youn@synopsys.com> Subject: Re: [PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Date: Mon, 10 Dec 2018 12:49:55 -0600 [thread overview] Message-ID: <20181210184954.GA47246@google.com> (raw) In-Reply-To: <62f746c341ea00ccadda47c3cb02eb57f2e90db2.1541209477.git.thinhn@synopsys.com> On Fri, Nov 02, 2018 at 06:47:38PM -0700, Thinh Nguyen wrote: > Move Synopsys HAPS platform device IDs to pci_ids.h. > > Signed-off-by: Thinh Nguyen <thinhn@synopsys.com> 1) Run "git log --oneline include/linux/pci_ids.h" and follow the style convention for patch subject. 2) Explain in the changelog why we're moving this to pci_ids.h. Note the comment at the top of pci_ids.h. I think the move is fine because you're using the definition in two places, so just mention that in the changelog. Thanks! > --- > drivers/usb/dwc3/dwc3-haps.c | 4 ---- > include/linux/pci_ids.h | 3 +++ > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-haps.c b/drivers/usb/dwc3/dwc3-haps.c > index c9cc33881bef..02d57d98ef9b 100644 > --- a/drivers/usb/dwc3/dwc3-haps.c > +++ b/drivers/usb/dwc3/dwc3-haps.c > @@ -15,10 +15,6 @@ > #include <linux/platform_device.h> > #include <linux/property.h> > > -#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 0xabcd > -#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI 0xabce > -#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB31 0xabcf > - > /** > * struct dwc3_haps - Driver private structure > * @dwc3: child dwc3 platform_device > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index d157983b84cf..c48550aa67e3 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2354,6 +2354,9 @@ > #define PCI_DEVICE_ID_CENATEK_IDE 0x0001 > > #define PCI_VENDOR_ID_SYNOPSYS 0x16c3 > +#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 0xabcd > +#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI 0xabce > +#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB31 0xabcf > > #define PCI_VENDOR_ID_VITESSE 0x1725 > #define PCI_DEVICE_ID_VITESSE_VSC7174 0x7174 > -- > 2.11.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org> To: Thinh Nguyen <thinh.nguyen@synopsys.com> Cc: Felipe Balbi <balbi@kernel.org>, linux-usb@vger.kernel.org, linux-pci@vger.kernel.org, John Youn <john.youn@synopsys.com> Subject: [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Date: Mon, 10 Dec 2018 12:49:55 -0600 [thread overview] Message-ID: <20181210184954.GA47246@google.com> (raw) On Fri, Nov 02, 2018 at 06:47:38PM -0700, Thinh Nguyen wrote: > Move Synopsys HAPS platform device IDs to pci_ids.h. > > Signed-off-by: Thinh Nguyen <thinhn@synopsys.com> 1) Run "git log --oneline include/linux/pci_ids.h" and follow the style convention for patch subject. 2) Explain in the changelog why we're moving this to pci_ids.h. Note the comment at the top of pci_ids.h. I think the move is fine because you're using the definition in two places, so just mention that in the changelog. Thanks! > --- > drivers/usb/dwc3/dwc3-haps.c | 4 ---- > include/linux/pci_ids.h | 3 +++ > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-haps.c b/drivers/usb/dwc3/dwc3-haps.c > index c9cc33881bef..02d57d98ef9b 100644 > --- a/drivers/usb/dwc3/dwc3-haps.c > +++ b/drivers/usb/dwc3/dwc3-haps.c > @@ -15,10 +15,6 @@ > #include <linux/platform_device.h> > #include <linux/property.h> > > -#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 0xabcd > -#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI 0xabce > -#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB31 0xabcf > - > /** > * struct dwc3_haps - Driver private structure > * @dwc3: child dwc3 platform_device > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index d157983b84cf..c48550aa67e3 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2354,6 +2354,9 @@ > #define PCI_DEVICE_ID_CENATEK_IDE 0x0001 > > #define PCI_VENDOR_ID_SYNOPSYS 0x16c3 > +#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 0xabcd > +#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3_AXI 0xabce > +#define PCI_DEVICE_ID_SYNOPSYS_HAPSUSB31 0xabcf > > #define PCI_VENDOR_ID_VITESSE 0x1725 > #define PCI_DEVICE_ID_VITESSE_VSC7174 0x7174 > -- > 2.11.0 >
next prev parent reply other threads:[~2018-12-10 18:49 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-03 1:47 [PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen 2018-11-03 1:47 ` [1/2] " Thinh Nguyen 2018-11-03 1:47 ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Thinh Nguyen 2018-11-05 18:49 ` Thinh Nguyen 2018-11-05 18:49 ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen 2018-11-06 8:43 ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Felipe Balbi 2018-11-06 8:43 ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Felipe Balbi 2018-12-08 2:49 ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Thinh Nguyen 2018-12-08 2:49 ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen 2018-12-10 18:54 ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Bjorn Helgaas 2018-12-10 18:54 ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Bjorn Helgaas 2018-12-10 21:51 ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Thinh Nguyen 2018-12-10 21:51 ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen 2018-11-03 6:25 ` [PATCH 1/2] " Greg KH 2018-11-03 6:25 ` [1/2] " Greg Kroah-Hartman 2018-11-05 18:46 ` [PATCH 1/2] " Thinh Nguyen 2018-11-05 18:46 ` [1/2] " Thinh Nguyen 2018-11-05 18:56 ` [PATCH 1/2] " Greg KH 2018-11-05 18:56 ` [1/2] " Greg Kroah-Hartman 2018-12-10 18:49 ` Bjorn Helgaas [this message] 2018-12-10 18:49 ` Bjorn Helgaas 2018-12-10 21:49 ` [PATCH 1/2] " Thinh Nguyen 2018-12-10 21:49 ` [1/2] " Thinh Nguyen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181210184954.GA47246@google.com \ --to=helgaas@kernel.org \ --cc=balbi@kernel.org \ --cc=john.youn@synopsys.com \ --cc=linux-pci@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=thinh.nguyen@synopsys.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.