From: Miquel Raynal <miquel.raynal@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 12/25] mtd: ensure MTD and NOR drivers are compiled with ENV_IS_IN_FLASH
Date: Mon, 10 Dec 2018 19:02:45 +0100 [thread overview]
Message-ID: <20181210190245.50324d1b@xps13> (raw)
In-Reply-To: <20181209180747.24575-13-miquel.raynal@bootlin.com>
Hello,
Miquel Raynal <miquel.raynal@bootlin.com> wrote on Sun, 9 Dec 2018
19:07:34 +0100:
> MTD and NOR flash support must be enabled when the environment is in
> NOR.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> configs/armadillo-800eva_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configs/armadillo-800eva_defconfig b/configs/armadillo-800eva_defconfig
> index b1d923c069..72758884b4 100644
> --- a/configs/armadillo-800eva_defconfig
> +++ b/configs/armadillo-800eva_defconfig
> @@ -32,6 +32,8 @@ CONFIG_CMD_PING=y
> # CONFIG_CMD_MISC is not set
> CONFIG_ENV_IS_IN_FLASH=y
> # CONFIG_MMC is not set
> +CONFIG_MTD=y
> +CONFIG_MTD_NOR_FLASH=y
> CONFIG_SH_ETHER=y
> CONFIG_SCIF_CONSOLE=y
> CONFIG_OF_LIBFDT=y
This change triggered a build failure. This is because, despite
declaring an in-flash environment, there was absolutely no MTD driver
compiled-in. No driver named after 'flash' or 'nor' or 'mtd' was
compiled.
The fix for this issue (the only one reported by Travis for this
version of the series) is to just drop this patch. As it has absolutely
no dependency and only impacts a single defconfig, I would rather
prefer not re-send 24 identical patches in a v5 unless there are
comments that I must address.
Travis build for the same series without this patch is there:
https://travis-ci.org/miquelraynal/u-boot/builds/466033792
Thanks,
Miquèl
next prev parent reply other threads:[~2018-12-10 18:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 18:07 [U-Boot] [PATCH v4 00/25] MTD defconfigs/Kconfigs/Makefiles heavy cleanup Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 01/25] mtd: rename CONFIG_NAND -> CONFIG_MTD_RAW_NAND Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 02/25] mtd: rename CONFIG_MTD -> CONFIG_DM_MTD Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 03/25] mtd: rename CONFIG_MTD_DEVICE -> CONFIG_MTD Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 04/25] mtd: ensure MTD is compiled when there is a NOR flash Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 05/25] mtd: ensure MTD/the raw NAND core are compiled when there is a NAND flash Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 06/25] mtd: ensure MTD is compiled when there is a SPI NOR flash using MTD Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 07/25] mtd: ensure UBI is compiled when using fastmap Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 08/25] mtd: ensure MTD is compiled when UBI is used Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 09/25] mtd: ensure UBI is compiled when CMD_UBI is selected Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 10/25] mtd: ensure UBI is compiled when ENV_IS_IN_UBI " Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 11/25] mtd: ensure MTD_RAW_NAND is compiled when ENV_IS_IN_NAND " Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 12/25] mtd: ensure MTD and NOR drivers are compiled with ENV_IS_IN_FLASH Miquel Raynal
2018-12-10 18:02 ` Miquel Raynal [this message]
2018-12-10 18:10 ` Tom Rini
2018-12-11 7:49 ` Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 13/25] mtd: ensure CMD_NAND is compiled when its options are selected Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 14/25] mtd: ensure MTD is compiled when CMD_MTDPARTS is selected Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 15/25] configs: move CONFIG_MTD in defconfigs when set in arch includes Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 16/25] configs: remove raw NAND core from k2g defconfigs Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 17/25] configs: remove MTD support from bcm11130 and M54418TWR defconfigs Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 18/25] mtd: nand: add includes in NAND core to avoid warnings Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 19/25] dfu: add dependency on the raw NAND core Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 20/25] mtd: nor: NOR flashes depend on MTD Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 21/25] mtd: spi: SPI_FLASH_MTD depends " Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 22/25] cmd: mtdparts: Kconfig: join mtdparts command entry with its options Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 23/25] cmd: nand/sf: isolate legacy code Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 24/25] cmd: make MTD commands depend on MTD Miquel Raynal
2018-12-09 18:07 ` [U-Boot] [PATCH v4 25/25] mtd: Makefile: deep cleanup Miquel Raynal
2019-02-20 5:20 ` [U-Boot] [PATCH v4 00/25] MTD defconfigs/Kconfigs/Makefiles heavy cleanup Vignesh R
2019-02-20 7:08 ` Miquel Raynal
2019-03-06 9:21 ` Miquel Raynal
2019-03-17 17:27 ` Miquel Raynal
2019-03-17 19:34 ` Tom Rini
2019-03-19 5:21 ` Jagan Teki
2019-04-12 5:43 ` Jagan Teki
2019-04-12 7:22 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210190245.50324d1b@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.