From: Petr Vorel <petr.vorel@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/7] env: Read default speed and mode values from DT
Date: Mon, 10 Dec 2018 22:08:19 +0100 [thread overview]
Message-ID: <20181210210818.GB396@x230> (raw)
In-Reply-To: <1544439166-5749-7-git-send-email-patrick.delaunay@st.com>
Hi Patrick,
> In case of DT boot, don't read default speed and mode for SPI from
> CONFIG_*, instead read from DT node.
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> env/Kconfig | 4 ++--
> env/sf.c | 5 ++++-
> 2 files changed, 6 insertions(+), 3 deletions(-)
...
> +++ b/env/sf.c
> @@ -24,12 +24,15 @@
> #ifndef CONFIG_ENV_SPI_CS
> # define CONFIG_ENV_SPI_CS CONFIG_SF_DEFAULT_CS
> #endif
> +
> +#ifndef CONFIG_DM_SPI_FLASH
> #ifndef CONFIG_ENV_SPI_MAX_HZ
> # define CONFIG_ENV_SPI_MAX_HZ CONFIG_SF_DEFAULT_SPEED
> #endif
> #ifndef CONFIG_ENV_SPI_MODE
> # define CONFIG_ENV_SPI_MODE CONFIG_SF_DEFAULT_MODE
> #endif
> +#endif
Maybe indent? (code style mix indent and not)
#ifndef CONFIG_DM_SPI_FLASH
# ifndef CONFIG_ENV_SPI_MAX_HZ
# define CONFIG_ENV_SPI_MAX_HZ CONFIG_SF_DEFAULT_SPEED
# endif
# ifndef CONFIG_ENV_SPI_MODE
# define CONFIG_ENV_SPI_MODE CONFIG_SF_DEFAULT_MODE
# endif
#endif
Kind regards,
Petr
next prev parent reply other threads:[~2018-12-10 21:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 10:52 [U-Boot] [PATCH 0/7] Remove defines for SPI default speed and mode Patrick Delaunay
2018-12-10 10:52 ` [U-Boot] [PATCH 1/7] spi: update management of " Patrick Delaunay
2018-12-10 11:24 ` Simon Goldschmidt
2018-12-10 20:49 ` Petr Vorel
2018-12-10 20:57 ` Simon Goldschmidt
2018-12-12 19:58 ` Jagan Teki
2018-12-10 10:52 ` [U-Boot] [PATCH 2/7] spi: add comment for spi_flash_probe_bus_cs function Patrick Delaunay
2018-12-10 11:25 ` Simon Goldschmidt
2018-12-10 20:54 ` Petr Vorel
2018-12-10 10:52 ` [U-Boot] [PATCH 3/7] da850evm: sf: Read default speed and mode values from DT Patrick Delaunay
2018-12-10 20:57 ` Petr Vorel
2018-12-12 20:02 ` Jagan Teki
2018-12-13 14:54 ` Patrick DELAUNAY
2018-12-10 10:52 ` [U-Boot] [PATCH 4/7] dfu: " Patrick Delaunay
2018-12-10 11:22 ` Lukasz Majewski
2018-12-10 21:00 ` Petr Vorel
2018-12-10 10:52 ` [U-Boot] [PATCH 5/7] mips: mt76xx: gardena-smart-gateway: " Patrick Delaunay
2018-12-10 11:47 ` Stefan Roese
2018-12-10 21:01 ` Petr Vorel
2018-12-10 10:52 ` [U-Boot] [PATCH 6/7] env: " Patrick Delaunay
2018-12-10 11:23 ` Lukasz Majewski
2018-12-10 11:27 ` Simon Goldschmidt
2018-12-10 21:08 ` Petr Vorel [this message]
2018-12-12 20:07 ` Jagan Teki
2018-12-10 10:52 ` [U-Boot] [PATCH 7/7] spi: remove define for SPI default SPEED and MODE Patrick Delaunay
2018-12-10 11:26 ` Simon Goldschmidt
2018-12-10 21:10 ` Petr Vorel
2018-12-10 15:42 ` [U-Boot] [PATCH 0/7] Remove defines for SPI default speed and mode Adam Ford
2018-12-10 19:20 ` Simon Goldschmidt
2018-12-10 20:17 ` Adam Ford
2018-12-10 21:08 ` Simon Goldschmidt
2018-12-12 7:51 ` Petr Vorel
2018-12-12 9:54 ` Simon Goldschmidt
2018-12-13 14:46 ` Patrick DELAUNAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210210818.GB396@x230 \
--to=petr.vorel@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.