From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5F3DA2119926B for ; Tue, 11 Dec 2018 06:41:46 -0800 (PST) Date: Tue, 11 Dec 2018 09:41:40 -0500 From: Steven Rostedt Subject: Re: [RFC v3 11/19] kunit: add Python libraries for handing KUnit config and kernel Message-ID: <20181211094140.2a928fe7@gandalf.local.home> In-Reply-To: <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-12-brendanhiggins@google.com> <841cf4ae-501b-05ae-5863-a51010709b67@ideasonboard.com> <20181204204701.GT28501@garbanzo.do-not-panic.com> <20181206153718.GD24603@bombadil.infradead.org> <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Petr Mladek Cc: brakmo@fb.com, Knut Omang , jeffm@suse.com, Brendan Higgins , dri-devel@lists.freedesktop.org, Sasha Levin , Linux Trace Devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , Frank Rowand , linux-nvdimm@lists.01.org, mpe@ellerman.id.au, Eric Sandeen , Kieran Bingham , Matthew Wilcox , Felix Guo , Joel Stanley , Kent Overstreet , jdike@addtoit.com, Tim.Bird@sony.com, linux-um@lists.infradead.org, Julia Lawall , kunit-dev@googlegroups.com, richard@nod.at, Greg KH , Linux Kernel Mailing List , Luis Chamberlain , Eryu Guan , Daniel Vetter , Kees Cook , joe@perches.com, linux-fsdevel@vger.kernel.org, khilman@baylibre.com List-ID: On Tue, 11 Dec 2018 15:09:26 +0100 Petr Mladek wrote: > > We have liburcu already, which is good. The main sticking points are: > > > > - printk has started adding a lot of %pX enhancements which printf > > obviously doesn't know about. > > I wonder how big problem it is and if it is worth using another > approach. No, please do not change the %pX approach. > > An alternative would be to replace them with helper functions > the would produce the same string. The meaning would be easier > to understand. But concatenating with the surrounding text > would be less elegant. People might start using pr_cont() > that is problematic (mixed lines). > > Also the %pX formats are mostly used to print context of some > structures. Even the helper functions would need some maintenance > to keep them compatible. > > BTW: The printk() feature has been introduced 10 years ago by > the commit 4d8a743cdd2690c0bc8 ("vsprintf: add infrastructure > support for extended '%p' specifiers"). trace-cmd and perf know about most of the %pX data and how to read it. Perhaps we can extend the libtraceevent library to export a generic way to read data from printk() output for other tools to use. -- Steve _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA991C07E85 for ; Tue, 11 Dec 2018 14:41:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC6F420849 for ; Tue, 11 Dec 2018 14:41:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC6F420849 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726714AbeLKOlr (ORCPT ); Tue, 11 Dec 2018 09:41:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:49184 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726231AbeLKOlq (ORCPT ); Tue, 11 Dec 2018 09:41:46 -0500 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4FCA2054F; Tue, 11 Dec 2018 14:41:42 +0000 (UTC) Date: Tue, 11 Dec 2018 09:41:40 -0500 From: Steven Rostedt To: Petr Mladek Cc: Matthew Wilcox , Kieran Bingham , Luis Chamberlain , Brendan Higgins , Kent Overstreet , Eryu Guan , Eric Sandeen , jeffm@suse.com, Sasha Levin , Greg KH , Kees Cook , shuah@kernel.org, Joel Stanley , mpe@ellerman.id.au, joe@perches.com, brakmo@fb.com, Tim.Bird@sony.com, khilman@baylibre.com, Julia Lawall , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Linux Kernel Mailing List , jdike@addtoit.com, richard@nod.at, linux-um@lists.infradead.org, Daniel Vetter , dri-devel@lists.freedesktop.org, Rob Herring , dan.j.williams@intel.com, linux-nvdimm@lists.01.org, Frank Rowand , Knut Omang , Felix Guo , linux-fsdevel@vger.kernel.org, Linux Trace Devel Subject: Re: [RFC v3 11/19] kunit: add Python libraries for handing KUnit config and kernel Message-ID: <20181211094140.2a928fe7@gandalf.local.home> In-Reply-To: <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-12-brendanhiggins@google.com> <841cf4ae-501b-05ae-5863-a51010709b67@ideasonboard.com> <20181204204701.GT28501@garbanzo.do-not-panic.com> <20181206153718.GD24603@bombadil.infradead.org> <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Dec 2018 15:09:26 +0100 Petr Mladek wrote: > > We have liburcu already, which is good. The main sticking points are: > > > > - printk has started adding a lot of %pX enhancements which printf > > obviously doesn't know about. > > I wonder how big problem it is and if it is worth using another > approach. No, please do not change the %pX approach. > > An alternative would be to replace them with helper functions > the would produce the same string. The meaning would be easier > to understand. But concatenating with the surrounding text > would be less elegant. People might start using pr_cont() > that is problematic (mixed lines). > > Also the %pX formats are mostly used to print context of some > structures. Even the helper functions would need some maintenance > to keep them compatible. > > BTW: The printk() feature has been introduced 10 years ago by > the commit 4d8a743cdd2690c0bc8 ("vsprintf: add infrastructure > support for extended '%p' specifiers"). trace-cmd and perf know about most of the %pX data and how to read it. Perhaps we can extend the libtraceevent library to export a generic way to read data from printk() output for other tools to use. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 From: rostedt at goodmis.org (Steven Rostedt) Date: Tue, 11 Dec 2018 09:41:40 -0500 Subject: [RFC v3 11/19] kunit: add Python libraries for handing KUnit config and kernel In-Reply-To: <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-12-brendanhiggins@google.com> <841cf4ae-501b-05ae-5863-a51010709b67@ideasonboard.com> <20181204204701.GT28501@garbanzo.do-not-panic.com> <20181206153718.GD24603@bombadil.infradead.org> <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> Message-ID: <20181211094140.2a928fe7@gandalf.local.home> On Tue, 11 Dec 2018 15:09:26 +0100 Petr Mladek wrote: > > We have liburcu already, which is good. The main sticking points are: > > > > - printk has started adding a lot of %pX enhancements which printf > > obviously doesn't know about. > > I wonder how big problem it is and if it is worth using another > approach. No, please do not change the %pX approach. > > An alternative would be to replace them with helper functions > the would produce the same string. The meaning would be easier > to understand. But concatenating with the surrounding text > would be less elegant. People might start using pr_cont() > that is problematic (mixed lines). > > Also the %pX formats are mostly used to print context of some > structures. Even the helper functions would need some maintenance > to keep them compatible. > > BTW: The printk() feature has been introduced 10 years ago by > the commit 4d8a743cdd2690c0bc8 ("vsprintf: add infrastructure > support for extended '%p' specifiers"). trace-cmd and perf know about most of the %pX data and how to read it. Perhaps we can extend the libtraceevent library to export a generic way to read data from printk() output for other tools to use. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 From: rostedt@goodmis.org (Steven Rostedt) Date: Tue, 11 Dec 2018 09:41:40 -0500 Subject: [RFC v3 11/19] kunit: add Python libraries for handing KUnit config and kernel In-Reply-To: <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-12-brendanhiggins@google.com> <841cf4ae-501b-05ae-5863-a51010709b67@ideasonboard.com> <20181204204701.GT28501@garbanzo.do-not-panic.com> <20181206153718.GD24603@bombadil.infradead.org> <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> Message-ID: <20181211094140.2a928fe7@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" Message-ID: <20181211144140.CWWP__DARAGa-GR_zKAfvmgbd9zkyFirVPrufPUKhes@z> On Tue, 11 Dec 2018 15:09:26 +0100 Petr Mladek wrote: > > We have liburcu already, which is good. The main sticking points are: > > > > - printk has started adding a lot of %pX enhancements which printf > > obviously doesn't know about. > > I wonder how big problem it is and if it is worth using another > approach. No, please do not change the %pX approach. > > An alternative would be to replace them with helper functions > the would produce the same string. The meaning would be easier > to understand. But concatenating with the surrounding text > would be less elegant. People might start using pr_cont() > that is problematic (mixed lines). > > Also the %pX formats are mostly used to print context of some > structures. Even the helper functions would need some maintenance > to keep them compatible. > > BTW: The printk() feature has been introduced 10 years ago by > the commit 4d8a743cdd2690c0bc8 ("vsprintf: add infrastructure > support for extended '%p' specifiers"). trace-cmd and perf know about most of the %pX data and how to read it. Perhaps we can extend the libtraceevent library to export a generic way to read data from printk() output for other tools to use. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [RFC v3 11/19] kunit: add Python libraries for handing KUnit config and kernel Date: Tue, 11 Dec 2018 09:41:40 -0500 Message-ID: <20181211094140.2a928fe7@gandalf.local.home> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-12-brendanhiggins@google.com> <841cf4ae-501b-05ae-5863-a51010709b67@ideasonboard.com> <20181204204701.GT28501@garbanzo.do-not-panic.com> <20181206153718.GD24603@bombadil.infradead.org> <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181211140926.7wzd5jh6klcfsfgz-KsEp0d+Q8qECVLCxKZUutA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Petr Mladek Cc: brakmo-b10kYP2dOMg@public.gmane.org, Knut Omang , jeffm-IBi9RG/b67k@public.gmane.org, Brendan Higgins , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Sasha Levin , Linux Trace Devel , linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Rob Herring , Frank Rowand , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org, Eric Sandeen , Kieran Bingham , Matthew Wilcox , Felix Guo , Joel Stanley , Kent Overstreet , jdike-OPE4K8JWMJJBDgjK7y7TUQ@public.gmane.org, Tim.Bird-7U/KSKJipcs@public.gmane.org, linux-um-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Julia Lawall , kunit-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, richard-/L3Ra7n9ekc@public.gmane.org, Greg KH , Linux Kernel Mailing List List-Id: dri-devel@lists.freedesktop.org On Tue, 11 Dec 2018 15:09:26 +0100 Petr Mladek wrote: > > We have liburcu already, which is good. The main sticking points are: > > > > - printk has started adding a lot of %pX enhancements which printf > > obviously doesn't know about. > > I wonder how big problem it is and if it is worth using another > approach. No, please do not change the %pX approach. > > An alternative would be to replace them with helper functions > the would produce the same string. The meaning would be easier > to understand. But concatenating with the surrounding text > would be less elegant. People might start using pr_cont() > that is problematic (mixed lines). > > Also the %pX formats are mostly used to print context of some > structures. Even the helper functions would need some maintenance > to keep them compatible. > > BTW: The printk() feature has been introduced 10 years ago by > the commit 4d8a743cdd2690c0bc8 ("vsprintf: add infrastructure > support for extended '%p' specifiers"). trace-cmd and perf know about most of the %pX data and how to read it. Perhaps we can extend the libtraceevent library to export a generic way to read data from printk() output for other tools to use. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gWjET-0002Va-3z for linux-um@lists.infradead.org; Tue, 11 Dec 2018 14:41:59 +0000 Date: Tue, 11 Dec 2018 09:41:40 -0500 From: Steven Rostedt Subject: Re: [RFC v3 11/19] kunit: add Python libraries for handing KUnit config and kernel Message-ID: <20181211094140.2a928fe7@gandalf.local.home> In-Reply-To: <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-12-brendanhiggins@google.com> <841cf4ae-501b-05ae-5863-a51010709b67@ideasonboard.com> <20181204204701.GT28501@garbanzo.do-not-panic.com> <20181206153718.GD24603@bombadil.infradead.org> <20181211140926.7wzd5jh6klcfsfgz@pathway.suse.cz> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Petr Mladek Cc: brakmo@fb.com, Knut Omang , jeffm@suse.com, Brendan Higgins , dri-devel@lists.freedesktop.org, Sasha Levin , Linux Trace Devel , linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , Frank Rowand , linux-nvdimm@lists.01.org, mpe@ellerman.id.au, Eric Sandeen , Kieran Bingham , Matthew Wilcox , Felix Guo , Joel Stanley , Kent Overstreet , jdike@addtoit.com, Tim.Bird@sony.com, linux-um@lists.infradead.org, Julia Lawall , dan.j.williams@intel.com, kunit-dev@googlegroups.com, richard@nod.at, Greg KH , Linux Kernel Mailing List , Luis Chamberlain , Eryu Guan , Daniel Vetter , Kees Cook , joe@perches.com, linux-fsdevel@vger.kernel.org, khilman@baylibre.com On Tue, 11 Dec 2018 15:09:26 +0100 Petr Mladek wrote: > > We have liburcu already, which is good. The main sticking points are: > > > > - printk has started adding a lot of %pX enhancements which printf > > obviously doesn't know about. > > I wonder how big problem it is and if it is worth using another > approach. No, please do not change the %pX approach. > > An alternative would be to replace them with helper functions > the would produce the same string. The meaning would be easier > to understand. But concatenating with the surrounding text > would be less elegant. People might start using pr_cont() > that is problematic (mixed lines). > > Also the %pX formats are mostly used to print context of some > structures. Even the helper functions would need some maintenance > to keep them compatible. > > BTW: The printk() feature has been introduced 10 years ago by > the commit 4d8a743cdd2690c0bc8 ("vsprintf: add infrastructure > support for extended '%p' specifiers"). trace-cmd and perf know about most of the %pX data and how to read it. Perhaps we can extend the libtraceevent library to export a generic way to read data from printk() output for other tools to use. -- Steve _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um