All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Rob Herring <robh@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v6 0/3] device property: Add fwnode_get_name() helper
Date: Tue, 11 Dec 2018 15:59:25 +0200	[thread overview]
Message-ID: <20181211135925.GD10650@smile.fi.intel.com> (raw)
In-Reply-To: <20181211131451.52832-1-heikki.krogerus@linux.intel.com>

On Tue, Dec 11, 2018 at 04:14:48PM +0300, Heikki Krogerus wrote:
> Hi,
> 
> Andy, I dropped you Reviewed-by tag because of the last change to this
> series, so if you could check these again I would much appreciate.

They all looks fine,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> 
> Changes since v5:
> - No longer reading "name" device property as fallback.
> 
> Changes since v4:
> - No changes. There was an extra patch in v3. This was just a resend
>   of v3 without that extra patch.
> 
> Changes since v3:
> - I'm now returning -EOVERFLOW if the buffer is not big enough as
>   proposed by Andy.
> 
> This is the cover letter from v3:
> 
> This is the third version of my proposal for this helper. The
> second version can be checked here:
> https://lkml.org/lkml/2018/11/8/1005
> 
> I'm now passing the length as proposed by both Rob and Andy. I'm also
> leaving the .get_named_child_node fwnode op untouched.
> 
> --
> heikki
> 
> 
> Heikki Krogerus (3):
>   device property: Introduce fwnode_get_name()
>   ACPI: property: Add acpi_fwnode_name()
>   of/property: Add of_fwnode_name()
> 
>  drivers/acpi/property.c  | 28 ++++++++++++++++++++++++++++
>  drivers/base/property.c  | 17 +++++++++++++++++
>  drivers/of/property.c    | 13 +++++++++++++
>  include/linux/fwnode.h   |  3 +++
>  include/linux/property.h |  2 ++
>  5 files changed, 63 insertions(+)
> 
> -- 
> 2.19.2
> 

-- 
With Best Regards,
Andy Shevchenko

      parent reply	other threads:[~2018-12-11 13:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 13:14 [PATCH v6 0/3] device property: Add fwnode_get_name() helper Heikki Krogerus
2018-12-11 13:14 ` [PATCH v6 1/3] device property: Introduce fwnode_get_name() Heikki Krogerus
2018-12-11 13:14 ` [PATCH v6 2/3] ACPI: property: Add acpi_fwnode_name() Heikki Krogerus
2018-12-11 13:14 ` [PATCH v6 3/3] of/property: Add of_fwnode_name() Heikki Krogerus
2018-12-14  9:36   ` Rafael J. Wysocki
2018-12-14 17:46     ` Rob Herring
2018-12-17 12:15       ` Heikki Krogerus
2018-12-11 13:59 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181211135925.GD10650@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.