From: hch@lst.de (hch@lst.de)
Subject: [PATCH 10/12] nvmet: add error log support for admin-cmd
Date: Tue, 11 Dec 2018 15:15:47 +0100 [thread overview]
Message-ID: <20181211141547.GA8591@lst.de> (raw)
In-Reply-To: <BYAPR04MB4502206C5362955EF2F2014686A50@BYAPR04MB4502.namprd04.prod.outlook.com>
On Mon, Dec 10, 2018@10:55:08PM +0000, Chaitanya Kulkarni wrote:
> I'm wandering how we can guarantee that we don't forget to set
> req->error_loc for all future errors...
>
> Anyways..
>
> [CK] One way to do that is to have a default centralized mapping from the error codes,
> not sure if that is worth an effort though, will skip this for now.
Well, the M bit and the error log page are optional features.
Maybe we should only set the M bit and generate a log page if error_loc
is set? Although for that we'd need to initialize it to -1 as 0
is a valid error location.
We could then also add a debug option to print a warning for errors
without error_loc if we care enough.
next prev parent reply other threads:[~2018-12-11 14:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 5:49 [PATCH 00/12] nvmet: add error log page support Chaitanya Kulkarni
2018-12-10 5:50 ` [PATCH 01/12] nvme: remove nvme_common command cdw10 array Chaitanya Kulkarni
2018-12-10 20:09 ` Sagi Grimberg
2018-12-10 5:50 ` [PATCH 02/12] nvme: add error log page slot definition Chaitanya Kulkarni
2018-12-10 20:10 ` Sagi Grimberg
2018-12-10 5:50 ` [PATCH 03/12] nvmet: add error-log definitions Chaitanya Kulkarni
2018-12-10 20:12 ` Sagi Grimberg
2018-12-10 22:47 ` Chaitanya Kulkarni
2018-12-10 5:50 ` [PATCH 04/12] nvmet: add interface to update error-log page Chaitanya Kulkarni
2018-12-10 20:18 ` Sagi Grimberg
2018-12-10 22:48 ` Chaitanya Kulkarni
2018-12-10 5:50 ` [PATCH 05/12] nvmet: add error log support in the core Chaitanya Kulkarni
2018-12-10 20:22 ` Sagi Grimberg
2018-12-10 5:50 ` [PATCH 06/12] nvmet: add error log support for bdev backend Chaitanya Kulkarni
2018-12-10 20:31 ` Sagi Grimberg
2018-12-10 22:52 ` Chaitanya Kulkarni
2018-12-10 5:50 ` [PATCH 07/12] nvmet: add error log support for file backend Chaitanya Kulkarni
2018-12-10 20:32 ` Sagi Grimberg
2018-12-10 22:53 ` Chaitanya Kulkarni
2018-12-10 5:50 ` [PATCH 08/12] nvmet: add error log support for fabrics-cmd Chaitanya Kulkarni
2018-12-10 20:36 ` Sagi Grimberg
2018-12-10 5:50 ` [PATCH 09/12] nvmet: add error log support for rdma backend Chaitanya Kulkarni
2018-12-10 20:37 ` Sagi Grimberg
2018-12-10 5:50 ` [PATCH 10/12] nvmet: add error log support for admin-cmd Chaitanya Kulkarni
2018-12-10 20:40 ` Sagi Grimberg
2018-12-10 5:50 ` [PATCH 11/12] nvmet: add error log page cmd handler Chaitanya Kulkarni
2018-12-10 5:50 ` [PATCH 12/12] nvmet: update smart log with num err log entries Chaitanya Kulkarni
[not found] ` <BYAPR04MB4502206C5362955EF2F2014686A50@BYAPR04MB4502.namprd04.prod.outlook.com>
2018-12-11 14:15 ` hch [this message]
2018-12-11 23:59 ` [PATCH 10/12] nvmet: add error log support for admin-cmd Sagi Grimberg
2018-12-12 0:38 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211141547.GA8591@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.