From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?J=F6rgen?= Storvist Subject: Re: [PATCH v2] qmi_wwan: Added support for Fibocom NL668 series Date: Tue, 11 Dec 2018 14:49:14 +0100 Message-ID: <20181211144914.00004760@gmail.com> References: <20181209235726.00006bcc@gmail.com> <87zhtdsd3w.fsf@miraculix.mork.no> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org To: =?ISO-8859-1?Q?Bj=F8rn?= Mork Return-path: Received: from mail-lf1-f67.google.com ([209.85.167.67]:44519 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726286AbeLKNtT (ORCPT ); Tue, 11 Dec 2018 08:49:19 -0500 Received: by mail-lf1-f67.google.com with SMTP id z13so10795936lfe.11 for ; Tue, 11 Dec 2018 05:49:18 -0800 (PST) In-Reply-To: <87zhtdsd3w.fsf@miraculix.mork.no> Sender: netdev-owner@vger.kernel.org List-ID: Added support for Fibocom NL668 series QMI WWAN interface in default USB mo= de: AT+GTUSBMODE=3D17.=20 Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets. Signed-off-by: J=F6rgen Storvist =20 --- Changes: Changed list order to correpond to USB VID/PID values.=20 drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 72a55b6..dada68f 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -1117,6 +1117,7 @@ static const struct usb_device_id products[] =3D { {QMI_FIXED_INTF(0x1435, 0xd181, 4)}, /* Wistron NeWeb D18Q1 */ {QMI_FIXED_INTF(0x1435, 0xd181, 5)}, /* Wistron NeWeb D18Q1 */ {QMI_FIXED_INTF(0x1435, 0xd191, 4)}, /* Wistron NeWeb D19Q1 */ + {QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)}, /* Fibocom NL668 series */ {QMI_FIXED_INTF(0x16d8, 0x6003, 0)}, /* CMOTech 6003 */ {QMI_FIXED_INTF(0x16d8, 0x6007, 0)}, /* CMOTech CHE-628S */ {QMI_FIXED_INTF(0x16d8, 0x6008, 0)}, /* CMOTech CMU-301 */ Thanks for the feedback Bj=F6rn!=20 Should be correct now as above if I understood you correctly. //J=F6rgen Den Mon, 10 Dec 2018 14:52:35 +0100 skrev Re: [PATCH] qmi_wwan: Added support for Fibocom NL668 series: > J=F6rgen Storvist writes: >=20 > > Added support for Fibocom NL668 series QMI WWAN interface in default US= B mode: AT+GTUSBMODE=3D17.=20 > > Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets. > > > > Signed-off-by: J=F6rgen Storvist > > > > drivers/net/usb/qmi_wwan.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > > index 72a55b6..820081e 100644 > > --- a/drivers/net/usb/qmi_wwan.c > > +++ b/drivers/net/usb/qmi_wwan.c > > @@ -1263,6 +1263,7 @@ static const struct usb_device_id products[] =3D { > > {QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */ > > {QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)}, /* Quectel EG91 */ > > {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */ > > + {QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)}, /* Fibocom NL668 series */ > > =20 > > /* 4. Gobi 1000 devices */ > > {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */ =20 >=20 > Looks good, but could you please try to add it in a semi-numeric order? > Yes, I know it's far from perfect from before. But I'm hoping to avoid > it growing worse ;-) >=20 >=20 > Bj=F8rn