From: Jan Kara <jack@suse.cz> To: linux-mm@kvack.org Cc: mhocko@suse.cz, mgorman@suse.de, Jan Kara <jack@suse.cz> Subject: [PATCH 5/6] blkdev: Avoid migration stalls for blkdev pages Date: Tue, 11 Dec 2018 18:21:42 +0100 [thread overview] Message-ID: <20181211172143.7358-6-jack@suse.cz> (raw) In-Reply-To: <20181211172143.7358-1-jack@suse.cz> Currently, block device pages don't provide a ->migratepage callback and thus fallback_migrate_page() is used for them. This handler cannot deal with dirty pages in async mode and also with the case a buffer head is in the LRU buffer head cache (as it has elevated b_count). Thus such page can block memory offlining. Fix the problem by using buffer_migrate_page_norefs() for migrating block device pages. That function takes care of dropping bh LRU in case migration would fail due to elevated buffer refcount to avoid stalls and can also migrate dirty pages without writing them. Signed-off-by: Jan Kara <jack@suse.cz> --- fs/block_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/block_dev.c b/fs/block_dev.c index a80b4f0ee7c4..de2135178e62 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -1966,6 +1966,7 @@ static const struct address_space_operations def_blk_aops = { .writepages = blkdev_writepages, .releasepage = blkdev_releasepage, .direct_IO = blkdev_direct_IO, + .migratepage = buffer_migrate_page_norefs, .is_dirty_writeback = buffer_check_dirty_writeback, }; -- 2.16.4
next prev parent reply other threads:[~2018-12-11 17:21 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-11 17:21 mm: migrate: Fix page " Jan Kara 2018-12-11 17:21 ` [PATCH 1/6] mm: migration: Factor out code to compute expected number of page references Jan Kara 2018-12-13 13:05 ` Mel Gorman 2018-12-14 15:10 ` Mel Gorman 2018-12-14 15:53 ` Jan Kara 2018-12-14 16:24 ` Mel Gorman 2018-12-17 13:11 ` Jan Kara 2018-12-11 17:21 ` [PATCH 2/6] mm: migrate: Lock buffers before migrate_page_move_mapping() Jan Kara 2018-12-13 14:19 ` Mel Gorman 2018-12-11 17:21 ` [PATCH 3/6] mm: migrate: Move migrate_page_lock_buffers() Jan Kara 2018-12-13 14:57 ` Mel Gorman 2018-12-11 17:21 ` [PATCH 4/6] mm: migrate: Provide buffer_migrate_page_norefs() Jan Kara 2018-12-13 15:34 ` Mel Gorman 2018-12-14 4:53 ` Andrew Morton 2018-12-14 9:26 ` Jan Kara 2018-12-11 17:21 ` Jan Kara [this message] 2018-12-13 15:35 ` [PATCH 5/6] blkdev: Avoid migration stalls for blkdev pages Mel Gorman 2018-12-11 17:21 ` [PATCH 6/6] mm: migrate: Drop unused argument of migrate_page_move_mapping() Jan Kara 2018-12-13 15:35 ` Mel Gorman 2018-12-13 16:17 ` Jan Kara 2018-12-17 13:17 ` Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181211172143.7358-6-jack@suse.cz \ --to=jack@suse.cz \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.cz \ --subject='Re: [PATCH 5/6] blkdev: Avoid migration stalls for blkdev pages' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.