From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C85FC5CFFE for ; Tue, 11 Dec 2018 19:32:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F16A820870 for ; Tue, 11 Dec 2018 19:32:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F16A820870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-block-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726365AbeLKTcq (ORCPT ); Tue, 11 Dec 2018 14:32:46 -0500 Received: from mga14.intel.com ([192.55.52.115]:64622 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbeLKTcq (ORCPT ); Tue, 11 Dec 2018 14:32:46 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2018 11:32:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,343,1539673200"; d="scan'208";a="125001872" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by fmsmga002.fm.intel.com with ESMTP; 11 Dec 2018 11:32:45 -0800 Date: Tue, 11 Dec 2018 12:30:15 -0700 From: Keith Busch To: Sagi Grimberg Cc: "linux-nvme@lists.infradead.org" , Christoph Hellwig , "linux-block@vger.kernel.org" , Jens Axboe Subject: Re: [PATCH nvme-cli 6/5] fabrics: pass in nr_write_queues Message-ID: <20181211193015.GC8101@localhost.localdomain> References: <20181211104936.25333-1-sagi@grimberg.me> <20181211104936.25333-7-sagi@grimberg.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181211104936.25333-7-sagi@grimberg.me> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Dec 11, 2018 at 02:49:36AM -0800, Sagi Grimberg wrote: > if (cfg.host_traddr) { > len = sprintf(p, ",host_traddr=%s", cfg.host_traddr); > if (len < 0) > @@ -1009,6 +1019,7 @@ int connect(const char *desc, int argc, char **argv) > {"hostnqn", 'q', "LIST", CFG_STRING, &cfg.hostnqn, required_argument, "user-defined hostnqn" }, > {"hostid", 'I', "LIST", CFG_STRING, &cfg.hostid, required_argument, "user-defined hostid (if default not used)"}, > {"nr-io-queues", 'i', "LIST", CFG_INT, &cfg.nr_io_queues, required_argument, "number of io queues to use (default is core count)" }, > + {"nr_write_queues", 'W', "LIST", CFG_INT, &cfg.nr_write_queues, required_argument, "number of write queues to use (default 0)" }, I realize the kernel's nvme-admin uses "_", but everything else in the shell utility here uses "-", so just want to use that for consistency. And the documentation needs to include this as well. Otherwise this is great. From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@intel.com (Keith Busch) Date: Tue, 11 Dec 2018 12:30:15 -0700 Subject: [PATCH nvme-cli 6/5] fabrics: pass in nr_write_queues In-Reply-To: <20181211104936.25333-7-sagi@grimberg.me> References: <20181211104936.25333-1-sagi@grimberg.me> <20181211104936.25333-7-sagi@grimberg.me> Message-ID: <20181211193015.GC8101@localhost.localdomain> On Tue, Dec 11, 2018@02:49:36AM -0800, Sagi Grimberg wrote: > if (cfg.host_traddr) { > len = sprintf(p, ",host_traddr=%s", cfg.host_traddr); > if (len < 0) > @@ -1009,6 +1019,7 @@ int connect(const char *desc, int argc, char **argv) > {"hostnqn", 'q', "LIST", CFG_STRING, &cfg.hostnqn, required_argument, "user-defined hostnqn" }, > {"hostid", 'I', "LIST", CFG_STRING, &cfg.hostid, required_argument, "user-defined hostid (if default not used)"}, > {"nr-io-queues", 'i', "LIST", CFG_INT, &cfg.nr_io_queues, required_argument, "number of io queues to use (default is core count)" }, > + {"nr_write_queues", 'W', "LIST", CFG_INT, &cfg.nr_write_queues, required_argument, "number of write queues to use (default 0)" }, I realize the kernel's nvme-admin uses "_", but everything else in the shell utility here uses "-", so just want to use that for consistency. And the documentation needs to include this as well. Otherwise this is great.