From: Gerd Hoffmann <kraxel@redhat.com>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-devel@nongnu.org, "Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/4] hostmem-memfd: disable for systems wihtout sealing support
Date: Wed, 12 Dec 2018 07:49:36 +0100 [thread overview]
Message-ID: <20181212064936.ubnv3yif34e7ga5j@sirius.home.kraxel.org> (raw)
In-Reply-To: <52c43506-ef39-6d08-7db4-ad3c0f96dd1f@samsung.com>
On Tue, Dec 11, 2018 at 02:09:11PM +0300, Ilya Maximets wrote:
> On 11.12.2018 13:53, Daniel P. Berrangé wrote:
> >>
> >> Let's restrict memfd backend to systems with sealing support.
> >
> > I don't think we need todo that - sealing is optional in the QEMU code,
> > we simply have it set to the wrong default when sealing is not available.
>
> That was literally what I've fixed in v1:
> https://lists.nongnu.org/archive/html/qemu-devel/2018-11/msg05483.html
>
> but 2 people suggested me to disable memfd entirely for this case.
> Do you think I need to get patch from v1 back ?
>
> Gerd, Marc-André, what do you think?
I still think it makes sense to require sealing support. Sealing is
very useful, and there are only a few kernel versions with memfd but
without sealing. So finding such kernels in the wild will become more
rare over time. I wouldn't worry too much about them.
cheers,
Gerd
next prev parent reply other threads:[~2018-12-12 6:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181127135037eucas1p18867a9ae8b1f2731ad4ce8d79fddae33@eucas1p1.samsung.com>
2018-11-27 13:50 ` [Qemu-devel] [PATCH v2 0/4] memfd fixes Ilya Maximets
[not found] ` <CGME20181127135045eucas1p1e259cacbab5e715f7845b9beee22f882@eucas1p1.samsung.com>
2018-11-27 13:50 ` [Qemu-devel] [PATCH v2 1/4] hostmem-memfd: disable for systems wihtout sealing support Ilya Maximets
2018-11-27 13:56 ` Marc-André Lureau
2018-12-10 16:18 ` Igor Mammedov
2018-12-11 10:29 ` Ilya Maximets
2018-12-11 15:48 ` Igor Mammedov
2019-01-05 2:43 ` Eduardo Habkost
2019-01-16 10:57 ` Ilya Maximets
2018-12-11 10:53 ` Daniel P. Berrangé
2018-12-11 11:09 ` Ilya Maximets
2018-12-12 6:49 ` Gerd Hoffmann [this message]
2019-01-16 15:30 ` Eduardo Habkost
2019-01-16 15:46 ` Ilya Maximets
2019-01-16 15:48 ` Daniel P. Berrangé
2019-01-16 15:54 ` Ilya Maximets
2019-01-16 15:56 ` Daniel P. Berrangé
2019-01-16 16:10 ` Eduardo Habkost
[not found] ` <CGME20181127135052eucas1p2cec316cce9b9218e4ab476315fd4596b@eucas1p2.samsung.com>
2018-11-27 13:50 ` [Qemu-devel] [PATCH v2 2/4] memfd: always check for MFD_CLOEXEC Ilya Maximets
[not found] ` <CGME20181127135059eucas1p2371079ab1d368d8d444d6a183719cfc7@eucas1p2.samsung.com>
2018-11-27 13:50 ` [Qemu-devel] [PATCH v2 3/4] memfd: set up correct errno if not supported Ilya Maximets
[not found] ` <CGME20181127135106eucas1p119ab7de9758f13ea52adc0f4829ab9cb@eucas1p1.samsung.com>
2018-11-27 13:50 ` [Qemu-devel] [PATCH v2 4/4] memfd: improve error messages Ilya Maximets
2019-03-11 12:34 ` [Qemu-devel] [PATCH v2 0/4] memfd fixes Ilya Maximets
2019-03-11 12:50 ` Marc-André Lureau
2019-03-11 12:56 ` Daniel P. Berrangé
2019-03-11 14:12 ` Eduardo Habkost
2019-03-11 14:14 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212064936.ubnv3yif34e7ga5j@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=i.maximets@samsung.com \
--cc=imammedo@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.