From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
"Herton R. Krzesinski" <herton@redhat.com>
Subject: [PATCHv3 01/10] tools lib traceevent: Use LDFLAGS in the build commands
Date: Wed, 12 Dec 2018 10:12:14 +0100 [thread overview]
Message-ID: <20181212091214.GC17489@krava> (raw)
In-Reply-To: <20181128135641.GD31608@kernel.org>
On Wed, Nov 28, 2018 at 10:56:41AM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
> LD /tmp/build/perf/libtraceevent-in.o
> MKDIR /tmp/build/perf/util/
> LINK /tmp/build/perf/libtraceevent.a
> CC /tmp/build/perf/util/block-range.o
> MKDIR /tmp/build/perf/arch/
> CC /tmp/build/perf/arch/common.o
> LD /tmp/build/perf/plugin_mac80211-in.o
> CC /tmp/build/perf/plugin_sched_switch.o
> LD /tmp/build/perf/plugin_sched_switch-in.o
> CC /tmp/build/perf/plugin_function.o
> LD /tmp/build/perf/plugin_function-in.o
> CC /tmp/build/perf/plugin_xen.o
> MKDIR /tmp/build/perf/arch/arm/util/
> CC /tmp/build/perf/arch/arm/util/pmu.o
> LD /tmp/build/perf/plugin_xen-in.o
> CC /tmp/build/perf/plugin_scsi.o
> CC /tmp/build/perf/plugin_cfg80211.o
> LD /tmp/build/perf/plugin_scsi-in.o
> LD /tmp/build/perf/plugin_cfg80211-in.o
> MKDIR /tmp/build/perf/arch/arm/util/
> CC /tmp/build/perf/arch/arm/util/auxtrace.o
> CC /tmp/build/perf/arch/arm/util/cs-etm.o
> LINK /tmp/build/perf/plugin_jbd2.so
> /opt/android-ndk-r12b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: cannot find -lc
> /opt/android-ndk-r12b/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: cannot find -ldl
> collect2: error: ld returned 1 exit status
> Makefile:196: recipe for target '/tmp/build/perf/plugin_jbd2.so' failed
> make[3]: *** [/tmp/build/perf/plugin_jbd2.so] Error 1
> Makefile.perf:669: recipe for target 'libtraceevent_plugins' failed
> make[2]: *** [libtraceevent_plugins] Error 2
> make[2]: *** Waiting for unfinished jobs....
>
>
SNIP
> 1 59.08 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0
> 2 68.75 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822
> 3 79.67 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0
> 4 48.69 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0
> 5 46.89 alpine:3.8 : Ok gcc (Alpine 6.4.0) 6.4.0
> 6 46.46 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0
> 7 38.46 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
> 8 44.69 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
> 9 41.88 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
> 10 46.24 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
> 11 22.22 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
> 12 35.54 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)
ok, I shouldn't have taken out the CFLAGS,
some build scripts depends on it already
attaching v2
thanks,
jirka
---
So user could specify outside LDFLAGS values.
Keeping the CFLAGS in there as well, so we don't break
existing script.
Cc: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/lib/traceevent/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
index 67fe5d7ef190..941761d9923d 100644
--- a/tools/lib/traceevent/Makefile
+++ b/tools/lib/traceevent/Makefile
@@ -177,7 +177,7 @@ $(TE_IN): force
$(Q)$(MAKE) $(build)=libtraceevent
$(OUTPUT)libtraceevent.so.$(EVENT_PARSE_VERSION): $(TE_IN)
- $(QUIET_LINK)$(CC) --shared $^ -Wl,-soname,libtraceevent.so.$(EP_VERSION) -o $@
+ $(QUIET_LINK)$(CC) --shared $(LDFLAGS) $^ -Wl,-soname,libtraceevent.so.$(EP_VERSION) -o $@
@ln -sf $(@F) $(OUTPUT)libtraceevent.so
@ln -sf $(@F) $(OUTPUT)libtraceevent.so.$(EP_VERSION)
@@ -196,7 +196,7 @@ $(PLUGINS_IN): force
$(Q)$(MAKE) $(build)=$(plugin_obj)
$(OUTPUT)%.so: $(OUTPUT)%-in.o
- $(QUIET_LINK)$(CC) $(CFLAGS) -shared -nostartfiles -o $@ $^
+ $(QUIET_LINK)$(CC) $(CFLAGS) -shared $(LDFLAGS) -nostartfiles -o $@ $^
define make_version.h
(echo '/* This file is automatically generated. Do not modify. */'; \
--
2.17.2
next prev parent reply other threads:[~2018-12-12 9:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 15:06 [PATCH 00/10] tools: Various build flags fixes Jiri Olsa
2018-10-16 15:06 ` [PATCH 01/10] tools lib traceevent: Use LDFLAGS in the build commands Jiri Olsa
2018-10-16 15:21 ` Steven Rostedt
2018-10-16 15:45 ` [PATCHv2 " Jiri Olsa
2018-10-17 14:23 ` Steven Rostedt
2018-11-16 13:01 ` Jiri Olsa
2018-11-22 9:30 ` Jiri Olsa
2018-11-26 18:40 ` Arnaldo Carvalho de Melo
2018-11-28 13:56 ` Arnaldo Carvalho de Melo
2018-12-12 9:12 ` Jiri Olsa [this message]
2018-12-12 12:41 ` [PATCHv3 " Arnaldo Carvalho de Melo
2018-12-20 18:07 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-10-16 15:06 ` [PATCH 02/10] tools perf: Pass build flags to traceevent build Jiri Olsa
2018-10-18 6:20 ` [tip:perf/urgent] perf tools: " tip-bot for Jiri Olsa
2018-10-30 9:25 ` [PATCH 02/10] tools perf: " Jiri Olsa
2018-10-16 15:06 ` [PATCH 03/10] tools cpupower debug: Allow to use outside build flags Jiri Olsa
2018-10-16 15:06 ` [PATCH 04/10] tools cpupower: Override CFLAGS assignments Jiri Olsa
2018-10-16 15:06 ` [PATCH 05/10] tools power x86_energy_perf_policy: Override CFLAGS assignments and add LDFLAGS to build command Jiri Olsa
2018-10-30 9:27 ` Jiri Olsa
2018-10-16 15:06 ` [PATCH 06/10] tools thermal tmon: Override CFLAGS assignments Jiri Olsa
2018-10-30 9:27 ` Jiri Olsa
2018-10-16 15:06 ` [PATCH 07/10] tools thermal tmon: Use -O3 instead of -O1 if available Jiri Olsa
2018-10-16 15:06 ` [PATCH 08/10] tools power turbostat: Override CFLAGS assignments and add LDFLAGS to build command Jiri Olsa
2018-10-30 9:27 ` Jiri Olsa
2018-10-16 15:06 ` [PATCH 09/10] tools iio: Override CFLAGS assignments Jiri Olsa
2018-10-21 12:26 ` Jonathan Cameron
2018-10-22 8:53 ` Jiri Olsa
2018-10-17 13:23 ` [PATCH 00/10] tools: Various build flags fixes Thomas Renninger
2018-10-17 15:28 ` Shuah Khan
2018-10-22 8:51 ` Jiri Olsa
2018-10-23 15:17 ` Shuah Khan
2018-10-23 16:53 ` Shuah Khan
2018-10-23 17:21 ` Jiri Olsa
2018-10-22 14:50 ` [PATCH 10/10] tools gpio: Override CFLAGS assignments Jiri Olsa
2018-10-30 9:34 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212091214.GC17489@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=herton@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.