From: David Gibson <david@gibson.dropbear.id.au>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, otubo@redhat.com
Subject: Re: [Qemu-devel] [PATCH] seccomp: check TSYNC host capability
Date: Thu, 13 Dec 2018 14:24:52 +1100 [thread overview]
Message-ID: <20181213032452.GA25689@umbus.fritz.box> (raw)
In-Reply-To: <20180830143348.10595-1-marcandre.lureau@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1905 bytes --]
On Thu, Aug 30, 2018 at 04:33:48PM +0200, Marc-André Lureau wrote:
> Remove -sandbox option if the host is not capable of TSYNC, since the
> sandbox will fail at setup time otherwise. This will help libvirt, for
> ex, to figure out if -sandbox will work.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
This seems to have introduced a regression, which I found when
preparing a ppc pull request. Specifically when running with RHEL7 on
a POWER host, using "-sandbox off" which one of my tests did, causes a
cryptic error followed by a SEGV:
$ ./ppc64-softmmu/qemu-system-ppc64 -sandbox off
qemu-system-ppc64: -sandbox off: There is no option group 'sandbox'
Segmentation fault
$ ./x86_64-softmmu/qemu-system-x86_64 -sandbox off
qemu-system-x86_64: -sandbox off: There is no option group 'sandbox'
Segmentation fault
I think the problem is that while this wrapped one use of the sandbox
option group to produce a sensible error, it didn't do the same for
another call to qemu_opts_parse_noisily():
(gdb) bt
#0 0x00000000105b36d8 in opts_parse (list=0x0, params=0x3ffffffffab5 "off", permit_abbrev=true, defaults=false, errp=0x3ffffffff080)
at util/qemu-option.c:829
#1 0x00000000105b3b74 in qemu_opts_parse_noisily (list=<optimized out>, params=<optimized out>, permit_abbrev=<optimized out>) at util/qemu-option.c:890
#2 0x0000000010024964 in main (argc=<optimized out>, argv=<optimized out>, envp=<optimized out>) at vl.c:3589
I'm guessing RHEL7 triggers it because that has a version of
libseccomp that doesn't support the feature needed to complete
registration (maybe on ppc host only; I haven't had a chance to try on
an x86 RHEL7 host).
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-12-13 3:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 14:33 [Qemu-devel] [PATCH] seccomp: check TSYNC host capability Marc-André Lureau
2018-09-10 8:36 ` Eduardo Otubo
2018-12-13 3:24 ` David Gibson [this message]
2019-04-29 13:21 ` Thomas Huth
2019-04-29 13:49 ` Marc-André Lureau
2019-04-29 13:49 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213032452.GA25689@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=marcandre.lureau@redhat.com \
--cc=otubo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.