From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [RFC v3] /net: memory interface (memif)
Date: Thu, 13 Dec 2018 10:07:09 -0800
Message-ID: <20181213100709.2df8f718@xeon-e3>
References: <20181213133051.18779-1-jgrajcia@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>
To: Jakub Grajciar <jgrajcia@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com
 [209.85.210.172]) by dpdk.org (Postfix) with ESMTP id 160A01B565
 for <dev@dpdk.org>; Thu, 13 Dec 2018 19:07:14 +0100 (CET)
Received: by mail-pf1-f172.google.com with SMTP id c73so1470084pfe.13
 for <dev@dpdk.org>; Thu, 13 Dec 2018 10:07:13 -0800 (PST)
In-Reply-To: <20181213133051.18779-1-jgrajcia@cisco.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 13 Dec 2018 14:30:51 +0100
Jakub Grajciar <jgrajcia@cisco.com> wrote:

> +
> +typedef uint16_t memif_region_index_t;
> +typedef uint32_t memif_region_offset_t;
> +typedef uint64_t memif_region_size_t;
> +typedef uint16_t memif_ring_index_t;
> +typedef uint32_t memif_interface_id_t;
> +typedef uint16_t memif_version_t;
> +typedef uint8_t memif_log2_ring_size_t;
> +

Seems very typedef heavy to me. Having more typedefs
does not improve the readability.


> +typedef struct __attribute__ ((packed)) {

Use __rte_packed rather than attributes directly.

> +typedef struct __attribute__ ((packed)) {
> +	uint8_t if_name[32];
> +} memif_msg_connect_t;
> +

Why magic constant 32? Better to use something like

#define MEMIF_NAMESZ 32

Also, I am confused about how this relates
to DPDK device names and Linux network device names (if at all).