From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Fomichev Subject: [PATCH bpf-next 3/6] selftests/bpf: skip verifier tests for unsupported program types Date: Thu, 13 Dec 2018 11:02:58 -0800 Message-ID: <20181213190301.65816-4-sdf@google.com> References: <20181213190301.65816-1-sdf@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: davem@davemloft.net, daniel@iogearbox.net, ecree@solarflare.com, quentin.monnet@netronome.com, Stanislav Fomichev To: netdev@vger.kernel.org, ast@kernel.org Return-path: Received: from mail-qk1-f202.google.com ([209.85.222.202]:56646 "EHLO mail-qk1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726457AbeLMTDW (ORCPT ); Thu, 13 Dec 2018 14:03:22 -0500 Received: by mail-qk1-f202.google.com with SMTP id a199so2437956qkb.23 for ; Thu, 13 Dec 2018 11:03:21 -0800 (PST) In-Reply-To: <20181213190301.65816-1-sdf@google.com> Sender: netdev-owner@vger.kernel.org List-ID: Use recently introduced bpf_prog_type_supported() to skip tests in the test_verifier() if bpf_verify_program() fails. The skipped test is indicated in the output. Example: ... 679/p bpf_get_stack return R0 within range SKIP (unsupported program type 5) 680/p ld_abs: invalid op 1 OK ... Summary: 863 PASSED, 165 SKIPPED, 3 FAILED Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/Makefile | 1 + tools/testing/selftests/bpf/test_verifier.c | 9 ++++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index 52a0654145ad..9e9c5ada3e9b 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -82,6 +82,7 @@ $(OUTPUT)/get_cgroup_id_user: cgroup_helpers.c $(OUTPUT)/test_cgroup_storage: cgroup_helpers.c $(OUTPUT)/test_netcnt: cgroup_helpers.c $(OUTPUT)/test_maps: probe_helpers.c +$(OUTPUT)/test_verifier: probe_helpers.c .PHONY: force diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c index a08c67c8767e..124d21306c27 100644 --- a/tools/testing/selftests/bpf/test_verifier.c +++ b/tools/testing/selftests/bpf/test_verifier.c @@ -45,6 +45,7 @@ #include "bpf_rand.h" #include "bpf_util.h" #include "../../../include/linux/filter.h" +#include "probe_helpers.h" #define MAX_INSNS BPF_MAXINSNS #define MAX_FIXUPS 8 @@ -57,6 +58,7 @@ #define UNPRIV_SYSCTL "kernel/unprivileged_bpf_disabled" static bool unpriv_disabled = false; +static int skips; struct bpf_test { const char *descr; @@ -14409,6 +14411,11 @@ static void do_test_single(struct bpf_test *test, bool unpriv, pflags |= BPF_F_ANY_ALIGNMENT; fd_prog = bpf_verify_program(prog_type, prog, prog_len, pflags, "GPL", 0, bpf_vlog, sizeof(bpf_vlog), 1); + if (fd_prog < 0 && !bpf_prog_type_supported(prog_type)) { + printf("SKIP (unsupported program type %d)\n", prog_type); + skips++; + goto close_fds; + } expected_ret = unpriv && test->result_unpriv != UNDEF ? test->result_unpriv : test->result; @@ -14532,7 +14539,7 @@ static bool test_as_unpriv(struct bpf_test *test) static int do_test(bool unpriv, unsigned int from, unsigned int to) { - int i, passes = 0, errors = 0, skips = 0; + int i, passes = 0, errors = 0; for (i = from; i < to; i++) { struct bpf_test *test = &tests[i]; -- 2.20.0.rc2.403.gdbc3b29805-goog