Re: [v5,04/17] mtd: rawnand: omap2: convert driver to nand_scan()

From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>, Lucas Stach <dev@lynxeye.de>,
	Wenyou Yang <wenyou.yang@microchip.com>,
	Josh Wu <rainyfeeling@outlook.com>,
	Stefan Agner <stefan@agner.ch>,
	linux-mtd@lists.infradead.org
Subject: Re: [v5,04/17] mtd: rawnand: omap2: convert driver to nand_scan()
Date: Thu, 13 Dec 2018 19:37:25 +0100	[thread overview]
Message-ID: <20181213193725.4c1771c5@bbrezillon> (raw)
In-Reply-To: <20181213190111.2f32cfaffa5ea26f77bae520@gmail.com>

On Thu, 13 Dec 2018 19:01:11 +0100
Alexander Sverdlin <alexander.sverdlin@gmail.com> wrote:

> > +	/* Re-populate low-level callbacks based on xfer modes */
> > +	switch (info->xfer_type) {
> > +	case NAND_OMAP_PREFETCH_POLLED:
> > +		chip->read_buf = omap_read_buf_pref;
> > +		chip->write_buf = omap_write_buf_pref;
> > +		break;
> > +
> > +	case NAND_OMAP_POLLED:
> > +		/* Use nand_base defaults for {read,write}_buf */
> > +		break;
> > +
> > +	case NAND_OMAP_PREFETCH_DMA:
> > +		dma_cap_zero(mask);
> > +		dma_cap_set(DMA_SLAVE, mask);
> > +		info->dma = dma_request_chan(dev, "rxtx");
> > +
> > +		if (IS_ERR(info->dma)) {
> > +			dev_err(dev, "DMA engine request failed\n");

Can you print the error code here?