From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Fri, 14 Dec 2018 11:49:26 +0100 Subject: [U-Boot] [PATCH 1/1] arm: sunxi: Add NULL pointer check In-Reply-To: References: <20181205122757.14523-1-stefan@olimex.com> Message-ID: <20181214104926.li2kyz7i2tgcu5wc@flea> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Dec 14, 2018 at 03:48:18PM +0530, Jagan Teki wrote: > On Wed, Dec 5, 2018 at 5:58 PM Stefan Mavrodiev wrote: > > > > Current driver doesn't check if the destination pointer is NULL. > > This cause the data from the FIFO to be stored inside the internal > > SDRAM ( address 0 ). > > > > The patch add simple check if the destination pointer is NULL. > > > > Signed-off-by: Stefan Mavrodiev > > --- > > drivers/spi/sun4i_spi.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/spi/sun4i_spi.c b/drivers/spi/sun4i_spi.c > > index b86b5a00ad..38cc743c61 100644 > > --- a/drivers/spi/sun4i_spi.c > > +++ b/drivers/spi/sun4i_spi.c > > @@ -129,7 +129,8 @@ static inline void sun4i_spi_drain_fifo(struct sun4i_spi_priv *priv, int len) > > > > while (len--) { > > byte = readb(&priv->regs->rxdata); > > - *priv->rx_buf++ = byte; > > + if (priv->rx_buf) > > + *priv->rx_buf++ = byte; > > Acked-by: Jagan Teki > > But, have you tested how much data in the fifo before drained? It's > better we can get the available data before reading via fifo_sta This patch shouldn't be merged in its current state. Please look at the on-going discussion. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: