All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: Roopa Prabhu <roopa@cumulusnetworks.com>,
	David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next 1/4] net: rtnetlink: support for fdb get
Date: Fri, 14 Dec 2018 11:54:21 -0800	[thread overview]
Message-ID: <20181214115421.545038a2@cakuba.netronome.com> (raw)
In-Reply-To: <e5f6a8ec-7510-0b30-9f41-5404c3178677@cumulusnetworks.com>

On Fri, 14 Dec 2018 12:42:21 -0700, David Ahern wrote:
> On 12/14/18 12:37 PM, Jakub Kicinski wrote:
> > Oh, so we'd use the STRICT checking in doit for the first time?  I
> > better send that rename patch then..  
> 
> IMHO, no. The flag is for older userspace that could be sending junk in
> the request. All new code should do strict checking without the flag set
> to ensure only proper requests are handled.

I'm going back and forth on that in my head.  IDK if new user space
shouldn't be able to do a get request on an old kernel which doesn't
understand some of the attributes.  Grey area.. perhaps it needs to be
decided on case by case basis?  For my stats work I think returning too
many stats if what is affectively a filter is not understood may be a
good option.  Perhaps for fdb get it makes more sense to error out.
hmm..

  reply	other threads:[~2018-12-14 19:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 17:43 [PATCH net-next 0/4] rtnl fdb get Roopa Prabhu
2018-12-14 17:43 ` [PATCH net-next 1/4] net: rtnetlink: support for " Roopa Prabhu
2018-12-14 17:55   ` David Ahern
2018-12-14 18:09     ` Roopa Prabhu
2018-12-14 19:37       ` Jakub Kicinski
2018-12-14 19:42         ` David Ahern
2018-12-14 19:54           ` Jakub Kicinski [this message]
2018-12-14 19:58             ` David Ahern
2018-12-14 21:03               ` Jakub Kicinski
2018-12-14 18:17   ` Nikolay Aleksandrov
2018-12-14 17:43 ` [PATCH net-next 2/4] bridge: support for ndo_fdb_get Roopa Prabhu
2018-12-14 18:24   ` Nikolay Aleksandrov
2018-12-14 17:43 ` [PATCH net-next 3/4] vxlan: " Roopa Prabhu
2018-12-14 17:43 ` [PATCH net-next 4/4] selftests: net: rtnetlink.sh: add fdb get test Roopa Prabhu
2018-12-14 19:19 ` [PATCH net-next 0/4] rtnl fdb get David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181214115421.545038a2@cakuba.netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.