All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: fix env flags for eth10addr and above
Date: Fri, 14 Dec 2018 08:28:36 -0500	[thread overview]
Message-ID: <20181214132836.GH8702@bill-the-cat> (raw)
In-Reply-To: <CAAh8qswVk=6pn6W1yOxpwNeWXt2hOYeqMA4z6P7_3w_11qtDOQ@mail.gmail.com>

On Fri, Dec 14, 2018 at 09:56:19AM +0100, Simon Goldschmidt wrote:

> +Tom
> 
> On Sun, Dec 9, 2018 at 9:51 PM Simon Goldschmidt
> <simon.k.r.goldschmidt@gmail.com> wrote:
> >
> > Am 22.11.2018 um 17:06 schrieb Simon Goldschmidt:
> > > With CONFIG_REGEX enabled, ETHADDR_WILDCARD is set up for up to 10
> > > interfaces (0..9) as the number can only have one digit.
> > >
> > > On boards with more than 10 interfaces, this leads to the protection
> > > and format checks being absent for eth10addr and above.
> > >
> > > Fix this by changing ETHADDR_WILDCARD from "\\d?" to "\\d*" to allow
> > > more than one digit.
> > >
> > > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> > > ---
> > >
> > >   include/env_flags.h | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/env_flags.h b/include/env_flags.h
> > > index cc2c34f939..23744e395c 100644
> > > --- a/include/env_flags.h
> > > +++ b/include/env_flags.h
> > > @@ -38,7 +38,7 @@ enum env_flags_varaccess {
> > >
> > >   #ifdef CONFIG_CMD_NET
> > >   #ifdef CONFIG_REGEX
> > > -#define ETHADDR_WILDCARD "\\d?"
> > > +#define ETHADDR_WILDCARD "\\d*"
> > >   #else
> > >   #define ETHADDR_WILDCARD
> > >   #endif
> > >
> >
> > Ping?
> 
> I haven't gotten an answer to this for nearly one month. It's a small
> change, can this go in for v2019.01 please?

I'd filed this off to Joe to grab since it is indeed small and a
clean-up.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181214/6ed861af/attachment.sig>

  reply	other threads:[~2018-12-14 13:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22 16:06 [U-Boot] [PATCH] net: fix env flags for eth10addr and above Simon Goldschmidt
2018-12-09 20:51 ` Simon Goldschmidt
2018-12-14  8:56   ` Simon Goldschmidt
2018-12-14 13:28     ` Tom Rini [this message]
2019-01-14 15:42       ` Simon Goldschmidt
2019-01-14 16:28         ` Tom Rini
2019-01-14 18:19           ` Joe Hershberger
2019-01-14 18:23             ` Simon Goldschmidt
2019-01-15  8:58 ` Joe Hershberger
2019-01-24 17:38 ` [U-Boot] " Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181214132836.GH8702@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.