From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9AD8C67839 for ; Fri, 14 Dec 2018 13:34:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B53C20643 for ; Fri, 14 Dec 2018 13:34:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aylTyPya" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729897AbeLNNeP (ORCPT ); Fri, 14 Dec 2018 08:34:15 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:38640 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728415AbeLNNeO (ORCPT ); Fri, 14 Dec 2018 08:34:14 -0500 Received: by mail-wr1-f68.google.com with SMTP id v13so5457143wrw.5; Fri, 14 Dec 2018 05:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vb0X9n9w8JqGYo5z9PbBnFCU3O44aSyMG0gDOJRiHjQ=; b=aylTyPyaLka5HLw5cVxFOR5d2Pl224OAcT75VxBd0R44cbbCSpX1hI1WPaE01GruCZ qRlBfRHlbsYExzlH1a9GWZQgQba+MTzKgNscfmcvDrMoxxQ0iccPCdKn8uLYkdCFspO4 RPos8Q39xyEDR89LnvNAeVWW6dpnO318fHkKqVicHgjtRooB+MNU14GJxHLAhJdn8XE4 kVCjX19TVmw6BFlWIz48YSKguJNujdGQUBM2DaWkJV26UBBqbMMDmcyOa5JSYrs+o07S r4vML3rlRC2IhbZDwq6OE7IEgST5rqH9g1knpy3d6WaEJDgMTqETrFFsQjV481+7BxsK kS/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vb0X9n9w8JqGYo5z9PbBnFCU3O44aSyMG0gDOJRiHjQ=; b=DHxN6G8eLx/hNiOp2XA9MVoAEzYFN5UpHJLYtLuwA2DQnmci5RnR6Bz6rHne9TspFw DpYOdjrIxdTqsOuCxi/oOBknJSqSgz+6KWuFabW4gEakBFZ9m2XcDJxc/WPkVl+ggtj6 zEb62zWY8PC2ZptyLwFHOCu4VXMgjREPs8mFfegY9Ymj6gOz3jEtnGCaHzPVKzGKuHj5 ermnyjh5CF570Ax7jvlNfvUAu2TKQeE7vbwpoZAT72KzrL75cHdo40Sz7TIj7OEctoNF T2p1pUQyEkltukF6K4cOgFbyZ9JFXD0tyylMWPxDav+fPMezyomnZanSBUf6raaAUAbV yQSw== X-Gm-Message-State: AA+aEWbmRkBgwH5AaCTxDYmqZhwS+NdPRihsX6qvbQPyWb6Bu64NlPzW suH22OVr9jshA468eG9M/gQ= X-Google-Smtp-Source: AFSGD/UyziNpC6NmA99zr12tIdEjh+szSkCe0JEVPVvbiwOcO2eTZyXw4Tgt7JHkcRtSQ/9Al01NYQ== X-Received: by 2002:adf:e488:: with SMTP id i8mr2764255wrm.10.1544794452037; Fri, 14 Dec 2018 05:34:12 -0800 (PST) Received: from rocks ([84.88.51.80]) by smtp.gmail.com with ESMTPSA id y145sm3948193wmd.30.2018.12.14.05.34.11 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 14 Dec 2018 05:34:11 -0800 (PST) Date: Fri, 14 Dec 2018 14:34:09 +0100 From: Aleix Roca Nonell To: Benjamin Tissoires Cc: Jiri Kosina , "open list:HID CORE LAYER" , lkml , mbrugger@suse.com Subject: Re: [PATCH] HID: asus: Add support for the ASUS T101HA keyboard dock Message-ID: <20181214133409.GB4189@rocks> References: <20181201190153.GB4995@arks.localdomain> <20181214080700.GA4189@rocks> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Benjamin! :D On Fri, Dec 14, 2018 at 09:25:20AM +0100, Benjamin Tissoires wrote: > Hi Aleix, > > On Fri, Dec 14, 2018 at 9:07 AM Aleix Roca Nonell wrote: > > > > Kind remminder ping :) > > Hehe, I have seen the patch floating by and realized I would need more > than 2 minutes to answer it so it fell a little bit behind in my TODO > list. > > Let's try to work on this now. > > > > > I'm also adding my fellow Matthias in CC > > > > On Sat, Dec 01, 2018 at 08:01:53PM +0100, Aleix Roca Nonell wrote: > > > The ASUS T101HA keyboard dock generates HID events using the ASUS vendor > > > specific UsagePage 0xff31. In consequence, some multimedia keys such as > > > brightness up and down are not working with hid-generic. > > > > > > This commit adds the T101HA dock into the supported device list of the > > > hid-asus driver. It also prevents the dock's integrated touchpad to be > > > bound with hid-asus given that it is already working fine with > > > hid-multitouch. > > > > > > Signed-off-by: Aleix Roca Nonell > > > --- > > > > > > This is my very first kernel patch done in my free time (be aware of the > > > newbie!!) so please, let me know if I can improve anything and I will > > > happily do it :) > > > > > > drivers/hid/hid-asus.c | 12 ++++++++++++ > > > drivers/hid/hid-ids.h | 1 + > > > 2 files changed, 13 insertions(+) > > > > > > diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c > > > index ab8bd40a77ed..d8b55dca97c6 100644 > > > --- a/drivers/hid/hid-asus.c > > > +++ b/drivers/hid/hid-asus.c > > > @@ -42,6 +42,7 @@ MODULE_AUTHOR("Frederik Wenigwieser "); > > > MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad"); > > > > > > #define T100_TPAD_INTF 2 > > > +#define T101HA_TPAD_INTF 2 > > > > > > #define T100CHI_MOUSE_REPORT_ID 0x06 > > > #define FEATURE_REPORT_ID 0x0d > > > @@ -70,6 +71,7 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad"); > > > #define QUIRK_T100_KEYBOARD BIT(6) > > > #define QUIRK_T100CHI BIT(7) > > > #define QUIRK_G752_KEYBOARD BIT(8) > > > +#define QUIRK_T101HA_DOCK BIT(9) > > > > > > #define I2C_KEYBOARD_QUIRKS (QUIRK_FIX_NOTEBOOK_REPORT | \ > > > QUIRK_NO_INIT_REPORTS | \ > > > @@ -649,6 +651,14 @@ static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id) > > > int ret; > > > struct asus_drvdata *drvdata; > > > > > > + if (id->driver_data & QUIRK_T101HA_DOCK) { > > > + struct usb_interface *intf = to_usb_interface(hdev->dev.parent); > > I know the hid-asus driver already does this for the other devices, > but it would be nice not to. USB is part of the low level transport > and HID drivers should have no reasons to assume the USB driver is > used and that it will stay forever. > > What I ask when we have such a case is to check on the report > descriptor to see if there is anything we could use in it (usually the > application) to skip this HID interface. > > Besides that, there is not much more to say. Great I will do that! > For having a look at the report descriptor, you can either use printk > in the kernel, or use hid-recorder as root in > https://gitlab.freedesktop.org/libevdev/hid-tools. Regarding the descriptor, shouldn't be ok to check /sys/kernel/debug/hid//rdesc ? Thank you! > > Cheers, > Benjamin > > > > + > > > + /* use hid-multitouch for T101HA touchpad */ > > > + if (intf->altsetting->desc.bInterfaceNumber == T101HA_TPAD_INTF) > > > + return -ENODEV; > > > + } > > > + > > > drvdata = devm_kzalloc(&hdev->dev, sizeof(*drvdata), GFP_KERNEL); > > > if (drvdata == NULL) { > > > hid_err(hdev, "Can't alloc Asus descriptor\n"); > > > @@ -830,6 +840,8 @@ static const struct hid_device_id asus_devices[] = { > > > { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, > > > USB_DEVICE_ID_ASUSTEK_T100TAF_KEYBOARD), > > > QUIRK_T100_KEYBOARD | QUIRK_NO_CONSUMER_USAGES }, > > > + { HID_USB_DEVICE(USB_VENDOR_ID_ASUSTEK, > > > + USB_DEVICE_ID_ASUSTEK_T101HA_KEYBOARD), QUIRK_T101HA_DOCK }, > > > { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_ASUS_AK1D) }, > > > { HID_USB_DEVICE(USB_VENDOR_ID_TURBOX, USB_DEVICE_ID_ASUS_MD_5110) }, > > > { HID_USB_DEVICE(USB_VENDOR_ID_JESS, USB_DEVICE_ID_ASUS_MD_5112) }, > > > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > > > index 4206428c0ba2..f1eee2778b70 100644 > > > --- a/drivers/hid/hid-ids.h > > > +++ b/drivers/hid/hid-ids.h > > > @@ -184,6 +184,7 @@ > > > #define USB_DEVICE_ID_ASUSTEK_T100TA_KEYBOARD 0x17e0 > > > #define USB_DEVICE_ID_ASUSTEK_T100TAF_KEYBOARD 0x1807 > > > #define USB_DEVICE_ID_ASUSTEK_T100CHI_KEYBOARD 0x8502 > > > +#define USB_DEVICE_ID_ASUSTEK_T101HA_KEYBOARD 0x183d > > > #define USB_DEVICE_ID_ASUSTEK_T304_KEYBOARD 0x184a > > > #define USB_DEVICE_ID_ASUSTEK_I2C_KEYBOARD 0x8585 > > > #define USB_DEVICE_ID_ASUSTEK_I2C_TOUCHPAD 0x0101 > > > -- > > > 2.19.2 > > >