All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
	apw@canonical.com, Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, niklas.cassel@linaro.org
Subject: Re: [PATCH] checkpatch: add Co-Developed-by to signature tags
Date: Fri, 14 Dec 2018 17:13:44 +0100	[thread overview]
Message-ID: <20181214161344.GA10654@kroah.com> (raw)
In-Reply-To: <839c1d04000164e27dff9742e3efc3bcff3025b6.camel@perches.com>

On Fri, Dec 14, 2018 at 07:52:15AM -0800, Joe Perches wrote:
> On Fri, 2018-12-14 at 14:01 +0100, Jorge Ramirez-Ortiz wrote:
> > As per Documentation/process/submitting-patches, Co-developed-by is a
> > valid signature.
> > 
> > This commit removes the warning.
> 
> Your commit message doesn't match your subject.
> 
> A couple variants have been documented and only
> one should actually be used.
> 
> $ git grep -i co-developed-by Documentation/process/
> Documentation/process/5.Posting.rst: - Co-developed-by: states that the patch was also created by another developer
> Documentation/process/submitting-patches.rst:12) When to use Acked-by:, Cc:, and Co-Developed-by:
> Documentation/process/submitting-patches.rst:A Co-Developed-by: states that the patch was also created by another developer
> 
> $ git log --grep="co-developed-by:" -i | \
>   grep -ohiP "co-developed-by:" | sort | uniq -c | sort -rn
>      80 Co-developed-by:
>      40 Co-Developed-by:
> 
> So which should it be?

"Co-developed-by:" please.

Yeah, I wrote the original one wrong here, sorry.

> btw: I prefer neither as I think Signed-off-by: is sufficient.

Nope, sorry, it is not, we need something like this which is why it was
added.

thanks,

greg k-h

  parent reply	other threads:[~2018-12-14 16:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 13:01 [PATCH] checkpatch: add Co-Developed-by to signature tags Jorge Ramirez-Ortiz
2018-12-14 15:52 ` Joe Perches
2018-12-14 16:03   ` Jorge Ramirez
2018-12-14 16:13   ` Greg KH [this message]
2018-12-14 17:18     ` Jorge Ramirez
2018-12-14 16:16   ` Himanshu Jha
2018-12-14 16:27     ` Joe Perches
2018-12-14 17:28       ` Himanshu Jha
2018-12-14 17:39         ` Joe Perches
2018-12-14 17:54           ` Jorge Ramirez
2018-12-14 18:35           ` Himanshu Jha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181214161344.GA10654@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=jorge.ramirez-ortiz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=niklas.cassel@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.