From: Stephen Hemminger <stephen@networkplumber.org>
To: gaetan.rivet@6wind.com
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: [PATCH] net/failsafe: remove unnecessary debug messages
Date: Fri, 14 Dec 2018 11:35:52 -0800 [thread overview]
Message-ID: <20181214193552.12408-1-stephen@networkplumber.org> (raw)
The failsafe driver spews messages every time it is polling
making debugging other things more difficult. Just remove it.
Example:
net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm
net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm
...
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
drivers/net/failsafe/failsafe_private.h | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h
index 7e3189685901..0dfea65c2a3c 100644
--- a/drivers/net/failsafe/failsafe_private.h
+++ b/drivers/net/failsafe/failsafe_private.h
@@ -399,9 +399,6 @@ fs_lock(struct rte_eth_dev *dev, unsigned int is_alarm)
return ret;
}
}
- DEBUG("Hot-plug mutex was locked by thread %" FS_THREADID_FMT "%s",
- (FS_THREADID_TYPE)pthread_self(),
- PRIV(dev)->alarm_lock ? " by the hot-plug alarm" : "");
return ret;
}
@@ -413,7 +410,6 @@ static inline void
fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm)
{
int ret;
- unsigned int prev_alarm_lock = PRIV(dev)->alarm_lock;
if (is_alarm) {
RTE_ASSERT(PRIV(dev)->alarm_lock == 1);
@@ -422,10 +418,6 @@ fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm)
ret = pthread_mutex_unlock(&PRIV(dev)->hotplug_mutex);
if (ret)
ERROR("Cannot unlock hot-plug mutex(%s)", strerror(ret));
- else
- DEBUG("Hot-plug mutex was unlocked by thread %" FS_THREADID_FMT "%s",
- (FS_THREADID_TYPE)pthread_self(),
- prev_alarm_lock ? " by the hot-plug alarm" : "");
}
/*
--
2.19.2
next reply other threads:[~2018-12-14 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 19:35 Stephen Hemminger [this message]
2018-12-20 19:14 ` [PATCH] net/failsafe: remove unnecessary debug messages Ferruh Yigit
2018-12-20 19:17 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214193552.12408-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.