From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver
Date: Sat, 15 Dec 2018 20:59:40 +0100
Message-ID: <20181215195940.GF5922@lunn.ch>
References: <20181214161149.6493-1-marex@denx.de>
 <13845d07-3958-dd55-5e2f-bb088db057e7@gmail.com>
 <3cb8b832-b1b8-783e-d1c6-0e1859849775@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Marek Vasut <marex@denx.de>, netdev@vger.kernel.org,
        f.fainelli@gmail.com
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:48956 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727168AbeLOT7n (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 15 Dec 2018 14:59:43 -0500
Content-Disposition: inline
In-Reply-To: <3cb8b832-b1b8-783e-d1c6-0e1859849775@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> >> +static int tja11xx_config_init(struct phy_device *phydev)
> >> +{
> >> +	int ret;
> >> +
> >> +	ret = tja11xx_enable_reg_write(phydev);
> >> +	if (ret)
> >> +		return ret;
> >> +
> >> +	phydev->irq = PHY_POLL;
> >> +	phydev->autoneg = AUTONEG_DISABLE;
> >> +	phydev->speed = SPEED_100;
> 
> One more thing: In the data sheet there are SPEED_SELECT bits allowing
> to set also 10MBit and 1GBit mode. Don't you want to support this?

Hi Heiner

Did you read footnote 2?

Speed Select. 00: 10 Mbits; 01: 100Mbit/s, 10: 1000Mbit/s, 11:
reserved. a write access value other than 01 is ignored.

So the bits are there, but not really used. It can only do 100Mbit/s.

   Andrew