From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33980C43387 for ; Mon, 17 Dec 2018 14:10:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7A4D2133F for ; Mon, 17 Dec 2018 14:10:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="TVZYntZi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733187AbeLQOKJ (ORCPT ); Mon, 17 Dec 2018 09:10:09 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:47070 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727583AbeLQOKJ (ORCPT ); Mon, 17 Dec 2018 09:10:09 -0500 Received: by mail-wr1-f67.google.com with SMTP id l9so12375723wrt.13 for ; Mon, 17 Dec 2018 06:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4Vta0M/fQVRTlBNYE1kAewYSFkDr9n3kHJqgLj7geIk=; b=TVZYntZimXn+8rpLKuR99wNFRZ3iV/ZM4F1BV0W0+VTyzzczUPkC5jRGRDALmfR0Yc 40HeZNI8iLEue0A+v4/w5bDvjoUuNufHeTxJ0F6qAI1kQCUV9TxoC1d1zheGBC91cgDl 7TzgOB0V7r1R5lf11y3/FN285VYcCbdzaDbcI2zJPSQsfQGUY0yoYHk3M6FAjPvRerY0 22aI1Up1BVrNXa6b3VXE1IRypw0wsALEAMEPk5e6n5YTjZ8y55zKXYQxaJ5Tl4i8vFf/ 2jCnaGYPpFYdFWzDReHf8JGsH7PJBSsQe10Zg2bDfRgCecneOdkW+7Dgo20SzXc2nJpu /95Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4Vta0M/fQVRTlBNYE1kAewYSFkDr9n3kHJqgLj7geIk=; b=RYwwsTJtdmguX+obU+/ZR6wJmK6whb8+GGus6hmLULFliLSZ82fMmQC5M4AHg3B2D1 8ytyV4payNZU7H+ncbgn4kUcPXs3RTDxbCx0pQOFC02OwfbGaqPnt3QVXwj1TzeDF0pF 7/6xL7eKYEHTySZnpB9EqNhGJaf17piVpyBDiZH7kJdGRuPvOCwum2CKsNeCrBHHTUTu kQNKms0ruZWhptVQCO5VMUcQ4rjL/9XAc+NXU7+MwDxrhLHRe0/ZLbR6N/xg6gSV1bS8 1gwndqoRZzVVfnFX+Mv4gn4ioE/C5NL2G5gURRsU0vYX+YolpwlEtwR7yPZKSfQKfttu T3kw== X-Gm-Message-State: AA+aEWY2SVJS+5OWrH7KCfb5tmnAWIPcLfUtmszGzLGZBWTDe4XnTyln y/8fMRgtXQP4hs8ISTWEK0T1UA== X-Google-Smtp-Source: AFSGD/WGJYFWyZuGXd8rCUpKN/N76S4XsPJydfOnzW0OjhHd/FOJ6eccIlrVCZkhKLFU99tnOOrSXQ== X-Received: by 2002:a5d:5351:: with SMTP id t17mr10782496wrv.288.1545055807335; Mon, 17 Dec 2018 06:10:07 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id f66sm13900556wmd.28.2018.12.17.06.10.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Dec 2018 06:10:06 -0800 (PST) Date: Mon, 17 Dec 2018 15:02:33 +0100 From: Jiri Pirko To: Jian-Hong Pan Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , "David S . Miller" , Alan Cox , linux-lpwan@lists.infradead.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marcel Holtmann , Dollar Chen , Ken Yu , linux-wpan@vger.kernel.org Subject: Re: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module Message-ID: <20181217140233.GG2096@nanopsycho> References: <20181216101858.9585-6-starnight@g.ncu.edu.tw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181216101858.9585-6-starnight@g.ncu.edu.tw> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sun, Dec 16, 2018 at 11:18:59AM CET, starnight@g.ncu.edu.tw wrote: >LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa devices. > >This patch implements part of Class A end-devices SoftMAC defined in >LoRaWAN(TM) Specification Ver. 1.0.2: >1. End-device receive slot timing >2. Only single channel and single data rate for now >3. Unconfirmed data up/down message types > >On the other side, it defines the basic interface and operation >functions for compatible LoRa device drivers. > >Signed-off-by: Jian-Hong Pan >--- >V2: >- Split the LoRaWAN class module patch in V1 into LoRaWAN socket and > LoRaWAN Soft MAC modules >- Modify for Big/Little-Endian >- Use SPDX license identifiers > >V3: >- Remove the decoration word - inline of the functions >- Order local variables from longest to shortest line in the functions >- Change the calling mac_cb function to lrw_get_mac_cb macro > >V4: >- Fix the delay period between RX window#1 and window#2 >- Fix by coding style report from scripts/checkpatch.pl > >V5: >- Initial rx_skb_list when it is allocated with LoRa hardware >- Check the sk_buff's data length before access it >- Deal FPort field and decrypt payload in lrw_parse_frame function >- Drop the recieved frame if parse failed >- Fix the bug which passes wrong skb properties from maclorawan to lorawan module > > net/maclorawan/Kconfig | 14 + > net/maclorawan/Makefile | 2 + > net/maclorawan/mac.c | 555 ++++++++++++++++++++++++++++++++++++ > net/maclorawan/main.c | 606 ++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 1177 insertions(+) > create mode 100644 net/maclorawan/Kconfig > create mode 100644 net/maclorawan/Makefile > create mode 100644 net/maclorawan/mac.c > create mode 100644 net/maclorawan/main.c I don't get it. In patch "Add LoRaWAN API declaration for LoRa devices" you add headers for "API" and here you implement functions. That is just weird. Does it mean you can have other implementations? Also, you don't really have any user of this API in the set. Please introduce at least 1 driver, preferably more (I see that Andreas has multiple ones in his patchset). You cannot push kernel infrastructure without kernel user. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA06DC43387 for ; Mon, 17 Dec 2018 14:10:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1D292133F for ; Mon, 17 Dec 2018 14:10:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jTMKzNvq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="TVZYntZi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1D292133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mISexXB416rwHxi8gMAlVjaxXBd+HOXnV69ALnL9tRk=; b=jTMKzNvqO+kpkP zzrH/I7EDyXTSrE9zbQgLIDzSAExgnlj1CnmBQFcTxiDgPAUbSUfNGt97yVGApfEs6MzvWQmsNzeQ XU21hozL4Ny/EZnfJcxPeV7epmGXEOMhlnh4SlJEEKxC3EaignIpyZyQzUFb1J68dYcMwiIGWoAGS tW7GvfudDlRtTHcp1eANrjbtVpTeH18SyxNouFuLYMe0TRG5ZD7wy6Q2B91kjxrpL4UjJWpo9ufcL u4er/tHW4Da6bz+zCAePpSkyRnVper8vM0IV9bG4P3ZkSIBhw03D4kMGeepfl6IbdlZECFez7JGmz WRvGN7mFp5/XUH25ldLw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gYtbD-0006y6-TP; Mon, 17 Dec 2018 14:10:23 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gYtb9-0006JX-Mz for linux-arm-kernel@lists.infradead.org; Mon, 17 Dec 2018 14:10:21 +0000 Received: by mail-wr1-x443.google.com with SMTP id s12so11982975wrt.4 for ; Mon, 17 Dec 2018 06:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4Vta0M/fQVRTlBNYE1kAewYSFkDr9n3kHJqgLj7geIk=; b=TVZYntZimXn+8rpLKuR99wNFRZ3iV/ZM4F1BV0W0+VTyzzczUPkC5jRGRDALmfR0Yc 40HeZNI8iLEue0A+v4/w5bDvjoUuNufHeTxJ0F6qAI1kQCUV9TxoC1d1zheGBC91cgDl 7TzgOB0V7r1R5lf11y3/FN285VYcCbdzaDbcI2zJPSQsfQGUY0yoYHk3M6FAjPvRerY0 22aI1Up1BVrNXa6b3VXE1IRypw0wsALEAMEPk5e6n5YTjZ8y55zKXYQxaJ5Tl4i8vFf/ 2jCnaGYPpFYdFWzDReHf8JGsH7PJBSsQe10Zg2bDfRgCecneOdkW+7Dgo20SzXc2nJpu /95Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4Vta0M/fQVRTlBNYE1kAewYSFkDr9n3kHJqgLj7geIk=; b=C3LAfAr3olWbAsXT9CyHTK2KR569ByMQBYMN1zmkSsHVztXYBUYxZduVbm4ZyCj7b2 5/I+uDseBGcNoKmyxqzKpygbrvadbPBfYUPhbe3GynrHa/u3V78l89pv8oh+TDu9SM6a wH8IYdDf6eMvdm3JToWe6WS9FgAehBBXycb/c5a8a94WPj0llsqvLpjfpBCQjtLZPZgh qXu/kLKTs7jwOkANqmxahmPlrG8TYon/ZTId2/kpVRglrgh+2HlINb4Uvd0EaAM5Eo32 H/TYVD738Xprh3DVvU5ZuKY4yPHHmDDUXGnn3bqk33LjF8GCQaOFrM/WUEKZ3Ns5szpH x1PQ== X-Gm-Message-State: AA+aEWY14wX9z1H0iq/9vWtvjfktbg4mJAw5acmkPZIElVfifyM6zidu 1LHHPwkttHortMMKRczY3bQH4w== X-Google-Smtp-Source: AFSGD/WGJYFWyZuGXd8rCUpKN/N76S4XsPJydfOnzW0OjhHd/FOJ6eccIlrVCZkhKLFU99tnOOrSXQ== X-Received: by 2002:a5d:5351:: with SMTP id t17mr10782496wrv.288.1545055807335; Mon, 17 Dec 2018 06:10:07 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id f66sm13900556wmd.28.2018.12.17.06.10.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Dec 2018 06:10:06 -0800 (PST) Date: Mon, 17 Dec 2018 15:02:33 +0100 From: Jiri Pirko To: Jian-Hong Pan Subject: Re: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module Message-ID: <20181217140233.GG2096@nanopsycho> References: <20181216101858.9585-6-starnight@g.ncu.edu.tw> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181216101858.9585-6-starnight@g.ncu.edu.tw> User-Agent: Mutt/1.9.5 (2018-04-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181217_061019_746129_5B0FF654 X-CRM114-Status: GOOD ( 13.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alan Cox , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Marcel Holtmann , linux-lpwan@lists.infradead.org, "David S . Miller" , Dollar Chen , Ken Yu , linux-wpan@vger.kernel.org, Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sun, Dec 16, 2018 at 11:18:59AM CET, starnight@g.ncu.edu.tw wrote: >LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa devices. > >This patch implements part of Class A end-devices SoftMAC defined in >LoRaWAN(TM) Specification Ver. 1.0.2: >1. End-device receive slot timing >2. Only single channel and single data rate for now >3. Unconfirmed data up/down message types > >On the other side, it defines the basic interface and operation >functions for compatible LoRa device drivers. > >Signed-off-by: Jian-Hong Pan >--- >V2: >- Split the LoRaWAN class module patch in V1 into LoRaWAN socket and > LoRaWAN Soft MAC modules >- Modify for Big/Little-Endian >- Use SPDX license identifiers > >V3: >- Remove the decoration word - inline of the functions >- Order local variables from longest to shortest line in the functions >- Change the calling mac_cb function to lrw_get_mac_cb macro > >V4: >- Fix the delay period between RX window#1 and window#2 >- Fix by coding style report from scripts/checkpatch.pl > >V5: >- Initial rx_skb_list when it is allocated with LoRa hardware >- Check the sk_buff's data length before access it >- Deal FPort field and decrypt payload in lrw_parse_frame function >- Drop the recieved frame if parse failed >- Fix the bug which passes wrong skb properties from maclorawan to lorawan module > > net/maclorawan/Kconfig | 14 + > net/maclorawan/Makefile | 2 + > net/maclorawan/mac.c | 555 ++++++++++++++++++++++++++++++++++++ > net/maclorawan/main.c | 606 ++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 1177 insertions(+) > create mode 100644 net/maclorawan/Kconfig > create mode 100644 net/maclorawan/Makefile > create mode 100644 net/maclorawan/mac.c > create mode 100644 net/maclorawan/main.c I don't get it. In patch "Add LoRaWAN API declaration for LoRa devices" you add headers for "API" and here you implement functions. That is just weird. Does it mean you can have other implementations? Also, you don't really have any user of this API in the set. Please introduce at least 1 driver, preferably more (I see that Andreas has multiple ones in his patchset). You cannot push kernel infrastructure without kernel user. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel