All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Eric Auger <eric.auger@redhat.com>
Subject: [Qemu-devel] [PULL 17/31] pcie: Fast PCIe root ports for new machines
Date: Mon, 17 Dec 2018 23:17:55 -0500	[thread overview]
Message-ID: <20181218041625.24969-18-mst@redhat.com> (raw)
In-Reply-To: <20181218041625.24969-1-mst@redhat.com>

From: Alex Williamson <alex.williamson@redhat.com>

Change the default speed and width for new machine types to the
fastest and widest currently supported.  This should be compatible to
the PCIe 4.0 spec.  Pre-QEMU-4.0 machine types remain at 2.5GT/s, x1
width.

Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/hw/compat.h                | 10 +++++++++-
 hw/pci-bridge/gen_pcie_root_port.c |  4 ++--
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/include/hw/compat.h b/include/hw/compat.h
index 70958328fe..3ca85b037c 100644
--- a/include/hw/compat.h
+++ b/include/hw/compat.h
@@ -2,7 +2,15 @@
 #define HW_COMPAT_H
 
 #define HW_COMPAT_3_1 \
-    /* empty */
+    {\
+        .driver   = "pcie-root-port",\
+        .property = "x-speed",\
+        .value    = "2_5",\
+    },{\
+        .driver   = "pcie-root-port",\
+        .property = "x-width",\
+        .value    = "1",\
+    },
 
 #define HW_COMPAT_3_0 \
     /* empty */
diff --git a/hw/pci-bridge/gen_pcie_root_port.c b/hw/pci-bridge/gen_pcie_root_port.c
index ca5418a89d..9766edb445 100644
--- a/hw/pci-bridge/gen_pcie_root_port.c
+++ b/hw/pci-bridge/gen_pcie_root_port.c
@@ -125,9 +125,9 @@ static Property gen_rp_props[] = {
     DEFINE_PROP_SIZE("pref64-reserve", GenPCIERootPort,
                      res_reserve.mem_pref_64, -1),
     DEFINE_PROP_PCIE_LINK_SPEED("x-speed", PCIESlot,
-                                speed, PCIE_LINK_SPEED_2_5),
+                                speed, PCIE_LINK_SPEED_16),
     DEFINE_PROP_PCIE_LINK_WIDTH("x-width", PCIESlot,
-                                width, PCIE_LINK_WIDTH_1),
+                                width, PCIE_LINK_WIDTH_32),
     DEFINE_PROP_END_OF_LIST()
 };
 
-- 
MST

  parent reply	other threads:[~2018-12-18  4:18 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18  4:16 [Qemu-devel] [PULL 00/31] pci, pc, virtio: fixes, features Michael S. Tsirkin
2018-12-18  4:16 ` [Qemu-devel] [PULL 01/31] pcie: set link state inactive/active after hot unplug/plug Michael S. Tsirkin
2018-12-18  4:16 ` [Qemu-devel] [PULL 02/31] pc:piix4: Update smbus I/O space after a migration Michael S. Tsirkin
2018-12-18  4:16 ` [Qemu-devel] [PULL 03/31] virtio: Helper for registering virtio device types Michael S. Tsirkin
2018-12-18  4:16 ` [Qemu-devel] [PULL 04/31] virtio: Provide version-specific variants of virtio PCI devices Michael S. Tsirkin
2018-12-18  4:16 ` [Qemu-devel] [PULL 05/31] tests: Remove unused include Michael S. Tsirkin
2018-12-18  4:17 ` [Qemu-devel] [PULL 06/31] hw/smbios: Restrict access to "hw/smbios/ipmi.h" Michael S. Tsirkin
2018-12-18  4:17 ` [Qemu-devel] [PULL 07/31] hw/smbios: Remove "smbios_ipmi.h" Michael S. Tsirkin
2018-12-18  4:17 ` [Qemu-devel] [PULL 08/31] hw/smbios: Move to the hw/firmware/ subdirectory Michael S. Tsirkin
2018-12-18  4:17 ` [Qemu-devel] [PULL 09/31] hw/pci-bridge: Fix invalid free() Michael S. Tsirkin
2018-12-18  4:17 ` [Qemu-devel] [PULL 10/31] pcie: Create enums for link speed and width Michael S. Tsirkin
2018-12-18  4:17 ` [Qemu-devel] [PULL 11/31] pci: Sync PCIe downstream port LNKSTA on read Michael S. Tsirkin
2018-12-18  4:17 ` [Qemu-devel] [PULL 12/31] qapi: Define PCIe link speed and width properties Michael S. Tsirkin
2018-12-18  4:17 ` [Qemu-devel] [PULL 13/31] pcie: Add link speed and width fields to PCIESlot Michael S. Tsirkin
2018-12-18  4:17 ` [Qemu-devel] [PULL 14/31] pcie: Fill PCIESlot link fields to support higher speeds and widths Michael S. Tsirkin
2018-12-18  4:17 ` [Qemu-devel] [PULL 15/31] pcie: Allow generic PCIe root port to specify link speed and width Michael S. Tsirkin
2018-12-18  4:17 ` [Qemu-devel] [PULL 16/31] vfio/pci: Remove PCIe Link Status emulation Michael S. Tsirkin
2018-12-18  4:17 ` Michael S. Tsirkin [this message]
2018-12-18  4:18 ` [Qemu-devel] [PULL 18/31] intel_iommu: dump correct iova when failed Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 19/31] intel_iommu: convert invalid traces into error reports Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 20/31] intel_iommu: dma read/write draining support Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 21/31] intel_iommu: remove "x-" prefix for "aw-bits" Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 22/31] intel_iommu: turn on IR by default Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 23/31] hw: acpi: The RSDP build API can return void Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 24/31] hw: arm: acpi: Fix incorrect checksums in RSDP Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 25/31] hw: i386: Use correct RSDT length for checksum Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 26/31] hw: arm: Carry RSDP specific data through AcpiRsdpData Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 27/31] hw: arm: Convert the RSDP build to the buid_append_foo() API Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 28/31] hw: arm: Support both legacy and current RSDP build Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 29/31] hw: acpi: Export and share the ARM " Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 30/31] hw: acpi: Remove AcpiRsdpDescriptor and fix tests Michael S. Tsirkin
2018-12-18  4:18 ` [Qemu-devel] [PULL 31/31] hw/i386: Remove deprecated machines pc-0.10 and pc-0.11 Michael S. Tsirkin
2018-12-18  4:37 ` [Qemu-devel] [PULL 00/31] pci, pc, virtio: fixes, features Michael S. Tsirkin
2018-12-24 12:34 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181218041625.24969-18-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.