From: Catalin Marinas <catalin.marinas@arm.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Juergen Gross <jgross@suse.com>,
Helmut Grohne <helmut.grohne@intenta.de>,
Will Deacon <will.deacon@arm.com>,
Paul Durrant <paul.durrant@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Ben Hutchings <ben@decadent.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined!
Date: Tue, 18 Dec 2018 13:21:46 +0000 [thread overview]
Message-ID: <20181218132146.GA20197@arrakis.emea.arm.com> (raw)
In-Reply-To: <20181218100908.GL26090@n2100.armlinux.org.uk>
On Tue, Dec 18, 2018 at 10:09:09AM +0000, Russell King wrote:
> On Tue, Dec 18, 2018 at 10:36:32AM +0100, Helmut Grohne wrote:
> > During a compile test of v4.20-rc7 for armhf (cross build), I
> > encountered:
> >
> > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined!
> >
> > Some searching brought up c5157101e77 ("arm64: mm: Export
> > __sync_icache_dcache() for xen-privcmd"), which fixes a very similar
> > problem for arm64. Is that commit maybe also needed for arm?
>
> I would rather not export that function for drivers to abuse.
I think that's a lower risk than the other cache maintenance functions.
This function only deals with the cache maintenance to PoU while
drivers, in general, are more interested in the PoC.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-18 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 9:36 ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! Helmut Grohne
2018-12-18 10:09 ` Russell King - ARM Linux
2018-12-18 13:21 ` Catalin Marinas [this message]
2019-03-04 22:04 ` Boris Ostrovsky
2019-03-04 22:28 ` Catalin Marinas
2019-03-04 22:49 ` Boris Ostrovsky
2019-03-05 8:08 ` Arnd Bergmann
2018-12-18 21:53 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218132146.GA20197@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=ben@decadent.org.uk \
--cc=boris.ostrovsky@oracle.com \
--cc=helmut.grohne@intenta.de \
--cc=jgross@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=paul.durrant@citrix.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.