From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85AC1C43387 for ; Tue, 18 Dec 2018 15:15:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55D2A218A2 for ; Tue, 18 Dec 2018 15:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545146138; bh=hL+OjmqDQsMlbbsagd8Nizmshe4fBv3fqkUyaYlrrlI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2nhayHzMkm8T1I2/qM5JgnhnzpnWbs58qpVhYdXU9vd7IhjGkmW4iNOU4I6HvYBMr iObn2452wwSW8lff7C7C6LzsK6IE7k54pv7M67QKXHiB0HLr3wxgQ9iwvyeo6lYEiP 6nbA4Mdah/YvQOa9/hBYYpMCN5hxUVYjZWbS3qiI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726869AbeLRPPh (ORCPT ); Tue, 18 Dec 2018 10:15:37 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:45064 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726546AbeLRPPg (ORCPT ); Tue, 18 Dec 2018 10:15:36 -0500 Received: by mail-oi1-f193.google.com with SMTP id y1so2174695oie.12; Tue, 18 Dec 2018 07:15:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=R6FiizF1WZO/jYfpHg3Lq2YG0OpoJsKc5a+tOWuKe9M=; b=qpXl+P7jpxgs42NuayiPAqNS90Cl7ZBBAeOWVpM3SJa4CcHd+VWJ8C2rgsbtUamP78 hXfLvPauXMGwGjJlMo5a82t6hcdO9Uviu/qOfBehf5w/UtDZ9KgKc7nilUO2rUxXpH9R OQRk6F7jNXVR/P25AhL2yvJws0w2WLCCSSQyRrvdHEdnQwfMYeGOo7/M0muDI5CcxF/W NFM6sCIL5cq5PnmG1VgWynzrfhoInwpsAab59/XipD7Ij6Ojd/oYcbnMgMmrhTqPG5yk e9yJOHPYTl+/oHBNkgEneRKko0/91bnQv5ZQWuOXOnoHY6cPVea6AKzyo16FWmDptIGn eXGw== X-Gm-Message-State: AA+aEWZSRVN8oetjPXPwR2lu2JS7oE8JzPcpm54euwNCNNlN0TezsuVP Ag7Gvu0QvdxMllYIePcqYg== X-Google-Smtp-Source: AFSGD/U+VViOFv01xysi619namV0zfIztq2Q1OIIQsE1SoxVMSJAxcYAiY7owRJpQ8eXZN/HS9/TOA== X-Received: by 2002:aca:5205:: with SMTP id g5mr8315705oib.149.1545146134892; Tue, 18 Dec 2018 07:15:34 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l6sm2813042otk.51.2018.12.18.07.15.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Dec 2018 07:15:34 -0800 (PST) Date: Tue, 18 Dec 2018 09:15:33 -0600 From: Rob Herring To: Andrey Smirnov Cc: Lorenzo Pieralisi , Bjorn Helgaas , Fabio Estevam , Chris Healy , Lucas Stach , Leonard Crestez , "A.s. Dong" , Richard Zhu , devicetree@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v3 3/3] PCI: imx6: Add support for i.MX8MQ Message-ID: <20181218151533.GA2922@bogus> References: <20181218040702.29231-1-andrew.smirnov@gmail.com> <20181218040702.29231-4-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181218040702.29231-4-andrew.smirnov@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 17, 2018 at 08:07:02PM -0800, Andrey Smirnov wrote: > Add code needed to support i.MX8MQ variant. > > Signed-off-by: Andrey Smirnov > Reviewed-by: Lucas Stach > Cc: Bjorn Helgaas > Cc: Fabio Estevam > Cc: Chris Healy > Cc: Lucas Stach > Cc: Leonard Crestez > Cc: "A.s. Dong" > Cc: Richard Zhu > Cc: Rob Herring > Cc: devicetree@vger.kernel.org > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-pci@vger.kernel.org > --- > .../bindings/pci/fsl,imx6q-pcie.txt | 6 +- > drivers/pci/controller/dwc/Kconfig | 4 +- > drivers/pci/controller/dwc/pci-imx6.c | 82 ++++++++++++++++++- > 3 files changed, 87 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > index d514c1f2365f..1a10c313e8d7 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > @@ -9,6 +9,7 @@ Required properties: > - "fsl,imx6sx-pcie", > - "fsl,imx6qp-pcie" > - "fsl,imx7d-pcie" > + - "fsl,imx8mq-pcie" > - reg: base address and length of the PCIe controller > - interrupts: A list of interrupt outputs of the controller. Must contain an > entry for each entry in the interrupt-names property. > @@ -45,7 +46,7 @@ Additional required properties for imx6sx-pcie: > PCIE_PHY power domains > - power-domain-names: Must be "pcie", "pcie_phy" > > -Additional required properties for imx7d-pcie: > +Additional required properties for imx7d-pcie and imx8mq-pcie: > - power-domains: Must be set to a phandle pointing to PCIE_PHY power domain > - resets: Must contain phandles to PCIe-related reset lines exposed by SRC > IP block > @@ -54,6 +55,9 @@ Additional required properties for imx7d-pcie: > - "apps" > - "turnoff" > > +Additional required properties for imx8mq-pcie: > +- fsl,controller-id: Logical ID of a given PCIE controller. PCIE1 is 0, PCIE2 is 1; > + Remove this. If GPR register offset is what you need, then put that into DT. Typically, we'd have a property with iomuxc phandle and offset. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3EB4C43387 for ; Tue, 18 Dec 2018 15:15:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92A78218A2 for ; Tue, 18 Dec 2018 15:15:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dGaXzP52" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92A78218A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eeT/mAQ2zavi6jMy+9Wm+HuMs0YDcBtX8qBFd0YeGNo=; b=dGaXzP52nniSy6 zXaRUicyAxPo6H2jV5Wjp79K8wbWMYJfkuwn/4yCB6/Hr+FpHbfYn5G4WqriOFztBGO5YHL3+j89c dIdiNKiy38CvwalXJdnzjgnQY53vQdA89CkHCHKEeWGoO8OpRwspNfHGc7UR4BGD1Bgz8LzjMA7uG SzYHbXIYMc7sR48ikUqhQFQ7CbI13ESshQwljYuf16Y2oodo8kLEoWE+hQVuNQQ6gjnTRGAx/Oh+2 pn+yJsTwlUxJ4wlhtfH+qRc6jt1RGg3vpTSll6n3pby9MBQpLLaHTekTfzDC2bd+E53AV3RF2PJq5 tcpc33AlwvkWmNp0/m6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZH66-0008T2-UG; Tue, 18 Dec 2018 15:15:50 +0000 Received: from mail-oi1-f195.google.com ([209.85.167.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZH63-0008S7-3N for linux-arm-kernel@lists.infradead.org; Tue, 18 Dec 2018 15:15:48 +0000 Received: by mail-oi1-f195.google.com with SMTP id x23so2222748oix.3 for ; Tue, 18 Dec 2018 07:15:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=R6FiizF1WZO/jYfpHg3Lq2YG0OpoJsKc5a+tOWuKe9M=; b=SJGiF/jewvGJQZ9Ep1zq489WiCs2oD0wfBaep9/5J0D6Bf6gZzloE8VJH0G/cbwTS3 yPrSZx6v9nbeEhTbAKe6ia5mwfYC9uq6s+I8JMOWhNHbXunPZXCih0Rl2zzTn94tpZpg rXeRZvdQwBwP1p69s85VSjKwK0Qcv5wA9vPtpOaCpRbANXOnhV8Uea1oCZj6AkMsCx/c 2cWiBgCU0pH23qDtV1r991vqvtLdiF8gFqiIHW2liav2e8pKgUVYTr14HkX0UZx8OMjl QhPUraUSoXJyNkf24bom+Qh5QD7E+KLkYvveTVxpWUQ67HK4CsKe/aq6zQZhIv9aIl6c Iu1g== X-Gm-Message-State: AA+aEWaAKgfGvfIZn8dX/cXXvUIHLErlJpUXNiVqzHRiznf2kuJvyzyX M//oCOZc3f2C68YPrb1Juw== X-Google-Smtp-Source: AFSGD/U+VViOFv01xysi619namV0zfIztq2Q1OIIQsE1SoxVMSJAxcYAiY7owRJpQ8eXZN/HS9/TOA== X-Received: by 2002:aca:5205:: with SMTP id g5mr8315705oib.149.1545146134892; Tue, 18 Dec 2018 07:15:34 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l6sm2813042otk.51.2018.12.18.07.15.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Dec 2018 07:15:34 -0800 (PST) Date: Tue, 18 Dec 2018 09:15:33 -0600 From: Rob Herring To: Andrey Smirnov Subject: Re: [PATCH v3 3/3] PCI: imx6: Add support for i.MX8MQ Message-ID: <20181218151533.GA2922@bogus> References: <20181218040702.29231-1-andrew.smirnov@gmail.com> <20181218040702.29231-4-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181218040702.29231-4-andrew.smirnov@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181218_071547_163875_B1639E0E X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "A.s. Dong" , devicetree@vger.kernel.org, Lorenzo Pieralisi , Richard Zhu , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Fabio Estevam , linux-imx@nxp.com, Bjorn Helgaas , Leonard Crestez , Chris Healy , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 17, 2018 at 08:07:02PM -0800, Andrey Smirnov wrote: > Add code needed to support i.MX8MQ variant. > > Signed-off-by: Andrey Smirnov > Reviewed-by: Lucas Stach > Cc: Bjorn Helgaas > Cc: Fabio Estevam > Cc: Chris Healy > Cc: Lucas Stach > Cc: Leonard Crestez > Cc: "A.s. Dong" > Cc: Richard Zhu > Cc: Rob Herring > Cc: devicetree@vger.kernel.org > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-pci@vger.kernel.org > --- > .../bindings/pci/fsl,imx6q-pcie.txt | 6 +- > drivers/pci/controller/dwc/Kconfig | 4 +- > drivers/pci/controller/dwc/pci-imx6.c | 82 ++++++++++++++++++- > 3 files changed, 87 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > index d514c1f2365f..1a10c313e8d7 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > @@ -9,6 +9,7 @@ Required properties: > - "fsl,imx6sx-pcie", > - "fsl,imx6qp-pcie" > - "fsl,imx7d-pcie" > + - "fsl,imx8mq-pcie" > - reg: base address and length of the PCIe controller > - interrupts: A list of interrupt outputs of the controller. Must contain an > entry for each entry in the interrupt-names property. > @@ -45,7 +46,7 @@ Additional required properties for imx6sx-pcie: > PCIE_PHY power domains > - power-domain-names: Must be "pcie", "pcie_phy" > > -Additional required properties for imx7d-pcie: > +Additional required properties for imx7d-pcie and imx8mq-pcie: > - power-domains: Must be set to a phandle pointing to PCIE_PHY power domain > - resets: Must contain phandles to PCIe-related reset lines exposed by SRC > IP block > @@ -54,6 +55,9 @@ Additional required properties for imx7d-pcie: > - "apps" > - "turnoff" > > +Additional required properties for imx8mq-pcie: > +- fsl,controller-id: Logical ID of a given PCIE controller. PCIE1 is 0, PCIE2 is 1; > + Remove this. If GPR register offset is what you need, then put that into DT. Typically, we'd have a property with iomuxc phandle and offset. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel