All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] memory_hotplug: add missing newlines to debugging output
@ 2018-12-18 16:23 ` Michal Hocko
  0 siblings, 0 replies; 4+ messages in thread
From: Michal Hocko @ 2018-12-18 16:23 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Pavel Tatashin, linux-mm, LKML, Michal Hocko

From: Michal Hocko <mhocko@suse.com>

pages_correctly_probed is missing new lines which means that the line is
not printed rightaway but it rather waits for additional printks.

Add \n to all three messages in pages_correctly_probed.

Fixes: b77eab7079d9 ("mm/memory_hotplug: optimize probe routine")
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 drivers/base/memory.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 0e5985682642..b5ff45ab7967 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn)
 			return false;
 
 		if (!present_section_nr(section_nr)) {
-			pr_warn("section %ld pfn[%lx, %lx) not present",
+			pr_warn("section %ld pfn[%lx, %lx) not present\n",
 				section_nr, pfn, pfn + PAGES_PER_SECTION);
 			return false;
 		} else if (!valid_section_nr(section_nr)) {
-			pr_warn("section %ld pfn[%lx, %lx) no valid memmap",
+			pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n",
 				section_nr, pfn, pfn + PAGES_PER_SECTION);
 			return false;
 		} else if (online_section_nr(section_nr)) {
-			pr_warn("section %ld pfn[%lx, %lx) is already online",
+			pr_warn("section %ld pfn[%lx, %lx) is already online\n",
 				section_nr, pfn, pfn + PAGES_PER_SECTION);
 			return false;
 		}
-- 
2.19.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] memory_hotplug: add missing newlines to debugging output
@ 2018-12-18 16:23 ` Michal Hocko
  0 siblings, 0 replies; 4+ messages in thread
From: Michal Hocko @ 2018-12-18 16:23 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Pavel Tatashin, linux-mm, LKML, Michal Hocko

From: Michal Hocko <mhocko@suse.com>

pages_correctly_probed is missing new lines which means that the line is
not printed rightaway but it rather waits for additional printks.

Add \n to all three messages in pages_correctly_probed.

Fixes: b77eab7079d9 ("mm/memory_hotplug: optimize probe routine")
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 drivers/base/memory.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 0e5985682642..b5ff45ab7967 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn)
 			return false;
 
 		if (!present_section_nr(section_nr)) {
-			pr_warn("section %ld pfn[%lx, %lx) not present",
+			pr_warn("section %ld pfn[%lx, %lx) not present\n",
 				section_nr, pfn, pfn + PAGES_PER_SECTION);
 			return false;
 		} else if (!valid_section_nr(section_nr)) {
-			pr_warn("section %ld pfn[%lx, %lx) no valid memmap",
+			pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n",
 				section_nr, pfn, pfn + PAGES_PER_SECTION);
 			return false;
 		} else if (online_section_nr(section_nr)) {
-			pr_warn("section %ld pfn[%lx, %lx) is already online",
+			pr_warn("section %ld pfn[%lx, %lx) is already online\n",
 				section_nr, pfn, pfn + PAGES_PER_SECTION);
 			return false;
 		}
-- 
2.19.2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] memory_hotplug: add missing newlines to debugging output
  2018-12-18 16:23 ` Michal Hocko
  (?)
@ 2018-12-18 16:34 ` Oscar Salvador
  -1 siblings, 0 replies; 4+ messages in thread
From: Oscar Salvador @ 2018-12-18 16:34 UTC (permalink / raw)
  To: Michal Hocko; +Cc: Andrew Morton, Pavel Tatashin, linux-mm, LKML, Michal Hocko

On Tue, Dec 18, 2018 at 05:23:07PM +0100, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>

> Fixes: b77eab7079d9 ("mm/memory_hotplug: optimize probe routine")
> Signed-off-by: Michal Hocko <mhocko@suse.com>

Reviewed-by: Oscar Salvador <osalvador@suse.de>

> ---
>  drivers/base/memory.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index 0e5985682642..b5ff45ab7967 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn)
>  			return false;
>  
>  		if (!present_section_nr(section_nr)) {
> -			pr_warn("section %ld pfn[%lx, %lx) not present",
> +			pr_warn("section %ld pfn[%lx, %lx) not present\n",
>  				section_nr, pfn, pfn + PAGES_PER_SECTION);
>  			return false;
>  		} else if (!valid_section_nr(section_nr)) {
> -			pr_warn("section %ld pfn[%lx, %lx) no valid memmap",
> +			pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n",
>  				section_nr, pfn, pfn + PAGES_PER_SECTION);
>  			return false;
>  		} else if (online_section_nr(section_nr)) {
> -			pr_warn("section %ld pfn[%lx, %lx) is already online",
> +			pr_warn("section %ld pfn[%lx, %lx) is already online\n",
>  				section_nr, pfn, pfn + PAGES_PER_SECTION);
>  			return false;
>  		}
> -- 
> 2.19.2
> 

-- 
Oscar Salvador
SUSE L3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] memory_hotplug: add missing newlines to debugging output
  2018-12-18 16:23 ` Michal Hocko
  (?)
  (?)
@ 2018-12-18 21:26 ` Wei Yang
  -1 siblings, 0 replies; 4+ messages in thread
From: Wei Yang @ 2018-12-18 21:26 UTC (permalink / raw)
  To: Michal Hocko; +Cc: Andrew Morton, Pavel Tatashin, linux-mm, LKML, Michal Hocko

On Tue, Dec 18, 2018 at 05:23:07PM +0100, Michal Hocko wrote:
>From: Michal Hocko <mhocko@suse.com>
>
>pages_correctly_probed is missing new lines which means that the line is
>not printed rightaway but it rather waits for additional printks.
>
>Add \n to all three messages in pages_correctly_probed.
>
>Fixes: b77eab7079d9 ("mm/memory_hotplug: optimize probe routine")
>Signed-off-by: Michal Hocko <mhocko@suse.com>

Reviewed-by: Wei Yang <richard.weiyang@gmail.com>

>---
> drivers/base/memory.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/base/memory.c b/drivers/base/memory.c
>index 0e5985682642..b5ff45ab7967 100644
>--- a/drivers/base/memory.c
>+++ b/drivers/base/memory.c
>@@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn)
> 			return false;
> 
> 		if (!present_section_nr(section_nr)) {
>-			pr_warn("section %ld pfn[%lx, %lx) not present",
>+			pr_warn("section %ld pfn[%lx, %lx) not present\n",
> 				section_nr, pfn, pfn + PAGES_PER_SECTION);
> 			return false;
> 		} else if (!valid_section_nr(section_nr)) {
>-			pr_warn("section %ld pfn[%lx, %lx) no valid memmap",
>+			pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n",
> 				section_nr, pfn, pfn + PAGES_PER_SECTION);
> 			return false;
> 		} else if (online_section_nr(section_nr)) {
>-			pr_warn("section %ld pfn[%lx, %lx) is already online",
>+			pr_warn("section %ld pfn[%lx, %lx) is already online\n",
> 				section_nr, pfn, pfn + PAGES_PER_SECTION);
> 			return false;
> 		}
>-- 
>2.19.2

-- 
Wei Yang
Help you, Help me

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-12-18 21:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-18 16:23 [PATCH] memory_hotplug: add missing newlines to debugging output Michal Hocko
2018-12-18 16:23 ` Michal Hocko
2018-12-18 16:34 ` Oscar Salvador
2018-12-18 21:26 ` Wei Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.