From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 18 Dec 2018 10:38:58 -0600 From: Rob Herring Subject: Re: [PATCH v2 1/4] usb: dwc3: Add property snps,refclk-period-ns Message-ID: <20181218163858.GA12336@bogus> References: <83adc98adc1760a0fad87d81d171e1dac783e7e5.1544235317.git.thinhn@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83adc98adc1760a0fad87d81d171e1dac783e7e5.1544235317.git.thinhn@synopsys.com> To: Thinh Nguyen Cc: Felipe Balbi , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , John Youn List-ID: On Fri, Dec 07, 2018 at 06:27:30PM -0800, Thinh Nguyen wrote: > This patch introduces property "snps,refclk-period-ns" to inform the > controller of the reference clock period. If the reference clock period > is different from the default Core Consultant setting, then this > property can be set to the reference clock period. > > This property does not control the reference clock rate. The controller > uses this value to perform internal timing calculations that are based > on the reference clock. > > Signed-off-by: Thinh Nguyen > --- > Changes in v2: > - Split from "usb: dwc3: Add reference clock properties" > - Revise commit message and property description > > Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt > index 8e5265e9f658..b7e67edff9b2 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -99,6 +99,8 @@ Optional properties: > this and tx-thr-num-pkt-prd to a valid, non-zero value > 1-16 (DWC_usb31 programming guide section 1.2.3) to > enable periodic ESS TX threshold. > + - snps,refclk-period-ns: if set, this value informs the controller of the > + reference clock period in nanoseconds. Shouldn't you be able to retrieve the refclk frequency and then calculate the period? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,1/4] usb: dwc3: Add property snps,refclk-period-ns From: Rob Herring Message-Id: <20181218163858.GA12336@bogus> Date: Tue, 18 Dec 2018 10:38:58 -0600 To: Thinh Nguyen Cc: Felipe Balbi , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , John Youn List-ID: T24gRnJpLCBEZWMgMDcsIDIwMTggYXQgMDY6Mjc6MzBQTSAtMDgwMCwgVGhpbmggTmd1eWVuIHdy b3RlOgo+IFRoaXMgcGF0Y2ggaW50cm9kdWNlcyBwcm9wZXJ0eSAic25wcyxyZWZjbGstcGVyaW9k LW5zIiB0byBpbmZvcm0gdGhlCj4gY29udHJvbGxlciBvZiB0aGUgcmVmZXJlbmNlIGNsb2NrIHBl cmlvZC4gSWYgdGhlIHJlZmVyZW5jZSBjbG9jayBwZXJpb2QKPiBpcyBkaWZmZXJlbnQgZnJvbSB0 aGUgZGVmYXVsdCBDb3JlIENvbnN1bHRhbnQgc2V0dGluZywgdGhlbiB0aGlzCj4gcHJvcGVydHkg Y2FuIGJlIHNldCB0byB0aGUgcmVmZXJlbmNlIGNsb2NrIHBlcmlvZC4KPiAKPiBUaGlzIHByb3Bl cnR5IGRvZXMgbm90IGNvbnRyb2wgdGhlIHJlZmVyZW5jZSBjbG9jayByYXRlLiBUaGUgY29udHJv bGxlcgo+IHVzZXMgdGhpcyB2YWx1ZSB0byBwZXJmb3JtIGludGVybmFsIHRpbWluZyBjYWxjdWxh dGlvbnMgdGhhdCBhcmUgYmFzZWQKPiBvbiB0aGUgcmVmZXJlbmNlIGNsb2NrLgo+IAo+IFNpZ25l ZC1vZmYtYnk6IFRoaW5oIE5ndXllbiA8dGhpbmhuQHN5bm9wc3lzLmNvbT4KPiAtLS0KPiBDaGFu Z2VzIGluIHYyOgo+IC0gU3BsaXQgZnJvbSAidXNiOiBkd2MzOiBBZGQgcmVmZXJlbmNlIGNsb2Nr IHByb3BlcnRpZXMiCj4gLSBSZXZpc2UgY29tbWl0IG1lc3NhZ2UgYW5kIHByb3BlcnR5IGRlc2Ny aXB0aW9uCj4gCj4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvZHdjMy50 eHQgfCAyICsrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0t Z2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9kd2MzLnR4dCBiL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvZHdjMy50eHQKPiBpbmRleCA4ZTUy NjVlOWY2NTguLmI3ZTY3ZWRmZjliMiAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvdXNiL2R3YzMudHh0Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL3VzYi9kd2MzLnR4dAo+IEBAIC05OSw2ICs5OSw4IEBAIE9wdGlvbmFsIHBy b3BlcnRpZXM6Cj4gIAkJCXRoaXMgYW5kIHR4LXRoci1udW0tcGt0LXByZCB0byBhIHZhbGlkLCBu b24temVybyB2YWx1ZQo+ICAJCQkxLTE2IChEV0NfdXNiMzEgcHJvZ3JhbW1pbmcgZ3VpZGUgc2Vj dGlvbiAxLjIuMykgdG8KPiAgCQkJZW5hYmxlIHBlcmlvZGljIEVTUyBUWCB0aHJlc2hvbGQuCj4g KyAtIHNucHMscmVmY2xrLXBlcmlvZC1uczogaWYgc2V0LCB0aGlzIHZhbHVlIGluZm9ybXMgdGhl IGNvbnRyb2xsZXIgb2YgdGhlCj4gKwkJCXJlZmVyZW5jZSBjbG9jayBwZXJpb2QgaW4gbmFub3Nl Y29uZHMuCgpTaG91bGRuJ3QgeW91IGJlIGFibGUgdG8gcmV0cmlldmUgdGhlIHJlZmNsayBmcmVx dWVuY3kgYW5kIHRoZW4gCmNhbGN1bGF0ZSB0aGUgcGVyaW9kPwoKUm9iCg==