All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Pavel Tatashin <pasha.tatashin@soleen.com>,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] memory_hotplug: add missing newlines to debugging output
Date: Tue, 18 Dec 2018 21:26:05 +0000	[thread overview]
Message-ID: <20181218212605.4wa35jzlewp3rj7f@master> (raw)
In-Reply-To: <20181218162307.10518-1-mhocko@kernel.org>

On Tue, Dec 18, 2018 at 05:23:07PM +0100, Michal Hocko wrote:
>From: Michal Hocko <mhocko@suse.com>
>
>pages_correctly_probed is missing new lines which means that the line is
>not printed rightaway but it rather waits for additional printks.
>
>Add \n to all three messages in pages_correctly_probed.
>
>Fixes: b77eab7079d9 ("mm/memory_hotplug: optimize probe routine")
>Signed-off-by: Michal Hocko <mhocko@suse.com>

Reviewed-by: Wei Yang <richard.weiyang@gmail.com>

>---
> drivers/base/memory.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/base/memory.c b/drivers/base/memory.c
>index 0e5985682642..b5ff45ab7967 100644
>--- a/drivers/base/memory.c
>+++ b/drivers/base/memory.c
>@@ -207,15 +207,15 @@ static bool pages_correctly_probed(unsigned long start_pfn)
> 			return false;
> 
> 		if (!present_section_nr(section_nr)) {
>-			pr_warn("section %ld pfn[%lx, %lx) not present",
>+			pr_warn("section %ld pfn[%lx, %lx) not present\n",
> 				section_nr, pfn, pfn + PAGES_PER_SECTION);
> 			return false;
> 		} else if (!valid_section_nr(section_nr)) {
>-			pr_warn("section %ld pfn[%lx, %lx) no valid memmap",
>+			pr_warn("section %ld pfn[%lx, %lx) no valid memmap\n",
> 				section_nr, pfn, pfn + PAGES_PER_SECTION);
> 			return false;
> 		} else if (online_section_nr(section_nr)) {
>-			pr_warn("section %ld pfn[%lx, %lx) is already online",
>+			pr_warn("section %ld pfn[%lx, %lx) is already online\n",
> 				section_nr, pfn, pfn + PAGES_PER_SECTION);
> 			return false;
> 		}
>-- 
>2.19.2

-- 
Wei Yang
Help you, Help me

      parent reply	other threads:[~2018-12-18 21:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 16:23 Michal Hocko
2018-12-18 16:23 ` Michal Hocko
2018-12-18 16:34 ` Oscar Salvador
2018-12-18 21:26 ` Wei Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181218212605.4wa35jzlewp3rj7f@master \
    --to=richard.weiyang@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mhocko@suse.com \
    --cc=pasha.tatashin@soleen.com \
    --subject='Re: [PATCH] memory_hotplug: add missing newlines to debugging output' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.