All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/13] sk_buff: add extension infrastructure
Date: Wed, 19 Dec 2018 11:02:22 -0800 (PST)	[thread overview]
Message-ID: <20181219.110222.2160722788800016798.davem@davemloft.net> (raw)
In-Reply-To: <20181218161527.2760-1-fw@strlen.de>

From: Florian Westphal <fw@strlen.de>
Date: Tue, 18 Dec 2018 17:15:14 +0100

> TL;DR:
>  - objdiff shows no change if CONFIG_XFRM=n && BR_NETFILTER=n
>  - small size reduction when one or both options are set
>  - no changes in ipsec performance
> 
>  Changes since v1:
>  - Allocate entire extension space from a kmem_cache.
>  - Avoid atomic_dec_and_test operation on skb_ext_put() for refcnt == 1 case.
>    (similar to kfree_skbmem() fclone_ref use).
> 
> This adds an optional extension infrastructure, with ispec (xfrm) and
> bridge netfilter as first users.
 ...

Hey Florian, I just wanted to let you know that I'm actively reviewing this.

I have no major issues with the approach, but I just want to understand all
of the details before I apply this.

And honestly, if this turns out to be the wrong direction we can
revert and try doing this another way.

Anyways, just FYI...

  parent reply	other threads:[~2018-12-19 19:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 16:15 [PATCH net-next 0/13] sk_buff: add extension infrastructure Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 01/13] netfilter: avoid using skb->nf_bridge directly Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 02/13] sk_buff: add skb extension infrastructure Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 03/13] net: convert bridge_nf to use " Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 04/13] xfrm: change secpath_set to return secpath struct, not error value Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 05/13] net: move secpath_exist helper to sk_buff.h Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 06/13] net: use skb_sec_path helper in more places Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 07/13] drivers: net: intel: use secpath helpers " Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 08/13] drivers: net: ethernet: mellanox: use skb_sec_path helper Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 09/13] drivers: net: netdevsim: " Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 10/13] xfrm: use secpath_exist where applicable Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 11/13] drivers: chelsio: use skb_sec_path helper Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 12/13] xfrm: prefer secpath_set over secpath_dup Florian Westphal
2018-12-18 16:15 ` [PATCH net-next v2 13/13] net: switch secpath to use skb extension infrastructure Florian Westphal
2018-12-19 19:02 ` David Miller [this message]
2018-12-19 19:47   ` [PATCH net-next 0/13] sk_buff: add " David Miller
  -- strict thread matches above, loose matches on Subject: below --
2018-12-10 14:49 Florian Westphal
2018-12-13  4:08 ` Shannon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219.110222.2160722788800016798.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.