Hi Jeykumar, Thank you for the patch! Yet something to improve: [auto build test ERROR on robclark/msm-next] [also build test ERROR on v4.20-rc7 next-20181218] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jeykumar-Sankaran/drm-msm-dpu-fix-documentation-for-intf_type/20181218-070519 base: git://people.freedesktop.org/~robclark/linux msm-next config: arm64-allyesconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm64 All errors (new ones prefixed by >>): drivers/gpu//drm/msm/disp/dpu1/dpu_kms.c: In function '_dpu_kms_initialize_displayport': >> drivers/gpu//drm/msm/disp/dpu1/dpu_kms.c:449:13: error: 'struct msm_drm_private' has no member named 'dp'; did you mean 'edp'? if (!priv->dp) ^~ edp >> drivers/gpu//drm/msm/disp/dpu1/dpu_kms.c:458:7: error: implicit declaration of function 'msm_dp_modeset_init'; did you mean 'msm_edp_modeset_init'? [-Werror=implicit-function-declaration] rc = msm_dp_modeset_init(priv->dp, dev, encoder); ^~~~~~~~~~~~~~~~~~~ msm_edp_modeset_init drivers/gpu//drm/msm/disp/dpu1/dpu_kms.c:458:33: error: 'struct msm_drm_private' has no member named 'dp'; did you mean 'edp'? rc = msm_dp_modeset_init(priv->dp, dev, encoder); ^~ edp cc1: some warnings being treated as errors vim +449 drivers/gpu//drm/msm/disp/dpu1/dpu_kms.c 441 442 static int _dpu_kms_initialize_displayport(struct drm_device *dev, 443 struct msm_drm_private *priv, 444 struct dpu_kms *dpu_kms) 445 { 446 struct drm_encoder *encoder = NULL; 447 int rc; 448 > 449 if (!priv->dp) 450 return 0; 451 452 encoder = dpu_encoder_init(dev, DRM_MODE_ENCODER_TMDS); 453 if (IS_ERR(encoder)) { 454 DPU_ERROR("encoder init failed for dsi display\n"); 455 return PTR_ERR(encoder); 456 } 457 > 458 rc = msm_dp_modeset_init(priv->dp, dev, encoder); 459 if (rc) { 460 DPU_ERROR("modeset_init failed for DP, rc = %d\n", rc); 461 drm_encoder_cleanup(encoder); 462 } 463 464 return rc; 465 } 466 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation