From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6192C43387 for ; Thu, 20 Dec 2018 16:57:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC43C20815 for ; Thu, 20 Dec 2018 16:57:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732914AbeLTQ5m (ORCPT ); Thu, 20 Dec 2018 11:57:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54664 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbeLTQ5m (ORCPT ); Thu, 20 Dec 2018 11:57:42 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E4E5B7F771; Thu, 20 Dec 2018 16:57:41 +0000 (UTC) Received: from redhat.com (ovpn-123-95.rdu2.redhat.com [10.10.123.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D20A626FDC; Thu, 20 Dec 2018 16:57:40 +0000 (UTC) Date: Thu, 20 Dec 2018 11:57:38 -0500 From: Jerome Glisse To: Dan Williams Cc: Andrew Morton , Linux Kernel Mailing List , linux-mm , John Hubbard , David Nellans , Balbir Singh , Ross Zwisler Subject: Re: [HMM-v25 07/19] mm/ZONE_DEVICE: new type of ZONE_DEVICE for unaddressable memory v5 Message-ID: <20181220165738.GE3963@redhat.com> References: <20170817000548.32038-1-jglisse@redhat.com> <20170817000548.32038-8-jglisse@redhat.com> <20181220161538.GA3963@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 20 Dec 2018 16:57:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 20, 2018 at 08:47:39AM -0800, Dan Williams wrote: > On Thu, Dec 20, 2018 at 8:15 AM Jerome Glisse wrote: > [..] > > > Rather than try to figure out how to forward declare pmd_t, how about > > > just move dev_page_fault_t out of the generic dev_pagemap and into the > > > HMM specific container structure? This should be straightfoward on top > > > of the recent refactor. > > > > Fine with me. > > I was hoping you would reply with a patch. I'll take a look... Bit busy right now but i can do that after new years :) Cheers, Jérôme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by kanga.kvack.org (Postfix) with ESMTP id 9FCE48E0001 for ; Thu, 20 Dec 2018 11:57:43 -0500 (EST) Received: by mail-qt1-f199.google.com with SMTP id z6so2439802qtj.21 for ; Thu, 20 Dec 2018 08:57:43 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id t82si1134564qkl.141.2018.12.20.08.57.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Dec 2018 08:57:42 -0800 (PST) Date: Thu, 20 Dec 2018 11:57:38 -0500 From: Jerome Glisse Subject: Re: [HMM-v25 07/19] mm/ZONE_DEVICE: new type of ZONE_DEVICE for unaddressable memory v5 Message-ID: <20181220165738.GE3963@redhat.com> References: <20170817000548.32038-1-jglisse@redhat.com> <20170817000548.32038-8-jglisse@redhat.com> <20181220161538.GA3963@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Dan Williams Cc: Andrew Morton , Linux Kernel Mailing List , linux-mm , John Hubbard , David Nellans , Balbir Singh , Ross Zwisler On Thu, Dec 20, 2018 at 08:47:39AM -0800, Dan Williams wrote: > On Thu, Dec 20, 2018 at 8:15 AM Jerome Glisse wrote: > [..] > > > Rather than try to figure out how to forward declare pmd_t, how about > > > just move dev_page_fault_t out of the generic dev_pagemap and into the > > > HMM specific container structure? This should be straightfoward on top > > > of the recent refactor. > > > > Fine with me. > > I was hoping you would reply with a patch. I'll take a look... Bit busy right now but i can do that after new years :) Cheers, J�r�me