From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20B6C43387 for ; Fri, 21 Dec 2018 16:05:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A7E421920 for ; Fri, 21 Dec 2018 16:05:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=metanate.com header.i=@metanate.com header.b="qFa5XFJl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388202AbeLUQFQ (ORCPT ); Fri, 21 Dec 2018 11:05:16 -0500 Received: from dougal.metanate.com ([90.155.101.14]:39445 "EHLO metanate.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729268AbeLUQFP (ORCPT ); Fri, 21 Dec 2018 11:05:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=metanate.com; s=stronger; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References :In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NOwvhVdcPFWzLduLqDqyQbNnEYBnCK66DE311pDNx1E=; b=qFa5XFJltUiyPTZWQZjOxJxv9/ GL8nvZtPLU+QwPKdfGfnW7a2I9XT6J6h2y+dpy+R4Ym47LvZEsdDBdF0X6B0J9Mha9jAj8F/Qz7Xn Tmzly7DbtownP2GLWESoLUQuyVUfiJN/lebH6qMTXEKqipk35xy+5Txu82k+86PqMCdTkWt3UH6v4 Z74c2D7F+DPfkUVgSOFGsBijh1TfrFilf5gHT2qFvNDbGCHwBRjik06AdvN95AH1XTfQcCZJ/Dp5C fxm0TW/zY5z9WihTBUBlLrrfmm/QudwKkmKI/XChwfNo1kvwCEBfg+2JMrsVlsEOBeYjkFo4RVgjg DosJV/cA==; Received: from johnkeeping.plus.com ([81.174.171.191] helo=donbot) by shrek.metanate.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gaNIR-00018m-2x; Fri, 21 Dec 2018 16:05:07 +0000 Date: Fri, 21 Dec 2018 16:05:04 +0000 From: John Keeping To: Minas Harutyunyan Cc: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "arthur.petrosyan@synopsys.com" Subject: Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling Message-ID: <20181221160504.15e93827@donbot> In-Reply-To: <410670D7E743164D87FA6160E7907A56013A7BECBB@am04wembxa.internal.synopsys.com> References: <20181023134355.29829-1-john@metanate.com> <410670D7E743164D87FA6160E7907A56013A79E7CE@am04wembxa.internal.synopsys.com> <20181108173654.118f9e3e@donbot> <410670D7E743164D87FA6160E7907A56013A7A0F2B@am04wembxa.internal.synopsys.com> <410670D7E743164D87FA6160E7907A56013A7A12C1@am04wembxa.internal.synopsys.com> <20181109184246.33cb4487@donbot> <410670D7E743164D87FA6160E7907A56013A7A27D7@am04wembxa.internal.synopsys.com> <20181112224626.6b44568a@donbot> <410670D7E743164D87FA6160E7907A56013A7BAB28@am04wembxa.internal.synopsys.com> <20181218143504.027fc53c@donbot> <410670D7E743164D87FA6160E7907A56013A7BECBB@am04wembxa.internal.synopsys.com> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Authenticated: YES Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Minas, On Wed, 19 Dec 2018 14:09:01 +0000 Minas Harutyunyan wrote: > On 12/18/2018 6:35 PM, John Keeping wrote: > > Hi Minas, > > > > On Fri, 14 Dec 2018 09:00:08 +0000 > > Minas Harutyunyan wrote: > >> First of all, sorry for delayed answer. > >> Looks like similar issue seen by Andrzej Pietrasiewicz > >> : "dwc2 isochronous transfers issues". Same > >> feedback provided to Andrzej. > >> > >> I run tests on 4.20.0-rc4 in DDMA. By default IN ISOC traffic > >> failed because of BNA interrupts. It's happen because UAC2 > >> requests count set by default to 2. Our core and driver can't work > >> in DDMA with descriptor list length equal to 2. It's not possible > >> on time prepare next descriptors to avoid BNA interrupt. > >> > >> By changing UAC2_DEF_REQ_NUM to 4 all audio gadget tests passed > >> smoothly. Could you please apply this patch and run tests in DDMA > >> mode: > >> > >> diff --git a/drivers/usb/gadget/function/u_uac2.h > >> b/drivers/usb/gadget/function/u_uac2.h > >> index 8362ee572e1e..5e649259ab76 100644 > >> --- a/drivers/usb/gadget/function/u_uac2.h > >> +++ b/drivers/usb/gadget/function/u_uac2.h > >> @@ -21,7 +21,7 @@ > >> #define UAC2_DEF_CCHMASK 0x3 > >> #define UAC2_DEF_CSRATE 64000 > >> #define UAC2_DEF_CSSIZE 2 > >> -#define UAC2_DEF_REQ_NUM 2 > >> +#define UAC2_DEF_REQ_NUM 4 > >> > >> struct f_uac2_opts { > >> struct usb_function_instance func_inst; > >> > >> > >> If it will OK on your side also then will switch to BDMA mode and > >> debug. > > > > With DDMA enabled, I see the following error after the stream has > > been running for a while (anything from a few seconds to a few > > minutes): > > -- >8 -- > > [ 1798.836322] dwc2 ff580000.usb: dwc2_hsotg_ep_disable: called for > > ep0 [ 1798.836329] dwc2 ff580000.usb: dwc2_hsotg_ep_disable: called > > for ep0 [ 1798.851092] dwc2 ff580000.usb: new device is high-speed > > [ 1798.924461] dwc2 ff580000.usb: new device is high-speed > > [ 1798.982887] dwc2 ff580000.usb: new address 25 > > [ 1799.002463] configfs-gadget gadget: high-speed config #1: config > > -- 8< -- > > > > On the host side (Linux 4.18.16 Intel xHCI), I see this logged at > > the same time: > > > > -- >8 -- > > [1735740.716242] retire_capture_urb: usb 1-2.2.7: frame 0 active: > > -71 [1735740.716990] retire_capture_urb: usb 1-2.2.7: frame 0 > > active: -71 [1735740.717906] retire_capture_urb: usb 1-2.2.7: frame > > 0 active: -71 [1735740.718905] retire_capture_urb: usb 1-2.2.7: > > frame 0 active: -71 [1735740.719916] retire_capture_urb: usb > > 1-2.2.7: frame 0 active: -71 [1735740.720032] usb 1-2.2-port7: > > disabled by hub (EMI?), re-enabling... [1735740.720036] usb > > 1-2.2.7: USB disconnect, device number 28 [1735740.937500] usb > > 1-2.2.7: new high-speed USB device number 29 using xhci_hcd -- 8< -- > > > > The device does then enumerate and works for a period of time > > before the same error happens again. > > > From logs not clear who initiate disconnect: host or device. More > probably host, after some errors in retire_capture_urb initiate > disconnect. Do you have any idea? > Can't you connect device to host on same platform? > If root cause of disconnect by host is device issue, i.e. not able to > send to host data packets in time then I need device side dmesg log > with debug enabled. USB trace around the disconnect will help to > debug. I remember running a test with a hardware USB analyzer and which showed an isochronous packet with an incorrect length (much larger than it should have been) when the failure occurred. I don't have any logs from that test and I'm out of the office at the moment, but I will capture logs when I'm back in January. Thanks, John From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc2: gadget: fix ISOC frame overflow handling From: John Keeping Message-Id: <20181221160504.15e93827@donbot> Date: Fri, 21 Dec 2018 16:05:04 +0000 To: Minas Harutyunyan Cc: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "arthur.petrosyan@synopsys.com" List-ID: SGkgTWluYXMsCgpPbiBXZWQsIDE5IERlYyAyMDE4IDE0OjA5OjAxICswMDAwCk1pbmFzIEhhcnV0 eXVueWFuIDxtaW5hcy5oYXJ1dHl1bnlhbkBzeW5vcHN5cy5jb20+IHdyb3RlOgoKPiBPbiAxMi8x OC8yMDE4IDY6MzUgUE0sIEpvaG4gS2VlcGluZyB3cm90ZToKPiA+IEhpIE1pbmFzLAo+ID4gCj4g PiBPbiBGcmksIDE0IERlYyAyMDE4IDA5OjAwOjA4ICswMDAwCj4gPiBNaW5hcyBIYXJ1dHl1bnlh biA8bWluYXMuaGFydXR5dW55YW5Ac3lub3BzeXMuY29tPiB3cm90ZTogIAo+ID4+IEZpcnN0IG9m IGFsbCwgc29ycnkgZm9yIGRlbGF5ZWQgYW5zd2VyLgo+ID4+IExvb2tzIGxpa2Ugc2ltaWxhciBp c3N1ZSBzZWVuIGJ5IEFuZHJ6ZWogUGlldHJhc2lld2ljego+ID4+IDxhbmRyemVqLnBAc2Ftc3Vu Zy5jb20+OiAiZHdjMiBpc29jaHJvbm91cyB0cmFuc2ZlcnMgaXNzdWVzIi4gU2FtZQo+ID4+IGZl ZWRiYWNrIHByb3ZpZGVkIHRvIEFuZHJ6ZWouCj4gPj4KPiA+PiBJIHJ1biB0ZXN0cyBvbiA0LjIw LjAtcmM0IGluIERETUEuIEJ5IGRlZmF1bHQgSU4gSVNPQyB0cmFmZmljCj4gPj4gZmFpbGVkIGJl Y2F1c2Ugb2YgQk5BIGludGVycnVwdHMuIEl0J3MgaGFwcGVuIGJlY2F1c2UgVUFDMgo+ID4+IHJl cXVlc3RzIGNvdW50IHNldCBieSBkZWZhdWx0IHRvIDIuIE91ciBjb3JlIGFuZCBkcml2ZXIgY2Fu J3Qgd29yawo+ID4+IGluIERETUEgd2l0aCBkZXNjcmlwdG9yIGxpc3QgbGVuZ3RoIGVxdWFsIHRv IDIuIEl0J3Mgbm90IHBvc3NpYmxlCj4gPj4gb24gdGltZSBwcmVwYXJlIG5leHQgZGVzY3JpcHRv cnMgdG8gYXZvaWQgQk5BIGludGVycnVwdC4KPiA+Pgo+ID4+IEJ5IGNoYW5naW5nIFVBQzJfREVG X1JFUV9OVU0gdG8gNCBhbGwgYXVkaW8gZ2FkZ2V0IHRlc3RzIHBhc3NlZAo+ID4+IHNtb290aGx5 LiBDb3VsZCB5b3UgcGxlYXNlIGFwcGx5IHRoaXMgcGF0Y2ggYW5kIHJ1biB0ZXN0cyBpbiBERE1B Cj4gPj4gbW9kZToKPiA+Pgo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9nYWRnZXQvZnVu Y3Rpb24vdV91YWMyLmgKPiA+PiBiL2RyaXZlcnMvdXNiL2dhZGdldC9mdW5jdGlvbi91X3VhYzIu aAo+ID4+IGluZGV4IDgzNjJlZTU3MmUxZS4uNWU2NDkyNTlhYjc2IDEwMDY0NAo+ID4+IC0tLSBh L2RyaXZlcnMvdXNiL2dhZGdldC9mdW5jdGlvbi91X3VhYzIuaAo+ID4+ICsrKyBiL2RyaXZlcnMv dXNiL2dhZGdldC9mdW5jdGlvbi91X3VhYzIuaAo+ID4+IEBAIC0yMSw3ICsyMSw3IEBACj4gPj4g ICAgI2RlZmluZSBVQUMyX0RFRl9DQ0hNQVNLIDB4Mwo+ID4+ICAgICNkZWZpbmUgVUFDMl9ERUZf Q1NSQVRFIDY0MDAwCj4gPj4gICAgI2RlZmluZSBVQUMyX0RFRl9DU1NJWkUgMgo+ID4+IC0jZGVm aW5lIFVBQzJfREVGX1JFUV9OVU0gMgo+ID4+ICsjZGVmaW5lIFVBQzJfREVGX1JFUV9OVU0gNAo+ ID4+Cj4gPj4gICAgc3RydWN0IGZfdWFjMl9vcHRzIHsKPiA+PiAgICAgICAgICAgc3RydWN0IHVz Yl9mdW5jdGlvbl9pbnN0YW5jZSAgICBmdW5jX2luc3Q7Cj4gPj4KPiA+Pgo+ID4+IElmIGl0IHdp bGwgT0sgb24geW91ciBzaWRlIGFsc28gdGhlbiB3aWxsIHN3aXRjaCB0byBCRE1BIG1vZGUgYW5k Cj4gPj4gZGVidWcuICAKPiA+IAo+ID4gV2l0aCBERE1BIGVuYWJsZWQsIEkgc2VlIHRoZSBmb2xs b3dpbmcgZXJyb3IgYWZ0ZXIgdGhlIHN0cmVhbSBoYXMKPiA+IGJlZW4gcnVubmluZyBmb3IgYSB3 aGlsZSAoYW55dGhpbmcgZnJvbSBhIGZldyBzZWNvbmRzIHRvIGEgZmV3Cj4gPiBtaW51dGVzKTog Cj4gPiAtLSA+OCAtLSAgCj4gPiBbIDE3OTguODM2MzIyXSBkd2MyIGZmNTgwMDAwLnVzYjogZHdj Ml9oc290Z19lcF9kaXNhYmxlOiBjYWxsZWQgZm9yCj4gPiBlcDAgWyAxNzk4LjgzNjMyOV0gZHdj MiBmZjU4MDAwMC51c2I6IGR3YzJfaHNvdGdfZXBfZGlzYWJsZTogY2FsbGVkCj4gPiBmb3IgZXAw IFsgMTc5OC44NTEwOTJdIGR3YzIgZmY1ODAwMDAudXNiOiBuZXcgZGV2aWNlIGlzIGhpZ2gtc3Bl ZWQKPiA+IFsgMTc5OC45MjQ0NjFdIGR3YzIgZmY1ODAwMDAudXNiOiBuZXcgZGV2aWNlIGlzIGhp Z2gtc3BlZWQKPiA+IFsgMTc5OC45ODI4ODddIGR3YzIgZmY1ODAwMDAudXNiOiBuZXcgYWRkcmVz cyAyNQo+ID4gWyAxNzk5LjAwMjQ2M10gY29uZmlnZnMtZ2FkZ2V0IGdhZGdldDogaGlnaC1zcGVl ZCBjb25maWcgIzE6IGNvbmZpZwo+ID4gLS0gODwgLS0KPiA+IAo+ID4gT24gdGhlIGhvc3Qgc2lk ZSAoTGludXggNC4xOC4xNiBJbnRlbCB4SENJKSwgSSBzZWUgdGhpcyBsb2dnZWQgYXQKPiA+IHRo ZSBzYW1lIHRpbWU6Cj4gPiAgIAo+ID4gLS0gPjggLS0gIAo+ID4gWzE3MzU3NDAuNzE2MjQyXSBy ZXRpcmVfY2FwdHVyZV91cmI6IHVzYiAxLTIuMi43OiBmcmFtZSAwIGFjdGl2ZToKPiA+IC03MSBb MTczNTc0MC43MTY5OTBdIHJldGlyZV9jYXB0dXJlX3VyYjogdXNiIDEtMi4yLjc6IGZyYW1lIDAK PiA+IGFjdGl2ZTogLTcxIFsxNzM1NzQwLjcxNzkwNl0gcmV0aXJlX2NhcHR1cmVfdXJiOiB1c2Ig MS0yLjIuNzogZnJhbWUKPiA+IDAgYWN0aXZlOiAtNzEgWzE3MzU3NDAuNzE4OTA1XSByZXRpcmVf Y2FwdHVyZV91cmI6IHVzYiAxLTIuMi43Ogo+ID4gZnJhbWUgMCBhY3RpdmU6IC03MSBbMTczNTc0 MC43MTk5MTZdIHJldGlyZV9jYXB0dXJlX3VyYjogdXNiCj4gPiAxLTIuMi43OiBmcmFtZSAwIGFj dGl2ZTogLTcxIFsxNzM1NzQwLjcyMDAzMl0gdXNiIDEtMi4yLXBvcnQ3Ogo+ID4gZGlzYWJsZWQg YnkgaHViIChFTUk/KSwgcmUtZW5hYmxpbmcuLi4gWzE3MzU3NDAuNzIwMDM2XSB1c2IKPiA+IDEt Mi4yLjc6IFVTQiBkaXNjb25uZWN0LCBkZXZpY2UgbnVtYmVyIDI4IFsxNzM1NzQwLjkzNzUwMF0g dXNiCj4gPiAxLTIuMi43OiBuZXcgaGlnaC1zcGVlZCBVU0IgZGV2aWNlIG51bWJlciAyOSB1c2lu ZyB4aGNpX2hjZCAtLSA4PCAtLQo+ID4gCj4gPiBUaGUgZGV2aWNlIGRvZXMgdGhlbiBlbnVtZXJh dGUgYW5kIHdvcmtzIGZvciBhIHBlcmlvZCBvZiB0aW1lCj4gPiBiZWZvcmUgdGhlIHNhbWUgZXJy b3IgaGFwcGVucyBhZ2Fpbi4KPiA+ICAgCj4gIEZyb20gbG9ncyBub3QgY2xlYXIgd2hvIGluaXRp YXRlIGRpc2Nvbm5lY3Q6IGhvc3Qgb3IgZGV2aWNlLiAgTW9yZSAKPiBwcm9iYWJseSBob3N0LCBh ZnRlciBzb21lIGVycm9ycyBpbiByZXRpcmVfY2FwdHVyZV91cmIgaW5pdGlhdGUgCj4gZGlzY29u bmVjdC4gRG8geW91IGhhdmUgYW55IGlkZWE/Cj4gQ2FuJ3QgeW91IGNvbm5lY3QgZGV2aWNlIHRv IGhvc3Qgb24gc2FtZSBwbGF0Zm9ybT8KPiBJZiByb290IGNhdXNlIG9mIGRpc2Nvbm5lY3QgYnkg aG9zdCBpcyBkZXZpY2UgaXNzdWUsIGkuZS4gbm90IGFibGUgdG8gCj4gc2VuZCB0byBob3N0IGRh dGEgcGFja2V0cyBpbiB0aW1lIHRoZW4gSSBuZWVkIGRldmljZSBzaWRlIGRtZXNnIGxvZwo+IHdp dGggZGVidWcgZW5hYmxlZC4gVVNCIHRyYWNlIGFyb3VuZCB0aGUgZGlzY29ubmVjdCB3aWxsIGhl bHAgdG8KPiBkZWJ1Zy4KCkkgcmVtZW1iZXIgcnVubmluZyBhIHRlc3Qgd2l0aCBhIGhhcmR3YXJl IFVTQiBhbmFseXplciBhbmQgd2hpY2ggc2hvd2VkCmFuIGlzb2Nocm9ub3VzIHBhY2tldCB3aXRo IGFuIGluY29ycmVjdCBsZW5ndGggKG11Y2ggbGFyZ2VyIHRoYW4gaXQKc2hvdWxkIGhhdmUgYmVl bikgd2hlbiB0aGUgZmFpbHVyZSBvY2N1cnJlZC4KCkkgZG9uJ3QgaGF2ZSBhbnkgbG9ncyBmcm9t IHRoYXQgdGVzdCBhbmQgSSdtIG91dCBvZiB0aGUgb2ZmaWNlIGF0IHRoZQptb21lbnQsIGJ1dCBJ IHdpbGwgY2FwdHVyZSBsb2dzIHdoZW4gSSdtIGJhY2sgaW4gSmFudWFyeS4KCgpUaGFua3MsCkpv aG4K