From: yangerkun <yangerkun@huawei.com>
To: <gregkh@linuxfoundation.org>, <rafael@kernel.org>
Cc: <yangerkun@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] debugfs: remove inc_nlink in debugfs_create_automount
Date: Sat, 22 Dec 2018 16:45:36 +0800 [thread overview]
Message-ID: <20181222084536.21305-1-yangerkun@huawei.com> (raw)
Remove inc_nlink in debugfs_create_automount, or this inode will never
be free.
Signed-off-by: yangerkun <yangerkun@huawei.com>
---
fs/debugfs/inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index 13b01351dd1c..9294238e364f 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -551,12 +551,11 @@ struct dentry *debugfs_create_automount(const char *name,
if (unlikely(!inode))
return failed_creating(dentry);
+ /* directory inodes start off with i_nlink == 2 (for "." entry) */
make_empty_dir_inode(inode);
inode->i_flags |= S_AUTOMOUNT;
inode->i_private = data;
dentry->d_fsdata = (void *)f;
- /* directory inodes start off with i_nlink == 2 (for "." entry) */
- inc_nlink(inode);
d_instantiate(dentry, inode);
inc_nlink(d_inode(dentry->d_parent));
fsnotify_mkdir(d_inode(dentry->d_parent), dentry);
--
2.14.4
next reply other threads:[~2018-12-23 0:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-22 8:45 yangerkun [this message]
2018-12-22 11:25 ` [PATCH] debugfs: remove inc_nlink in debugfs_create_automount Greg KH
2018-12-24 3:47 ` yangerkun
2018-12-23 1:13 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181222084536.21305-1-yangerkun@huawei.com \
--to=yangerkun@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.