Hi Brad, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.20-rc7 next-20181221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Brad-Love/Add-Hauppauge-HVR1955-1975-devices/20181222-110834 base: git://linuxtv.org/media_tree.git master config: x86_64-rhel-7.2-clear (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> drivers/media//usb/pvrusb2/pvrusb2-devattr.c:541:21: error: 'pvr2_si2157_attach' undeclared here (not in a function); did you mean 'pvr2_si2168_attach'? .tuner_attach = pvr2_si2157_attach, ^~~~~~~~~~~~~~~~~~ pvr2_si2168_attach drivers/media//usb/pvrusb2/pvrusb2-devattr.c:548:12: warning: 'pvr2_si2157_attach' defined but not used [-Wunused-function] static int pvr2_si2157_attach(struct pvr2_dvb_adapter *adap) ^~~~~~~~~~~~~~~~~~ vim +541 drivers/media//usb/pvrusb2/pvrusb2-devattr.c 538 539 static const struct pvr2_dvb_props pvr2_160000_dvb_props = { 540 .frontend_attach = pvr2_dual_fe_attach, > 541 .tuner_attach = pvr2_si2157_attach, 542 }; 543 static const struct pvr2_dvb_props pvr2_160111_dvb_props = { 544 .frontend_attach = pvr2_lgdt3306a_attach, 545 .tuner_attach = pvr2_si2157_attach, 546 }; 547 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation