Hi Yangtao,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.20-rc7 next-20181221]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Yangtao-Li/staging-rtlwifi-convert-to-DEFINE_SHOW_ATTRIBUTE/20181222-085444
config: x86_64-randconfig-r0-12221938 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/staging/rtlwifi/debug.c: In function 'rtl_debug_add_one':
>> drivers/staging/rtlwifi/debug.c:515:10: error: 'fopname_fops' undeclared (first use in this function)
            &fopname_ ##fops);         \
             ^
   drivers/staging/rtlwifi/debug.c:519:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE'
      RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
      ^~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtlwifi/debug.c:545:2: note: in expansion of macro 'RTL_DEBUGFS_ADD'
     RTL_DEBUGFS_ADD(mac_0);
     ^~~~~~~~~~~~~~~
   drivers/staging/rtlwifi/debug.c:515:10: note: each undeclared identifier is reported only once for each function it appears in
            &fopname_ ##fops);         \
             ^
   drivers/staging/rtlwifi/debug.c:519:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE'
      RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common)
      ^~~~~~~~~~~~~~~~~~~~
   drivers/staging/rtlwifi/debug.c:545:2: note: in expansion of macro 'RTL_DEBUGFS_ADD'
     RTL_DEBUGFS_ADD(mac_0);
     ^~~~~~~~~~~~~~~

vim +/fopname_fops +515 drivers/staging/rtlwifi/debug.c

   509	
   510	#define RTL_DEBUGFS_ADD_CORE(name, mode, fopname)			   \
   511		do {								   \
   512			rtl_debug_priv_ ##name.rtlpriv = rtlpriv;		   \
   513			debugfs_create_file(#name, mode, parent,		   \
   514					    &rtl_debug_priv_ ##name,		   \
 > 515					    &fopname_ ##fops);		   	   \
   516		} while (0)
   517	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation