[PATCH] net/mlx5e: fix semicolon.cocci warnings

[PATCH] net/mlx5e: fix semicolon.cocci warnings

[kbuild test robot]

From: kbuild test robot <fengguang.wu@intel.com>

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
CC: Gavi Teitz <gavi@mellanox.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   340ae71f9dd421227a58c14a909b63033745dca4
commit: 4c8fb2986d44c5a75949a88ac61deec0ed50a542 [11213/11734] net/mlx5e: Increase VF representors' SQ size to 128

 en_rep.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
@@ -1336,7 +1336,7 @@ static void mlx5e_build_rep_params(struc
 	if (rep->vport == FDB_UPLINK_VPORT)
 		params->log_sq_size = MLX5E_PARAMS_DEFAULT_LOG_SQ_SIZE;
 	else
-		params->log_sq_size = MLX5E_REP_PARAMS_DEF_LOG_SQ_SIZE;;
+		params->log_sq_size = MLX5E_REP_PARAMS_DEF_LOG_SQ_SIZE;
 
 	/* RQ */
 	mlx5e_build_rq_params(mdev, params);

Re: [PATCH] net/mlx5e: fix semicolon.cocci warnings

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

On Sat, Dec 22, 2018 at 08:02:16PM +0800, kbuild test robot wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded semicolon
>
>
>  Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
> CC: Gavi Teitz <gavi@mellanox.com>
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
> ---

Dave,

Can you please apply this small fix?

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH] net/mlx5e: fix semicolon.cocci warnings

[David Miller]

From: Leon Romanovsky <leon@kernel.org>
Date: Sun, 23 Dec 2018 09:06:13 +0200

> Can you please apply this small fix?

Sure, I (eventually) will.  I'm just trying to figure out a few procedural
issues with handling the early net-next pull request before I start tossing
more changes on top.

Thanks!

Re: [PATCH] net/mlx5e: fix semicolon.cocci warnings

[David Miller]

From: kbuild test robot <fengguang.wu@intel.com>
Date: Sat, 22 Dec 2018 20:02:16 +0800

> From: kbuild test robot <fengguang.wu@intel.com>
> 
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
> CC: Gavi Teitz <gavi@mellanox.com>
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>

Applied.

[PATCH] net/mlx5e: fix semicolon.cocci warnings

[kbuild test robot]

drivers/net/ethernet/mellanox/mlx5/core/en_main.c:1970:2-3: Unneeded semicolon
drivers/net/ethernet/mellanox/mlx5/core/en_main.c:1959:2-3: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

CC: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 en_main.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -1956,7 +1956,7 @@ static int mlx5_vport_link2ifla(u8 esw_l
 		return IFLA_VF_LINK_STATE_DISABLE;
 	case MLX5_ESW_VPORT_ADMIN_STATE_UP:
 		return IFLA_VF_LINK_STATE_ENABLE;
-	};
+	}
 	return IFLA_VF_LINK_STATE_AUTO;
 }
 
@@ -1967,7 +1967,7 @@ static int mlx5_ifla_link2vport(u8 ifla_
 		return MLX5_ESW_VPORT_ADMIN_STATE_DOWN;
 	case IFLA_VF_LINK_STATE_ENABLE:
 		return MLX5_ESW_VPORT_ADMIN_STATE_UP;
-	};
+	}
 	return MLX5_ESW_VPORT_ADMIN_STATE_AUTO;
 }