* [PATCH] net/mlx5e: fix semicolon.cocci warnings
[not found] <201812222032.13tR4nHr%fengguang.wu@intel.com>
@ 2018-12-22 12:02 ` kbuild test robot
2018-12-23 7:06 ` Leon Romanovsky
2018-12-24 22:20 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: kbuild test robot @ 2018-12-22 12:02 UTC (permalink / raw)
To: Gavi Teitz
Cc: kbuild-all, Saeed Mahameed, Or Gerlitz, Leon Romanovsky, netdev,
linux-rdma, linux-kernel
From: kbuild test robot <fengguang.wu@intel.com>
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
CC: Gavi Teitz <gavi@mellanox.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 340ae71f9dd421227a58c14a909b63033745dca4
commit: 4c8fb2986d44c5a75949a88ac61deec0ed50a542 [11213/11734] net/mlx5e: Increase VF representors' SQ size to 128
en_rep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
@@ -1336,7 +1336,7 @@ static void mlx5e_build_rep_params(struc
if (rep->vport == FDB_UPLINK_VPORT)
params->log_sq_size = MLX5E_PARAMS_DEFAULT_LOG_SQ_SIZE;
else
- params->log_sq_size = MLX5E_REP_PARAMS_DEF_LOG_SQ_SIZE;;
+ params->log_sq_size = MLX5E_REP_PARAMS_DEF_LOG_SQ_SIZE;
/* RQ */
mlx5e_build_rq_params(mdev, params);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/mlx5e: fix semicolon.cocci warnings
2018-12-22 12:02 ` [PATCH] net/mlx5e: fix semicolon.cocci warnings kbuild test robot
@ 2018-12-23 7:06 ` Leon Romanovsky
2018-12-24 18:01 ` David Miller
2018-12-24 22:20 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Leon Romanovsky @ 2018-12-23 7:06 UTC (permalink / raw)
To: David S. Miller, kbuild test robot
Cc: Gavi Teitz, kbuild-all, Saeed Mahameed, Or Gerlitz, netdev,
linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
On Sat, Dec 22, 2018 at 08:02:16PM +0800, kbuild test robot wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
> CC: Gavi Teitz <gavi@mellanox.com>
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
> ---
Dave,
Can you please apply this small fix?
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/mlx5e: fix semicolon.cocci warnings
2018-12-23 7:06 ` Leon Romanovsky
@ 2018-12-24 18:01 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2018-12-24 18:01 UTC (permalink / raw)
To: leon
Cc: fengguang.wu, gavi, kbuild-all, saeedm, ogerlitz, netdev,
linux-rdma, linux-kernel
From: Leon Romanovsky <leon@kernel.org>
Date: Sun, 23 Dec 2018 09:06:13 +0200
> Can you please apply this small fix?
Sure, I (eventually) will. I'm just trying to figure out a few procedural
issues with handling the early net-next pull request before I start tossing
more changes on top.
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/mlx5e: fix semicolon.cocci warnings
2018-12-22 12:02 ` [PATCH] net/mlx5e: fix semicolon.cocci warnings kbuild test robot
2018-12-23 7:06 ` Leon Romanovsky
@ 2018-12-24 22:20 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2018-12-24 22:20 UTC (permalink / raw)
To: fengguang.wu
Cc: gavi, kbuild-all, saeedm, ogerlitz, leon, netdev, linux-rdma,
linux-kernel
From: kbuild test robot <fengguang.wu@intel.com>
Date: Sat, 22 Dec 2018 20:02:16 +0800
> From: kbuild test robot <fengguang.wu@intel.com>
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
> CC: Gavi Teitz <gavi@mellanox.com>
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] net/mlx5e: fix semicolon.cocci warnings
2015-11-29 15:37 ` Or Gerlitz
@ 2015-11-29 16:35 ` kbuild test robot
0 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2015-11-29 16:35 UTC (permalink / raw)
To: Or Gerlitz
Cc: kbuild-all, David S. Miller, netdev, Don Dutile, Doug Ledford,
Saeed Mahameed, Tal Alon, Hadar Har-Zion, Rony Efraim,
Or Gerlitz
drivers/net/ethernet/mellanox/mlx5/core/en_main.c:1970:2-3: Unneeded semicolon
drivers/net/ethernet/mellanox/mlx5/core/en_main.c:1959:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
en_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -1956,7 +1956,7 @@ static int mlx5_vport_link2ifla(u8 esw_l
return IFLA_VF_LINK_STATE_DISABLE;
case MLX5_ESW_VPORT_ADMIN_STATE_UP:
return IFLA_VF_LINK_STATE_ENABLE;
- };
+ }
return IFLA_VF_LINK_STATE_AUTO;
}
@@ -1967,7 +1967,7 @@ static int mlx5_ifla_link2vport(u8 ifla_
return MLX5_ESW_VPORT_ADMIN_STATE_DOWN;
case IFLA_VF_LINK_STATE_ENABLE:
return MLX5_ESW_VPORT_ADMIN_STATE_UP;
- };
+ }
return MLX5_ESW_VPORT_ADMIN_STATE_AUTO;
}
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-24 22:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201812222032.13tR4nHr%fengguang.wu@intel.com>
2018-12-22 12:02 ` [PATCH] net/mlx5e: fix semicolon.cocci warnings kbuild test robot
2018-12-23 7:06 ` Leon Romanovsky
2018-12-24 18:01 ` David Miller
2018-12-24 22:20 ` David Miller
2015-11-29 16:35 [PATCH net-next V1 18/18] net/mlx5e: Add support for SR-IOV ndos kbuild test robot
2015-11-29 15:37 ` Or Gerlitz
2015-11-29 16:35 ` [PATCH] net/mlx5e: fix semicolon.cocci warnings kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.