All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Sam Ravnborg <sam@ravnborg.org>,
	dri-devel@lists.freedesktop.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 2/6] drm: include kernel.h and agp_backend.h from intel-gtt.h
Date: Thu, 27 Dec 2018 17:04:54 +0100	[thread overview]
Message-ID: <20181227160454.GJ9058@dvetter-linux.ger.corp.intel.com> (raw)
In-Reply-To: <9414800f89d6f326c6e9173233bf6c4dee254d9a.1545915059.git.jani.nikula@intel.com>

On Thu, Dec 27, 2018 at 02:56:37PM +0200, Jani Nikula wrote:
> Make it easier to drop drmP.h includes.
> 
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Makes sense.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  include/drm/intel-gtt.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/drm/intel-gtt.h b/include/drm/intel-gtt.h
> index 2324c84a25c0..71d81923e6b0 100644
> --- a/include/drm/intel-gtt.h
> +++ b/include/drm/intel-gtt.h
> @@ -4,6 +4,9 @@
>  #ifndef _DRM_INTEL_GTT_H
>  #define	_DRM_INTEL_GTT_H
>  
> +#include <linux/agp_backend.h>
> +#include <linux/kernel.h>
> +
>  void intel_gtt_get(u64 *gtt_total,
>  		   phys_addr_t *mappable_base,
>  		   resource_size_t *mappable_end);
> -- 
> 2.11.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-12-27 16:04 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-27 12:56 [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work Jani Nikula
2018-12-27 12:56 ` [PATCH 1/6] drm: include drm_device.h from drm_legacy.h Jani Nikula
2018-12-27 16:04   ` Daniel Vetter
2018-12-27 16:08     ` Daniel Vetter
2018-12-28  8:23       ` Jani Nikula
2018-12-28 12:10         ` Daniel Vetter
2018-12-28 13:05           ` Jani Nikula
2018-12-28 13:04   ` [PATCH v2] drm: un-inline drm_legacy_findmap() Jani Nikula
2018-12-28 14:11     ` Daniel Vetter
2018-12-30 18:57     ` Laurent Pinchart
2018-12-27 12:56 ` [PATCH 2/6] drm: include kernel.h and agp_backend.h from intel-gtt.h Jani Nikula
2018-12-27 16:04   ` Daniel Vetter [this message]
2018-12-27 12:56 ` [PATCH 3/6] drm: include idr.h from drm_file.h Jani Nikula
2018-12-27 16:05   ` Daniel Vetter
2018-12-30 19:03   ` Laurent Pinchart
2018-12-27 12:56 ` [PATCH 4/6] drm: include types.h from drm_hdcp.h Jani Nikula
2018-12-27 16:07   ` Daniel Vetter
2018-12-30 19:12   ` Laurent Pinchart
2018-12-27 12:56 ` [PATCH 5/6] drm: include drm_file.h from drm_syncobj.h Jani Nikula
2018-12-27 16:08   ` Daniel Vetter
2018-12-28  8:28   ` [PATCH v2] drm: forward declare struct drm_file in drm_syncobj.h Jani Nikula
2018-12-30 19:16     ` Laurent Pinchart
2018-12-27 12:56 ` [PATCH 6/6] drm/i915: drop all drmP.h includes Jani Nikula
2018-12-27 16:12   ` Daniel Vetter
2018-12-27 16:27     ` Jani Nikula
2018-12-28 11:59       ` Daniel Vetter
2018-12-27 12:59 ` [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work Jani Nikula
2018-12-27 15:05 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-12-27 16:01 ` [PATCH 0/6] " Daniel Vetter
2018-12-28 15:01   ` Jani Nikula
2019-01-02  7:47     ` Jani Nikula
2019-01-02  8:25       ` Laurent Pinchart
2019-01-02  9:45         ` Jani Nikula
2018-12-27 17:26 ` ✓ Fi.CI.IGT: success for " Patchwork
2018-12-28  8:56 ` ✓ Fi.CI.BAT: success for drm/i915: drmP.h include removal w/ drm prep work (rev2) Patchwork
2018-12-28 10:12 ` ✓ Fi.CI.IGT: " Patchwork
2018-12-28 12:33 ` [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work Sam Ravnborg
2018-12-28 13:20 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: drmP.h include removal w/ drm prep work (rev3) Patchwork
2018-12-28 13:39 ` ✓ Fi.CI.BAT: success " Patchwork
2018-12-28 14:49 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181227160454.GJ9058@dvetter-linux.ger.corp.intel.com \
    --to=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.