From: Sasha Levin <sashal@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Mark Brown <broonie@kernel.org>,
stable@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v4.14.x 2/2] spi: imx: mx51-ecspi: Move some initialisation to prepare_message hook.
Date: Thu, 27 Dec 2018 15:56:00 -0500 [thread overview]
Message-ID: <20181227205600.GT86645@sasha-vm> (raw)
In-Reply-To: <20181223212122.19737-2-u.kleine-koenig@pengutronix.de>
On Sun, Dec 23, 2018 at 10:21:22PM +0100, Uwe Kleine-König wrote:
>The relevant difference between prepare_message and config is that the
>former is run before the CS signal is asserted. So the polarity of the
>CLK line must be configured in prepare_message as an edge generated by
>config might already result in a latch of the MOSI line.
>
>Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>Signed-off-by: Mark Brown <broonie@kernel.org>
>[ukleinek: backport to v4.14.x]
>Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Queued both for 4.14, thank you.
--
Thanks,
Sasha
prev parent reply other threads:[~2018-12-27 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 14:43 suggest 00b80ac93553 ("spi: imx: mx51-ecspi: Move some initialisation to prepare_message hook.") for stable backports Uwe Kleine-König
2018-12-20 14:55 ` Mark Brown
2018-12-22 0:06 ` Sasha Levin
2018-12-23 21:21 ` [PATCH v4.14.x 1/2] spi: imx: add a device specific prepare_message callback Uwe Kleine-König
2018-12-23 21:21 ` [PATCH v4.14.x 2/2] spi: imx: mx51-ecspi: Move some initialisation to prepare_message hook Uwe Kleine-König
2018-12-27 20:56 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181227205600.GT86645@sasha-vm \
--to=sashal@kernel.org \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.