All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Wei Liu" <wei.liu2@citrix.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	"Roger Pau Monné" <roger.pau@cirix.com>,
	"Roger Pau Monne" <roger.pau@citrix.com>
Subject: [PATCH v2 3/4] x86/e820: assume memmap provided when booted virtualized is correct
Date: Fri, 28 Dec 2018 13:04:03 +0100	[thread overview]
Message-ID: <20181228120404.50346-4-roger.pau@citrix.com> (raw)
In-Reply-To: <20181228120404.50346-1-roger.pau@citrix.com>

This implies there's no need to forcefully reserve the VGA MMIO
region, since the memory map provided will be correct.

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@cirix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
Changes since v1:
 - Assume the memory map is always correct when booted as a guest
   under any hypervisor, not only Xen.
---
 xen/arch/x86/e820.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c
index 5b63667087..2407367c57 100644
--- a/xen/arch/x86/e820.c
+++ b/xen/arch/x86/e820.c
@@ -537,11 +537,12 @@ static void __init machine_specific_memory_setup(struct e820map *raw)
 
     reserve_dmi_region();
 
-    /*
-     * Some BIOSes claim RAM in the 640k - 1M region.
-     * Not right. Fix it up.
-     */
-    reserve_vga_region();
+    if ( !cpu_has_hypervisor )
+        /*
+         * Some BIOSes claim RAM in the 640k - 1M region.
+         * Not right. Fix it up.
+         */
+        reserve_vga_region();
 
     top_of_ram = mtrr_top_of_ram();
     if ( top_of_ram )
-- 
2.17.2 (Apple Git-113)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-12-28 12:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-28 12:04 [PATCH v2 0/4] x86/shim: minor fixes to the pv-shim mode Roger Pau Monne
2018-12-28 12:04 ` [PATCH v2 1/4] x86/e820: introduce a function to remove ranges from e820 Roger Pau Monne
2019-01-07 16:53   ` Jan Beulich
2018-12-28 12:04 ` [PATCH v2 2/4] x86/e820: do not fixup memmap in copy_e820_map Roger Pau Monne
2019-01-02 12:44   ` Wei Liu
2019-01-07 16:58   ` Jan Beulich
2018-12-28 12:04 ` Roger Pau Monne [this message]
2019-01-02 12:44   ` [PATCH v2 3/4] x86/e820: assume memmap provided when booted virtualized is correct Wei Liu
2019-01-08  9:56     ` Jan Beulich
2018-12-28 12:04 ` [PATCH v2 4/4] x86/shim: only mark special pages as RAM in pvshim mode Roger Pau Monne
2019-01-08  9:00   ` Jan Beulich
2018-12-28 14:58 ` [PATCH v2 0/4] x86/shim: minor fixes to the pv-shim mode Andrew Cooper
2018-12-28 15:57   ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181228120404.50346-4-roger.pau@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@cirix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.