From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/dependencies: require at least CMake 3.8
Date: Mon, 31 Dec 2018 17:26:38 +0100 [thread overview]
Message-ID: <20181231162638.13606-1-thomas.petazzoni@bootlin.com> (raw)
The json-for-modern-cpp package unfortunately now requires CMake >=
3.8, so we need to bump our requirement from 3.1 to 3.8. If the host
doesn't have a CMake >= 3.8, Buildroot will build its own host-cmake
package.
Fixes:
http://autobuild.buildroot.org/results/1f893d8bc7df3bfefd31df69aba918e2121cfaf7/
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
support/dependencies/check-host-cmake.mk | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/support/dependencies/check-host-cmake.mk b/support/dependencies/check-host-cmake.mk
index 4300e6f600..3ea422ea87 100644
--- a/support/dependencies/check-host-cmake.mk
+++ b/support/dependencies/check-host-cmake.mk
@@ -1,14 +1,5 @@
-# Versions before 3.0 are affected by the bug described in
-# https://git.busybox.net/buildroot/commit/?id=ef2c1970e4bff3be3992014070392b0e6bc28bd2
-# and fixed in upstream CMake in version 3.0:
-# https://cmake.org/gitweb?p=cmake.git;h=e8b8b37ef6fef094940d3384df5a1d421b9fa568
-#
-# Set this to either 3.0 or higher, depending on the highest minimum
-# version required by any of the packages bundled in Buildroot. If a
-# package is bumped or a new one added, and it requires a higher
-# version, our cmake infra will catch it and whine.
-#
-BR2_CMAKE_VERSION_MIN = 3.1
+# The json-for-modern-cpp package needs at least CMake 3.8
+BR2_CMAKE_VERSION_MIN = 3.8
BR2_CMAKE_CANDIDATES ?= cmake cmake3
BR2_CMAKE ?= $(call suitable-host-package,cmake,\
--
2.20.1
next reply other threads:[~2018-12-31 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 16:26 Thomas Petazzoni [this message]
2018-12-31 16:44 ` [Buildroot] [PATCH] support/dependencies: require at least CMake 3.8 Yann E. MORIN
2018-12-31 16:47 ` Thomas Petazzoni
2018-12-31 17:00 ` Yann E. MORIN
2018-12-31 17:18 ` Yann E. MORIN
2018-12-31 17:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181231162638.13606-1-thomas.petazzoni@bootlin.com \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.